Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required dependencies for benchmark target #110510

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

a-wallen
Copy link
Contributor

@a-wallen a-wallen commented Aug 29, 2022

The flutter_gallery_macos__compile target was missing dependencies that were required in order to run the benchmark test. To test whether the dependencies added were the bare minimum, bringup: true was removed to iterate against presubmit checks rather than postsubmit. The change was checked in, but was later reverted to ensure that a bringup test wasn't breaking the tree.

Issues #110126

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@goderbauer goderbauer added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-infra Owned by Infrastructure team labels Aug 29, 2022
Copy link
Contributor

@yaakovschectman yaakovschectman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-infra Owned by Infrastructure team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants