Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support single arch local engines for 'build macos-framework' and 'ios-framework' #110564

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Support single arch local engines for 'build macos-framework' and 'ios-framework' #110564

merged 1 commit into from
Aug 30, 2022

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Aug 30, 2022

Pass the artifacts through these commands, if local engine then only build for a single arch.

Fixes #110335
Related to #100804 and #100811

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. platform-mac Building on or for macOS specifically labels Aug 30, 2022
@jmagman jmagman self-assigned this Aug 30, 2022
cbracken
cbracken approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 30, 2022
@auto-submit auto-submit bot merged commit 5f5d480 into flutter:master Aug 30, 2022
@jmagman jmagman mentioned this pull request Aug 30, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 31, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 31, 2022
@engine-flutter-autoroll
5f5d480 Support single arch local engines for 'build macos-framework'…
15ce8a1 
… and 'ios-framework' (flutter/flutter#110564)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2022
@engine-flutter-autoroll
5f5d4802f Support single arch local engines for 'build macos-framewor…
b50044f 
…k' and 'ios-framework' (flutter/flutter#110564)
@jmagman jmagman deleted the build-macos-archs branch October 12, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbracken cbracken cbracken approved these changes

Assignees

@jmagman jmagman

Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-ios iOS applications specifically platform-mac Building on or for macOS specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flutter build macos-framework doesn't work with custom engine (M1 Mac)
2 participants
@jmagman @cbracken