Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate device lab runner to null safety #110582

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Migrate device lab runner to null safety #110582

merged 1 commit into from
Aug 30, 2022

Conversation

mit-mit
Copy link
Member

@mit-mit mit-mit commented Aug 30, 2022

Migrate device lab runner_test.dart to null safety.

Contributes to #110021

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Aug 30, 2022
@mit-mit mit-mit mentioned this pull request Aug 30, 2022
Closed
3 tasks
goderbauer
goderbauer approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you!

@mit-mit mit-mit changed the title Migrate device lab runner to nulls safety Migrate device lab runner to null safety Aug 30, 2022
@mit-mit mit-mit merged commit 253e3c0 into flutter:master Aug 30, 2022
@mit-mit mit-mit deleted the nullsafedevicelab branch August 30, 2022 17:46
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 31, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 31, 2022
@engine-flutter-autoroll
253e3c0 Migrate device lab runner to nulls safety (flutter/flutter#11…
7f5a9ee 
…0582)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2022
@engine-flutter-autoroll
253e3c085 Migrate device lab runner to nulls safety (flutter/flutter#…
b72626e 
…110582)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mit-mit @goderbauer