Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Benchmark: platform_views_layout] show and hide more PlatformViews #110688

Merged
merged 1 commit into from
Sep 2, 2022
Merged

[Benchmark: platform_views_layout] show and hide more PlatformViews #110688

merged 1 commit into from
Sep 2, 2022

Conversation

cyanglaz
Copy link
Contributor

This PR adds 5 times of the scrolling so more PlatformViews are shown and hidden during the test. This can potentially be more useful to caught bugs where the PlatformViews are leaking memories.

Potentially fix: #110038

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: scrolling Viewports, list views, slivers, etc. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. labels Aug 31, 2022
@cyanglaz cyanglaz requested a review from xster August 31, 2022 17:38
@cyanglaz
Copy link
Contributor Author

@godofredoc If this is to be land, we should see a regression on benchmark because we are scrolling more. We will need to override the benchmark.

@godofredoc
Copy link
Contributor

@godofredoc If this is to be land, we should see a regression on benchmark because we are scrolling more. We will need to override the benchmark.

Thanks for letting us know. @zanderso FYI

@zanderso
Copy link
Member

ACK. cc @jason-simmons this week's sheriff.

@cyanglaz cyanglaz mentioned this pull request Sep 1, 2022
Merged
8 tasks
@cyanglaz cyanglaz added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 2, 2022
@cyanglaz
Copy link
Contributor Author

cyanglaz commented Sep 2, 2022

The luci-flutter check is failing but I saw the tree is open. Is there a way to re-trigger the check?

@auto-submit auto-submit bot merged commit 1560d0c into flutter:master Sep 2, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2022
@engine-flutter-autoroll
1560d0cef [Benchmark: platform_views_layout] show and hide more Platf…
94624c0 
…ormViews (flutter/flutter#110688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2022
@engine-flutter-autoroll
1560d0cef [Benchmark: platform_views_layout] show and hide more Platf…
ebfccc5 
…ormViews (flutter/flutter#110688)
@cyanglaz
Copy link
Contributor Author

cyanglaz commented Sep 2, 2022

This has landed. Expected to see a benchmark regression.

@cyanglaz cyanglaz deleted the platform_view_benchmark_scroll_more branch September 2, 2022 18:16
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2022
@engine-flutter-autoroll
1560d0cef [Benchmark: platform_views_layout] show and hide more Platf…
b5a5451 
…ormViews (flutter/flutter#110688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2022
@engine-flutter-autoroll
1560d0cef [Benchmark: platform_views_layout] show and hide more Platf…
eb6e5a1 
…ormViews (flutter/flutter#110688)
This was referenced Sep 3, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2022
@engine-flutter-autoroll
1560d0cef [Benchmark: platform_views_layout] show and hide more Platf…
7d94d77 
…ormViews (flutter/flutter#110688)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 3, 2022
@engine-flutter-autoroll
1560d0c [Benchmark: platform_views_layout] show and hide more Platfor…
2d8d43a 
…mViews (flutter/flutter#110688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2022
@engine-flutter-autoroll
1560d0cef [Benchmark: platform_views_layout] show and hide more Platf…
d8545dd 
…ormViews (flutter/flutter#110688)
This was referenced Sep 4, 2022
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2022
@engine-flutter-autoroll
1560d0cef [Benchmark: platform_views_layout] show and hide more Platf…
ed5d6ac 
…ormViews (flutter/flutter#110688)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 4, 2022
@engine-flutter-autoroll
1560d0c [Benchmark: platform_views_layout] show and hide more Platfor…
e035e71 
…mViews (flutter/flutter#110688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2022
@engine-flutter-autoroll
1560d0cef [Benchmark: platform_views_layout] show and hide more Platf…
0bf56e8 
…ormViews (flutter/flutter#110688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2022
@engine-flutter-autoroll
1560d0cef [Benchmark: platform_views_layout] show and hide more Platf…
483da6f 
…ormViews (flutter/flutter#110688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2022
@engine-flutter-autoroll
1560d0cef [Benchmark: platform_views_layout] show and hide more Platf…
210dd00 
…ormViews (flutter/flutter#110688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2022
@engine-flutter-autoroll
1560d0cef [Benchmark: platform_views_layout] show and hide more Platf…
e779673 
…ormViews (flutter/flutter#110688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2022
@engine-flutter-autoroll
1560d0cef [Benchmark: platform_views_layout] show and hide more Platf…
34ec8a4 
…ormViews (flutter/flutter#110688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2022
@engine-flutter-autoroll
1560d0cef [Benchmark: platform_views_layout] show and hide more Platf…
7e61dc1 
…ormViews (flutter/flutter#110688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022
@engine-flutter-autoroll
1560d0cef [Benchmark: platform_views_layout] show and hide more Platf…
246a376 
…ormViews (flutter/flutter#110688)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022
@engine-flutter-autoroll
1560d0cef [Benchmark: platform_views_layout] show and hide more Platf…
ba4b34f 
…ormViews (flutter/flutter#110688)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022
@engine-flutter-autoroll
1560d0cef [Benchmark: platform_views_layout] show and hide more Platf…
a3d818b 
…ormViews (flutter/flutter#110688)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022
@engine-flutter-autoroll
1560d0cef [Benchmark: platform_views_layout] show and hide more Platf…
021cdf9 
…ormViews (flutter/flutter#110688)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022
@engine-flutter-autoroll
1560d0cef [Benchmark: platform_views_layout] show and hide more Platf…
5981ab2 
…ormViews (flutter/flutter#110688)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2022
@engine-flutter-autoroll
1560d0cef [Benchmark: platform_views_layout] show and hide more Platf…
422de2e 
…ormViews (flutter/flutter#110688)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@xster xster Awaiting requested review from xster

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: scrolling Viewports, list views, slivers, etc. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a benchmark test that loads and dismiss a PlatformView multiple times.
4 participants
@cyanglaz @godofredoc @zanderso @chinmaygarde