Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove errant double spaces #110758

Merged
merged 4 commits into from
Sep 2, 2022
Merged

Remove errant double spaces #110758

merged 4 commits into from
Sep 2, 2022

Conversation

guidezpl
Copy link
Member

@guidezpl guidezpl commented Sep 1, 2022

Remove errant double spaces (there were no triple spaces), avoiding cases where we use tables or uses spaces to draw diagrams in documentation.

Fixes #110757

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: animation Animation APIs a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: cupertino flutter/packages/flutter/cupertino repository f: focus Focus traversal, gaining or losing focus f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. platform-ios iOS applications specifically team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Sep 1, 2022
goderbauer
goderbauer approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guidezpl guidezpl marked this pull request as ready for review September 1, 2022 20:30
@guidezpl guidezpl added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 2, 2022
@auto-submit auto-submit bot merged commit 0c2f7bc into flutter:master Sep 2, 2022
@guidezpl guidezpl deleted the spaaaaaace branch September 2, 2022 08:51
This was referenced Sep 2, 2022
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2022
@engine-flutter-autoroll
0c2f7bc2a Remove errant double spaces (flutter/flutter#110758)
454f6f6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 2, 2022
@engine-flutter-autoroll
0c2f7bc Remove errant double spaces (flutter/flutter#110758)
8da292c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2022
@engine-flutter-autoroll
0c2f7bc2a Remove errant double spaces (flutter/flutter#110758)
421eabd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2022
@engine-flutter-autoroll
0c2f7bc2a Remove errant double spaces (flutter/flutter#110758)
15bf670
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2022
@engine-flutter-autoroll
0c2f7bc2a Remove errant double spaces (flutter/flutter#110758)
641f457
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2022
@engine-flutter-autoroll
0c2f7bc2a Remove errant double spaces (flutter/flutter#110758)
687faaa
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2022
@engine-flutter-autoroll
0c2f7bc2a Remove errant double spaces (flutter/flutter#110758)
7277b42
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2022
@engine-flutter-autoroll
0c2f7bc2a Remove errant double spaces (flutter/flutter#110758)
aa45f6b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2022
@engine-flutter-autoroll
0c2f7bc2a Remove errant double spaces (flutter/flutter#110758)
f0b620a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2022
@engine-flutter-autoroll
0c2f7bc2a Remove errant double spaces (flutter/flutter#110758)
d4c1b1f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2022
@engine-flutter-autoroll
0c2f7bc2a Remove errant double spaces (flutter/flutter#110758)
69cd5f8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2022
@engine-flutter-autoroll
0c2f7bc2a Remove errant double spaces (flutter/flutter#110758)
e337c43
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2022
@engine-flutter-autoroll
0c2f7bc2a Remove errant double spaces (flutter/flutter#110758)
d67a34b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2022
@engine-flutter-autoroll
0c2f7bc2a Remove errant double spaces (flutter/flutter#110758)
ad568f2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2022
@engine-flutter-autoroll
0c2f7bc2a Remove errant double spaces (flutter/flutter#110758)
c6afe12
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2022
@engine-flutter-autoroll
0c2f7bc2a Remove errant double spaces (flutter/flutter#110758)
ee6279f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2022
@engine-flutter-autoroll
0c2f7bc2a Remove errant double spaces (flutter/flutter#110758)
1099432
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022
@engine-flutter-autoroll
0c2f7bc2a Remove errant double spaces (flutter/flutter#110758)
e22a2df
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022
@engine-flutter-autoroll
0c2f7bc2a Remove errant double spaces (flutter/flutter#110758)
e521c2a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022
@engine-flutter-autoroll
0c2f7bc2a Remove errant double spaces (flutter/flutter#110758)
1b64693
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022
@engine-flutter-autoroll
0c2f7bc2a Remove errant double spaces (flutter/flutter#110758)
3c1e735
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2022
@engine-flutter-autoroll
0c2f7bc2a Remove errant double spaces (flutter/flutter#110758)
c775e20
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2022
@engine-flutter-autoroll
0c2f7bc2a Remove errant double spaces (flutter/flutter#110758)
b31c831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
a: animation Animation APIs a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: focus Focus traversal, gaining or losing focus f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. platform-ios iOS applications specifically team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up double spaces
2 participants
@guidezpl @goderbauer