New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inherit: false
to material2018 text geometry text themes
#110870
Add inherit: false
to material2018 text geometry text themes
#110870
Conversation
b49d599
to
b435475
Compare
b435475
to
50f2474
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't recall why the 2018 text styles didn't specify inherit: false
in the first place. Perhaps we'll never know. Or maybe it was just an oversight.
Nice this is awesome and a surprisingly simple fix. I had no idea it was allowed to change the framework to set it to false. 😃 Thanks @LongCatIsLooong, many others have reported this issue too and it has been open a long time. We should close the duplicates/related issues too, if not done already (automatically?). I think most of them are referenced in comments to my issue report. I made a slightly tedious workaround in Themes Playground to get around this issue. I needed a workaround since the app needs to be able to dynamically switch between 2018 and 2021 Typography, or at least make it looks like it does so. So I made it stay in 2021 all the time, and simulate switching, by instead changing to an internal TextTheme in 2021 Typography, that looks like it is using 2018 Typography. The app's code gen output still gives a setup for the actual 2018 Typography, when that is selected. While it worked, and users don't see and know it is going on, I will be happy to remove its extra code once this lands in stable. Love your honest comment @HansMuller, I would not expect either that it would be possible to know and remember historic rationale for everything in the framework, it is pretty darn big. Sure oversights might happen too... naah not really in Flutter framework, the people working on it are just too awesome 😃💙 |
Fixes #103864
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.