Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for flakey analyze test #111895

Merged
merged 7 commits into from Sep 19, 2022
Merged

fix for flakey analyze test #111895

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
af0ed38
regex pattern approach for flakey analyze test
eliasyishak Sep 19, 2022
b52ad5d
adding logging for errors
eliasyishak Sep 19, 2022
6937fab
regex pattern handles windows output
eliasyishak Sep 19, 2022
3f39614
removing difficult regex pattern
eliasyishak Sep 19, 2022
1310f76
trimming whitespace + including comment for conditional
eliasyishak Sep 19, 2022
77f6d71
removing hard coded flutter_project name
eliasyishak Sep 19, 2022
3855f5b
clean up trailing whitespace
eliasyishak Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
29 changes: 16 additions & 13 deletions packages/flutter_tools/test/commands.shard/permeable/create_test.dart
View file
Open in desktop
Expand Up @@ -3131,22 +3131,25 @@ Future<void> _analyzeProject(String workingDir, { List<String> expectedFailures
}
}
final String stdout = exec.stdout.toString();
final List<String> errors;
final List<String> errors = <String>[];
try {
errors = const LineSplitter().convert(stdout)
.where((String line) {
return line.trim().isNotEmpty &&
!line.startsWith('Analyzing') &&
!line.contains('flutter pub get') &&
!line.contains('Resolving dependencies') &&
!line.contains('Got dependencies');
}).map(lineParser).toList();

// Add debugging for https://github.com/flutter/flutter/issues/111272
} on RangeError catch (err) {
bool analyzeLineFound = false;
const LineSplitter().convert(stdout).forEach((String line) {
if (!analyzeLineFound && line.startsWith('Analyzing flutter_project')) {
eliasyishak marked this conversation as resolved.
Show resolved Hide resolved
analyzeLineFound = true;
return;
}

if (analyzeLineFound && line.isNotEmpty) {
errors.add(lineParser(line));
}
});

} on Exception catch (err) {
fail('$err\n\nComplete STDOUT was:\n\n$stdout');
}
expect(errors, unorderedEquals(expectedFailures));
expect(errors, unorderedEquals(expectedFailures),
reason: 'Failed with stdout:\n\n$stdout');
}

Future<void> _getPackages(Directory workingDir) async {
Expand Down