Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reland "Fix DraggableScrollableSheet rebuilding during drag" #112479

Merged
merged 1 commit into from Sep 28, 2022

Conversation

moffatman
Copy link
Contributor

Relands #111010 which was reverted in #112293


DraggableScrollableSheet was rebuilding every time the size of the child changed, which meant every frame during a drag. Now it will only rebuild when it gets changed parameters from the parent widget.

Also inadvertent fix to an exception thrown while rebuilding DraggableScrollableSheet with a new controller.

Fixes #67219

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Sep 27, 2022
@Piinks Piinks self-requested a review September 27, 2022 19:29
@Piinks
Copy link
Contributor

Piinks commented Sep 27, 2022

Thanks for re-staging this @moffatman. I am just finishing fixing the customer code, we need that to land internally first before this can be merged.

Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The customer is fixed, this can land now. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DraggableScrollableSheet is rebuilding the screen while dragging
2 participants