Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CP of "Temporarily remove a bogus warning until fixed by dwds update (#109793)" #112887

Merged
merged 2 commits into from Oct 5, 2022
Merged

CP of "Temporarily remove a bogus warning until fixed by dwds update (#109793)" #112887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
983649d
Temporarily remove a bogus warning until fixed by dwds update (#109793)
Aug 19, 2022
8e796b5
Merge branch 'flutter-3.2-candidate.5' into cherrypicks-flutter-3.2-c…
christopherfujino Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/flutter_tools/lib/src/isolated/devfs_web.dart
View file
Open in desktop
Expand Up @@ -1015,7 +1015,12 @@ void log(logging.LogRecord event) {
if (event.level >= logging.Level.SEVERE) {
globals.printError('${event.loggerName}: ${event.message}$error', stackTrace: event.stackTrace);
} else if (event.level == logging.Level.WARNING) {
globals.printWarning('${event.loggerName}: ${event.message}$error');
// Note: Temporary fix for https://github.com/flutter/flutter/issues/109792
// TODO(annagrin): Remove the condition after the bogus warning is
// removed in dwds: https://github.com/dart-lang/webdev/issues/1722
if (!event.message.contains('No module for')) {
globals.printWarning('${event.loggerName}: ${event.message}$error');
}
} else {
globals.printTrace('${event.loggerName}: ${event.message}$error');
}
Expand Down
1 change: 1 addition & 0 deletions packages/flutter_tools/test/web.shard/expression_evaluation_web_test.dart
View file
Open in desktop
Expand Up @@ -23,6 +23,7 @@ void main() {
flutter = FlutterRunTestDriver(tempDir);
flutter.stdout.listen((String line) {
expect(line, isNot(contains('Unresolved uri:')));
expect(line, isNot(contains('No module for')));
});
});

Expand Down