Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @param onDone #113371

Merged
merged 2 commits into from Mar 1, 2023
Merged

Remove @param onDone #113371

merged 2 commits into from Mar 1, 2023

Conversation

gonft
Copy link
Contributor

@gonft gonft commented Oct 13, 2022

revertFlutterImage method does not have an onDone parameter
스크린샷 2022-10-13 오후 7 57 06

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the f: integration_test The flutter/packages/integration_test plugin label Oct 13, 2022
@google-cla
Copy link

google-cla bot commented Oct 13, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Hixie Hixie added engine flutter/engine repository. See also e: labels. and removed engine flutter/engine repository. See also e: labels. labels Feb 7, 2023
Hixie
Hixie approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie
Copy link
Contributor

Hixie commented Feb 7, 2023

Is that in the template?

@jmagman jmagman added the framework flutter/packages/flutter repository. See also f: labels. label Feb 22, 2023
goderbauer
goderbauer approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 28, 2023
@auto-submit auto-submit bot merged commit 1692803 into flutter:master Mar 1, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
16928037a Remove @param onDone (flutter/flutter#113371)
bfa0d1c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
16928037a Remove @param onDone (flutter/flutter#113371)
80cda02
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
16928037a Remove @param onDone (flutter/flutter#113371)
8569a5c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
16928037a Remove @param onDone (flutter/flutter#113371)
008f7be
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
16928037a Remove @param onDone (flutter/flutter#113371)
9e68680
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
16928037a Remove @param onDone (flutter/flutter#113371)
538da75
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
16928037a Remove @param onDone (flutter/flutter#113371)
9e68a0d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
16928037a Remove @param onDone (flutter/flutter#113371)
0fa4c63
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
16928037a Remove @param onDone (flutter/flutter#113371)
7ebf55d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
16928037a Remove @param onDone (flutter/flutter#113371)
27d3635
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
16928037a Remove @param onDone (flutter/flutter#113371)
b646bef
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
16928037a Remove @param onDone (flutter/flutter#113371)
c1f1fee
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
16928037a Remove @param onDone (flutter/flutter#113371)
97e0d82
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
16928037a Remove @param onDone (flutter/flutter#113371)
65baa92
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2023
@engine-flutter-autoroll
16928037a Remove @param onDone (flutter/flutter#113371)
19ef5cd
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2023
@engine-flutter-autoroll
16928037a Remove @param onDone (flutter/flutter#113371)
1b554a7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
16928037a Remove @param onDone (flutter/flutter#113371)
1009e75
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
16928037a Remove @param onDone (flutter/flutter#113371)
f21ebb8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hixie Hixie Hixie approved these changes

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gonft @Hixie @goderbauer @jmagman