New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include initial offset when using PlatformViewSurface #114103
Merged
auto-submit
merged 17 commits into
flutter:master
from
bparrishMines:current_engine_main
Nov 15, 2022
Merged
Include initial offset when using PlatformViewSurface #114103
auto-submit
merged 17 commits into
flutter:master
from
bparrishMines:current_engine_main
Nov 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
framework
flutter/packages/flutter repository. See also f: labels.
label
Oct 26, 2022
bparrishMines
changed the title
Current engine main
Includ initial offset when using PlatformViewSurface
Oct 26, 2022
bparrishMines
changed the title
Includ initial offset when using PlatformViewSurface
Include initial offset when using PlatformViewSurface
Oct 26, 2022
stuartmorgan
approved these changes
Nov 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (with one comment nit), thanks for digging into this!
bparrishMines
added
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
Nov 15, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 16, 2022
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 16, 2022
* 338841afd Revert "Revert "Revert "Scribble mixin (#104128)" (#114647)" (#114698)" (flutter/flutter#115146) * 229b39eda [flutter_tools] Fix so that the value set by `--dart-define-from-file` can be passed to Gradle (flutter/flutter#114297) * 3895786f9 Revert "Load assets in flutter_test without turning event loop. (#115123)" (flutter/flutter#115156) * a6e3ec8fa mark firebase test lab test flaky because of upstream infra issues (flutter/flutter#115178) * 8d808b5f9 Roll Flutter Engine from 7326e5b3354b to 329900fc85d6 (7 revisions) (flutter/flutter#115185) * 10dc56643 Add drone_dimensions to devicelab_build_test. (flutter/flutter#115183) * 0a5b531cc b6e45ae35 extend const_finder to allow skipping particular classes (flutter/engine#37257) (flutter/flutter#115189) * 0e9ee3679 [web] Add `--local-web-sdk` flag and use precompiled platform kernels for dart2js and ddc (flutter/flutter#114639) * 9e314ff74 Make FutureBuilder handle SynchronousFuture correctly, reland SynchronousFuture usage in test assets (flutter/flutter#115173) * 673fd973b 17d428e68 Roll Dart SDK from 2b6909ba35e5 to 190040da0bc8 (2 revisions) (flutter/engine#37536) (flutter/flutter#115191) * edcdb0046 Roll Flutter Engine from 17d428e688a9 to 38c4f1d78630 (2 revisions) (flutter/flutter#115192) * 877276812 Roll Flutter Engine from 38c4f1d78630 to 1f0dd2c0f5bb (2 revisions) (flutter/flutter#115194) * 6ec2bd0a8 M3 Segmented Button widget (flutter/flutter#113723) * b7b6758d5 f3dfdf4cc Roll Skia from 3bbdd5bc54f2 to a727f7ac8a98 (1 revision) (flutter/engine#37544) (flutter/flutter#115196) * 94e753d0f Roll Flutter Engine from f3dfdf4ccf38 to e3b3950f0fab (3 revisions) (flutter/flutter#115200) * 61e927d22 e63c9443b [Impeller] Include the new primitive type in the pipeline hash (flutter/engine#37546) (flutter/flutter#115201) * c05d887f5 Roll Flutter Engine from e63c9443bc04 to 9500d8c4a4ce (2 revisions) (flutter/flutter#115212) * 1f8298528 1c8c23754 Roll Fuchsia Linux SDK from xDY5B0-NZzq2idRNU... to IE4logHFoa8ZZQAw3... (flutter/engine#37554) (flutter/flutter#115214) * 61b3d5a88 a0d8cd68c Add a limit to the Gaussian blur downsampling curve (flutter/engine#37550) (flutter/flutter#115217) * 2bf64aaca fd56b7ee8 Roll Fuchsia Mac SDK from j3vspnGJcQvIfsXXu... to iPqmEVwAbmYwPlh5a... (flutter/engine#37557) (flutter/flutter#115218) * 53ab17d22 Roll Flutter Engine from fd56b7ee87f0 to 1ae285897eae (2 revisions) (flutter/flutter#115220) * 4488166f4 d4e2188e9 [Impeller] Fix DrawPaint regression (flutter/engine#37561) (flutter/flutter#115222) * bf906e6ce 2bdeaf7d7 Fix inertia cancel event on macOS Ventura (flutter/engine#37067) (flutter/flutter#115226) * 1a194094e 06c390470 Roll Fuchsia Mac SDK from iPqmEVwAbmYwPlh5a... to N-iOLgSVYYh_AfC7Q... (flutter/engine#37566) (flutter/flutter#115236) * 1a460cfb9 54795869b Roll Skia from c0f87aed019b to 38edf6197aa9 (1 revision) (flutter/engine#37567) (flutter/flutter#115239) * 8230ef5e8 Revert "[web] Add `--local-web-sdk` flag and use precompiled platform kernels for dart2js and ddc (#114639)" (flutter/flutter#115242) * 899492023 7269f2f91 Roll Skia from 38edf6197aa9 to 0f515e97d535 (1 revision) (flutter/engine#37571) (flutter/flutter#115244) * 7ac00f755 40b071c75 Roll Fuchsia Linux SDK from IE4logHFoa8ZZQAw3... to AE_mBWzdDqUvn4r1N... (flutter/engine#37572) (flutter/flutter#115247) * fa94a3c10 b63e6cf55 [Impeller] dont include sampler offset in float offset (flutter/engine#37573) (flutter/flutter#115248) * cb224d10e b7567b92c Roll Fuchsia Mac SDK from N-iOLgSVYYh_AfC7Q... to WYzUv6RnWjJpAiqYp... (flutter/engine#37575) (flutter/flutter#115252) * d587fe487 a1b5507e5 Add playground to demonstrate mask blur problems (flutter/engine#37574) (flutter/flutter#115260) * f5205b15c 6f7447efa Roll Fuchsia Linux SDK from AE_mBWzdDqUvn4r1N... to dRHIZSishiboEHMdw... (flutter/engine#37577) (flutter/flutter#115266) * 2c4051f0f b077c1c46 Roll Dart SDK from 996fe4d7ea9a to 45b7433f9015 (1 revision) (flutter/engine#37578) (flutter/flutter#115271) * 0b5f3fdd7 743cec5ba Roll Skia from 0f515e97d535 to b2109e6bbbe7 (1 revision) (flutter/engine#37580) (flutter/flutter#115279) * 80bcc3a34 035313ae2 Roll Dart SDK from 45b7433f9015 to 7cbcf48157cf (1 revision) (flutter/engine#37582) (flutter/flutter#115281) * fdd2fe410 036f8ea88 Roll Fuchsia Mac SDK from WYzUv6RnWjJpAiqYp... to XvXKIR_SSUfSyGwxe... (flutter/engine#37583) (flutter/flutter#115293) * 436fb4c6b c290de693 Roll Skia from b2109e6bbbe7 to 2ad14e25f6f7 (7 revisions) (flutter/engine#37585) (flutter/flutter#115294) * 244990775 Fixed the color curve issue (flutter/flutter#115188) * 9359c2578 1a79e8686 [macOS] Move to new update semantics embedder API (flutter/engine#37404) (flutter/flutter#115301) * 59e1edc66 Roll Flutter Engine from 1a79e8686036 to 8c73ffff5b6f (2 revisions) (flutter/flutter#115302) * f2ec1c459 42bc762b6 Roll Skia from 2ad14e25f6f7 to a434f9b69660 (11 revisions) (flutter/engine#37591) (flutter/flutter#115304) * ea4e11dd9 Fix test in preparation of the Dart VM dropping support for language versions < 2.12.0 (flutter/flutter#115176) * a0a7b3a70 14ecaeb91 [Impeller] error earlier on uint types (flutter/engine#37593) (flutter/flutter#115308) * 2e51077d1 Do not strip architecture suffixes from host local-engine (flutter/flutter#115320) * 8e3ea1478 Incorrect rendering of `SnapshotWidget` (flutter/flutter#114400) * 59ecc7574 [flutter_tools] add uint compilation test (flutter/flutter#115317) * 1aeb1721c Roll Flutter Engine from 14ecaeb915e0 to 78ae2414003a (10 revisions) (flutter/flutter#115335) * e39181299 9dedab305 Roll Skia from b474a43dcc34 to 2cebc1ce363c (2 revisions) (flutter/engine#37612) (flutter/flutter#115338) * 9d64a0f40 31ee28684 Combine results of all the test batches. (flutter/engine#37610) (flutter/flutter#115340) * e9c6212da [Impeller] Add shader include with FlutterFragCoord for use by FragmentProgram (flutter/flutter#114214) * a27bb3cd2 06bd5a816 Roll Skia from 2cebc1ce363c to d758b240cad0 (1 revision) (flutter/engine#37614) (flutter/flutter#115341) * abbffcc14 c6a513ecd Roll Fuchsia Mac SDK from XvXKIR_SSUfSyGwxe... to 32kfSm94FGtJJeUjg... (flutter/engine#37615) (flutter/flutter#115344) * 0f56ed133 f01de9f6b Roll Skia from d758b240cad0 to 24523449b1b3 (1 revision) (flutter/engine#37616) (flutter/flutter#115346) * 25d74e610 0b338ed86 Roll Dart SDK from 6f5478a58387 to 987faaf6d1d4 (2 revisions) (flutter/engine#37617) (flutter/flutter#115352) * 1f28f99a0 721fbe111 Roll Skia from 24523449b1b3 to 4d519a8ba97a (3 revisions) (flutter/engine#37618) (flutter/flutter#115354) * c37f255e8 [tools] Fix plugin_ffi template lint violation (flutter/flutter#115356) * 3c3f1363b b4fd07fa4 Roll Dart SDK from 987faaf6d1d4 to 42f87c0521f8 (1 revision) (flutter/engine#37619) (flutter/flutter#115362) * 2ed52830f 58495f077 [Impeller] Add debug names to additional VK objects (flutter/engine#37592) (flutter/flutter#115363) * afafde610 7f74f34a4 Roll Fuchsia Linux SDK from B0OuUvWOY24LI1WoF... to agStiOtzmc9Fmw6gc... (flutter/engine#37621) (flutter/flutter#115365) * af2ec91be Roll Plugins from 3ca3410 to e500884 (10 revisions) (flutter/flutter#115366) * 3a298d0b9 Roll Flutter Engine from 7f74f34a408a to eead7b0d8656 (2 revisions) (flutter/flutter#115369) * acf01eb3e 905862722 [dart] Run generate_sdk_version_file.py to be compatible with dart ch… (flutter/engine#37624) (flutter/flutter#115372) * 95ace11af Include initial offset when using PlatformViewSurface (flutter/flutter#114103) * 39a9ed572 Updated tokens to v0.141 (flutter/flutter#115298) * ba47c2964 216702f3d Roll Skia from 1991515dd191 to 826b3ea577f3 (4 revisions) (flutter/engine#37628) (flutter/flutter#115377) * 2d77ac584 49f8326df Roll Skia from 826b3ea577f3 to 02e2101a75f7 (4 revisions) (flutter/engine#37631) (flutter/flutter#115385) * 136b46ba9 Hint text semantics to be excluded in a11y read out if textfield in not empty and label text is provided (flutter/flutter#115010) * 700de09fd Change button and label text to sentence case for Material 3 (flutter/flutter#115187) * b2b839166 Roll Flutter Engine from 49f8326df6f0 to 84cb1f833ac4 (3 revisions) (flutter/flutter#115387) * 2c44f4a68 Remove dev branch reference from build ios-frameworks error (flutter/flutter#115166) * 792eefe60 Roll Flutter Engine from 84cb1f833ac4 to af6e47f1d5c4 (4 revisions) (flutter/flutter#115395) * 341a9b113 6d41b2ffb update Scene.toImageSync test to use proper bounds in the request (flutter/engine#37638) (flutter/flutter#115398) * e66183da3 Bump github/codeql-action from 2.1.25 to 2.1.32 (flutter/flutter#115394) * d0e5b2fba Add a way to customize padding in BottomAppBar (flutter/flutter#115175) * 349d6486e baad8f2c5 Roll Skia from 02e2101a75f7 to cfb6de45f39b (7 revisions) (flutter/engine#37640) (flutter/flutter#115399) * 7d2b01132 Fix logic error in `markNeedsPaint` (flutter/flutter#112735) * 93c4b09e6 Add `RestorableEnumN<T>` and `RestorableEnum<T>` to restorable primitive types (flutter/flutter#115050) * 2c1536a2d Create a main alias for master channel. (flutter/flutter#115388) * bbb349b3e Roll Flutter Engine from baad8f2c553b to e56ed93faab5 (6 revisions) (flutter/flutter#115406) * bacd77086 c062f7ea7 Roll Skia from cfb6de45f39b to cdf8348e6fba (4 revisions) (flutter/engine#37649) (flutter/flutter#115407) * 27ff6a510 Roll Flutter Engine from c062f7ea7195 to 03e9a97f8abe (3 revisions) (flutter/flutter#115410) * 58728c6a9 Roll Flutter Engine from 03e9a97f8abe to 21a572e4e4d0 (2 revisions) (flutter/flutter#115411) * e54c8a8e2 3e15c1925 Roll Dart SDK from 7163c9627d98 to c3f1b3642181 (2 revisions) (flutter/engine#37664) (flutter/flutter#115417) * 484e09ef7 Roll Flutter Engine from 3e15c192560f to 0241f18cbedf (2 revisions) (flutter/flutter#115423) * 4fdaf7ae2 Revert "Roll Flutter Engine from 3e15c192560f to 0241f18cbedf (2 revisions) (#115423)" (flutter/flutter#115456) * 4301731eb Make Flutter Driver actively wait for runnable isolate (flutter/flutter#113969) * c940f3182 Marks Mac_ios flavors_test_ios to be unflaky (flutter/flutter#115458) * 243a83012 Roll Flutter Engine from 3e15c192560f to 223e1f092dd5 (4 revisions) (flutter/flutter#115463) * d7454d552 removing default values for [reporter] and [timeout] in flutter test (flutter/flutter#115160) * a2233eabe [flutter_tools] remove all body_might_complete_normally_catch_error ignores (flutter/flutter#115184) * b5345ff55 d72164776 Revert "[Impeller] Refactor color source resolution to use explicit factory types (#37656)" (flutter/engine#37673) (flutter/flutter#115467) * dcae42478 [tools]build ipa validate template icon files (flutter/flutter#114841)
percula
pushed a commit
to percula/packages
that referenced
this pull request
Nov 17, 2022
…r#2818) * 338841afd Revert "Revert "Revert "Scribble mixin (#104128)" (#114647)" (#114698)" (flutter/flutter#115146) * 229b39eda [flutter_tools] Fix so that the value set by `--dart-define-from-file` can be passed to Gradle (flutter/flutter#114297) * 3895786f9 Revert "Load assets in flutter_test without turning event loop. (#115123)" (flutter/flutter#115156) * a6e3ec8fa mark firebase test lab test flaky because of upstream infra issues (flutter/flutter#115178) * 8d808b5f9 Roll Flutter Engine from 7326e5b3354b to 329900fc85d6 (7 revisions) (flutter/flutter#115185) * 10dc56643 Add drone_dimensions to devicelab_build_test. (flutter/flutter#115183) * 0a5b531cc b6e45ae35 extend const_finder to allow skipping particular classes (flutter/engine#37257) (flutter/flutter#115189) * 0e9ee3679 [web] Add `--local-web-sdk` flag and use precompiled platform kernels for dart2js and ddc (flutter/flutter#114639) * 9e314ff74 Make FutureBuilder handle SynchronousFuture correctly, reland SynchronousFuture usage in test assets (flutter/flutter#115173) * 673fd973b 17d428e68 Roll Dart SDK from 2b6909ba35e5 to 190040da0bc8 (2 revisions) (flutter/engine#37536) (flutter/flutter#115191) * edcdb0046 Roll Flutter Engine from 17d428e688a9 to 38c4f1d78630 (2 revisions) (flutter/flutter#115192) * 877276812 Roll Flutter Engine from 38c4f1d78630 to 1f0dd2c0f5bb (2 revisions) (flutter/flutter#115194) * 6ec2bd0a8 M3 Segmented Button widget (flutter/flutter#113723) * b7b6758d5 f3dfdf4cc Roll Skia from 3bbdd5bc54f2 to a727f7ac8a98 (1 revision) (flutter/engine#37544) (flutter/flutter#115196) * 94e753d0f Roll Flutter Engine from f3dfdf4ccf38 to e3b3950f0fab (3 revisions) (flutter/flutter#115200) * 61e927d22 e63c9443b [Impeller] Include the new primitive type in the pipeline hash (flutter/engine#37546) (flutter/flutter#115201) * c05d887f5 Roll Flutter Engine from e63c9443bc04 to 9500d8c4a4ce (2 revisions) (flutter/flutter#115212) * 1f8298528 1c8c23754 Roll Fuchsia Linux SDK from xDY5B0-NZzq2idRNU... to IE4logHFoa8ZZQAw3... (flutter/engine#37554) (flutter/flutter#115214) * 61b3d5a88 a0d8cd68c Add a limit to the Gaussian blur downsampling curve (flutter/engine#37550) (flutter/flutter#115217) * 2bf64aaca fd56b7ee8 Roll Fuchsia Mac SDK from j3vspnGJcQvIfsXXu... to iPqmEVwAbmYwPlh5a... (flutter/engine#37557) (flutter/flutter#115218) * 53ab17d22 Roll Flutter Engine from fd56b7ee87f0 to 1ae285897eae (2 revisions) (flutter/flutter#115220) * 4488166f4 d4e2188e9 [Impeller] Fix DrawPaint regression (flutter/engine#37561) (flutter/flutter#115222) * bf906e6ce 2bdeaf7d7 Fix inertia cancel event on macOS Ventura (flutter/engine#37067) (flutter/flutter#115226) * 1a194094e 06c390470 Roll Fuchsia Mac SDK from iPqmEVwAbmYwPlh5a... to N-iOLgSVYYh_AfC7Q... (flutter/engine#37566) (flutter/flutter#115236) * 1a460cfb9 54795869b Roll Skia from c0f87aed019b to 38edf6197aa9 (1 revision) (flutter/engine#37567) (flutter/flutter#115239) * 8230ef5e8 Revert "[web] Add `--local-web-sdk` flag and use precompiled platform kernels for dart2js and ddc (#114639)" (flutter/flutter#115242) * 899492023 7269f2f91 Roll Skia from 38edf6197aa9 to 0f515e97d535 (1 revision) (flutter/engine#37571) (flutter/flutter#115244) * 7ac00f755 40b071c75 Roll Fuchsia Linux SDK from IE4logHFoa8ZZQAw3... to AE_mBWzdDqUvn4r1N... (flutter/engine#37572) (flutter/flutter#115247) * fa94a3c10 b63e6cf55 [Impeller] dont include sampler offset in float offset (flutter/engine#37573) (flutter/flutter#115248) * cb224d10e b7567b92c Roll Fuchsia Mac SDK from N-iOLgSVYYh_AfC7Q... to WYzUv6RnWjJpAiqYp... (flutter/engine#37575) (flutter/flutter#115252) * d587fe487 a1b5507e5 Add playground to demonstrate mask blur problems (flutter/engine#37574) (flutter/flutter#115260) * f5205b15c 6f7447efa Roll Fuchsia Linux SDK from AE_mBWzdDqUvn4r1N... to dRHIZSishiboEHMdw... (flutter/engine#37577) (flutter/flutter#115266) * 2c4051f0f b077c1c46 Roll Dart SDK from 996fe4d7ea9a to 45b7433f9015 (1 revision) (flutter/engine#37578) (flutter/flutter#115271) * 0b5f3fdd7 743cec5ba Roll Skia from 0f515e97d535 to b2109e6bbbe7 (1 revision) (flutter/engine#37580) (flutter/flutter#115279) * 80bcc3a34 035313ae2 Roll Dart SDK from 45b7433f9015 to 7cbcf48157cf (1 revision) (flutter/engine#37582) (flutter/flutter#115281) * fdd2fe410 036f8ea88 Roll Fuchsia Mac SDK from WYzUv6RnWjJpAiqYp... to XvXKIR_SSUfSyGwxe... (flutter/engine#37583) (flutter/flutter#115293) * 436fb4c6b c290de693 Roll Skia from b2109e6bbbe7 to 2ad14e25f6f7 (7 revisions) (flutter/engine#37585) (flutter/flutter#115294) * 244990775 Fixed the color curve issue (flutter/flutter#115188) * 9359c2578 1a79e8686 [macOS] Move to new update semantics embedder API (flutter/engine#37404) (flutter/flutter#115301) * 59e1edc66 Roll Flutter Engine from 1a79e8686036 to 8c73ffff5b6f (2 revisions) (flutter/flutter#115302) * f2ec1c459 42bc762b6 Roll Skia from 2ad14e25f6f7 to a434f9b69660 (11 revisions) (flutter/engine#37591) (flutter/flutter#115304) * ea4e11dd9 Fix test in preparation of the Dart VM dropping support for language versions < 2.12.0 (flutter/flutter#115176) * a0a7b3a70 14ecaeb91 [Impeller] error earlier on uint types (flutter/engine#37593) (flutter/flutter#115308) * 2e51077d1 Do not strip architecture suffixes from host local-engine (flutter/flutter#115320) * 8e3ea1478 Incorrect rendering of `SnapshotWidget` (flutter/flutter#114400) * 59ecc7574 [flutter_tools] add uint compilation test (flutter/flutter#115317) * 1aeb1721c Roll Flutter Engine from 14ecaeb915e0 to 78ae2414003a (10 revisions) (flutter/flutter#115335) * e39181299 9dedab305 Roll Skia from b474a43dcc34 to 2cebc1ce363c (2 revisions) (flutter/engine#37612) (flutter/flutter#115338) * 9d64a0f40 31ee28684 Combine results of all the test batches. (flutter/engine#37610) (flutter/flutter#115340) * e9c6212da [Impeller] Add shader include with FlutterFragCoord for use by FragmentProgram (flutter/flutter#114214) * a27bb3cd2 06bd5a816 Roll Skia from 2cebc1ce363c to d758b240cad0 (1 revision) (flutter/engine#37614) (flutter/flutter#115341) * abbffcc14 c6a513ecd Roll Fuchsia Mac SDK from XvXKIR_SSUfSyGwxe... to 32kfSm94FGtJJeUjg... (flutter/engine#37615) (flutter/flutter#115344) * 0f56ed133 f01de9f6b Roll Skia from d758b240cad0 to 24523449b1b3 (1 revision) (flutter/engine#37616) (flutter/flutter#115346) * 25d74e610 0b338ed86 Roll Dart SDK from 6f5478a58387 to 987faaf6d1d4 (2 revisions) (flutter/engine#37617) (flutter/flutter#115352) * 1f28f99a0 721fbe111 Roll Skia from 24523449b1b3 to 4d519a8ba97a (3 revisions) (flutter/engine#37618) (flutter/flutter#115354) * c37f255e8 [tools] Fix plugin_ffi template lint violation (flutter/flutter#115356) * 3c3f1363b b4fd07fa4 Roll Dart SDK from 987faaf6d1d4 to 42f87c0521f8 (1 revision) (flutter/engine#37619) (flutter/flutter#115362) * 2ed52830f 58495f077 [Impeller] Add debug names to additional VK objects (flutter/engine#37592) (flutter/flutter#115363) * afafde610 7f74f34a4 Roll Fuchsia Linux SDK from B0OuUvWOY24LI1WoF... to agStiOtzmc9Fmw6gc... (flutter/engine#37621) (flutter/flutter#115365) * af2ec91be Roll Plugins from 3ca3410 to e500884 (10 revisions) (flutter/flutter#115366) * 3a298d0b9 Roll Flutter Engine from 7f74f34a408a to eead7b0d8656 (2 revisions) (flutter/flutter#115369) * acf01eb3e 905862722 [dart] Run generate_sdk_version_file.py to be compatible with dart ch… (flutter/engine#37624) (flutter/flutter#115372) * 95ace11af Include initial offset when using PlatformViewSurface (flutter/flutter#114103) * 39a9ed572 Updated tokens to v0.141 (flutter/flutter#115298) * ba47c2964 216702f3d Roll Skia from 1991515dd191 to 826b3ea577f3 (4 revisions) (flutter/engine#37628) (flutter/flutter#115377) * 2d77ac584 49f8326df Roll Skia from 826b3ea577f3 to 02e2101a75f7 (4 revisions) (flutter/engine#37631) (flutter/flutter#115385) * 136b46ba9 Hint text semantics to be excluded in a11y read out if textfield in not empty and label text is provided (flutter/flutter#115010) * 700de09fd Change button and label text to sentence case for Material 3 (flutter/flutter#115187) * b2b839166 Roll Flutter Engine from 49f8326df6f0 to 84cb1f833ac4 (3 revisions) (flutter/flutter#115387) * 2c44f4a68 Remove dev branch reference from build ios-frameworks error (flutter/flutter#115166) * 792eefe60 Roll Flutter Engine from 84cb1f833ac4 to af6e47f1d5c4 (4 revisions) (flutter/flutter#115395) * 341a9b113 6d41b2ffb update Scene.toImageSync test to use proper bounds in the request (flutter/engine#37638) (flutter/flutter#115398) * e66183da3 Bump github/codeql-action from 2.1.25 to 2.1.32 (flutter/flutter#115394) * d0e5b2fba Add a way to customize padding in BottomAppBar (flutter/flutter#115175) * 349d6486e baad8f2c5 Roll Skia from 02e2101a75f7 to cfb6de45f39b (7 revisions) (flutter/engine#37640) (flutter/flutter#115399) * 7d2b01132 Fix logic error in `markNeedsPaint` (flutter/flutter#112735) * 93c4b09e6 Add `RestorableEnumN<T>` and `RestorableEnum<T>` to restorable primitive types (flutter/flutter#115050) * 2c1536a2d Create a main alias for master channel. (flutter/flutter#115388) * bbb349b3e Roll Flutter Engine from baad8f2c553b to e56ed93faab5 (6 revisions) (flutter/flutter#115406) * bacd77086 c062f7ea7 Roll Skia from cfb6de45f39b to cdf8348e6fba (4 revisions) (flutter/engine#37649) (flutter/flutter#115407) * 27ff6a510 Roll Flutter Engine from c062f7ea7195 to 03e9a97f8abe (3 revisions) (flutter/flutter#115410) * 58728c6a9 Roll Flutter Engine from 03e9a97f8abe to 21a572e4e4d0 (2 revisions) (flutter/flutter#115411) * e54c8a8e2 3e15c1925 Roll Dart SDK from 7163c9627d98 to c3f1b3642181 (2 revisions) (flutter/engine#37664) (flutter/flutter#115417) * 484e09ef7 Roll Flutter Engine from 3e15c192560f to 0241f18cbedf (2 revisions) (flutter/flutter#115423) * 4fdaf7ae2 Revert "Roll Flutter Engine from 3e15c192560f to 0241f18cbedf (2 revisions) (#115423)" (flutter/flutter#115456) * 4301731eb Make Flutter Driver actively wait for runnable isolate (flutter/flutter#113969) * c940f3182 Marks Mac_ios flavors_test_ios to be unflaky (flutter/flutter#115458) * 243a83012 Roll Flutter Engine from 3e15c192560f to 223e1f092dd5 (4 revisions) (flutter/flutter#115463) * d7454d552 removing default values for [reporter] and [timeout] in flutter test (flutter/flutter#115160) * a2233eabe [flutter_tools] remove all body_might_complete_normally_catch_error ignores (flutter/flutter#115184) * b5345ff55 d72164776 Revert "[Impeller] Refactor color source resolution to use explicit factory types (#37656)" (flutter/engine#37673) (flutter/flutter#115467) * dcae42478 [tools]build ipa validate template icon files (flutter/flutter#114841)
johnpryan
pushed a commit
to Slowhand0309/packages
that referenced
this pull request
Nov 17, 2022
…r#2818) * 338841afd Revert "Revert "Revert "Scribble mixin (#104128)" (#114647)" (#114698)" (flutter/flutter#115146) * 229b39eda [flutter_tools] Fix so that the value set by `--dart-define-from-file` can be passed to Gradle (flutter/flutter#114297) * 3895786f9 Revert "Load assets in flutter_test without turning event loop. (#115123)" (flutter/flutter#115156) * a6e3ec8fa mark firebase test lab test flaky because of upstream infra issues (flutter/flutter#115178) * 8d808b5f9 Roll Flutter Engine from 7326e5b3354b to 329900fc85d6 (7 revisions) (flutter/flutter#115185) * 10dc56643 Add drone_dimensions to devicelab_build_test. (flutter/flutter#115183) * 0a5b531cc b6e45ae35 extend const_finder to allow skipping particular classes (flutter/engine#37257) (flutter/flutter#115189) * 0e9ee3679 [web] Add `--local-web-sdk` flag and use precompiled platform kernels for dart2js and ddc (flutter/flutter#114639) * 9e314ff74 Make FutureBuilder handle SynchronousFuture correctly, reland SynchronousFuture usage in test assets (flutter/flutter#115173) * 673fd973b 17d428e68 Roll Dart SDK from 2b6909ba35e5 to 190040da0bc8 (2 revisions) (flutter/engine#37536) (flutter/flutter#115191) * edcdb0046 Roll Flutter Engine from 17d428e688a9 to 38c4f1d78630 (2 revisions) (flutter/flutter#115192) * 877276812 Roll Flutter Engine from 38c4f1d78630 to 1f0dd2c0f5bb (2 revisions) (flutter/flutter#115194) * 6ec2bd0a8 M3 Segmented Button widget (flutter/flutter#113723) * b7b6758d5 f3dfdf4cc Roll Skia from 3bbdd5bc54f2 to a727f7ac8a98 (1 revision) (flutter/engine#37544) (flutter/flutter#115196) * 94e753d0f Roll Flutter Engine from f3dfdf4ccf38 to e3b3950f0fab (3 revisions) (flutter/flutter#115200) * 61e927d22 e63c9443b [Impeller] Include the new primitive type in the pipeline hash (flutter/engine#37546) (flutter/flutter#115201) * c05d887f5 Roll Flutter Engine from e63c9443bc04 to 9500d8c4a4ce (2 revisions) (flutter/flutter#115212) * 1f8298528 1c8c23754 Roll Fuchsia Linux SDK from xDY5B0-NZzq2idRNU... to IE4logHFoa8ZZQAw3... (flutter/engine#37554) (flutter/flutter#115214) * 61b3d5a88 a0d8cd68c Add a limit to the Gaussian blur downsampling curve (flutter/engine#37550) (flutter/flutter#115217) * 2bf64aaca fd56b7ee8 Roll Fuchsia Mac SDK from j3vspnGJcQvIfsXXu... to iPqmEVwAbmYwPlh5a... (flutter/engine#37557) (flutter/flutter#115218) * 53ab17d22 Roll Flutter Engine from fd56b7ee87f0 to 1ae285897eae (2 revisions) (flutter/flutter#115220) * 4488166f4 d4e2188e9 [Impeller] Fix DrawPaint regression (flutter/engine#37561) (flutter/flutter#115222) * bf906e6ce 2bdeaf7d7 Fix inertia cancel event on macOS Ventura (flutter/engine#37067) (flutter/flutter#115226) * 1a194094e 06c390470 Roll Fuchsia Mac SDK from iPqmEVwAbmYwPlh5a... to N-iOLgSVYYh_AfC7Q... (flutter/engine#37566) (flutter/flutter#115236) * 1a460cfb9 54795869b Roll Skia from c0f87aed019b to 38edf6197aa9 (1 revision) (flutter/engine#37567) (flutter/flutter#115239) * 8230ef5e8 Revert "[web] Add `--local-web-sdk` flag and use precompiled platform kernels for dart2js and ddc (#114639)" (flutter/flutter#115242) * 899492023 7269f2f91 Roll Skia from 38edf6197aa9 to 0f515e97d535 (1 revision) (flutter/engine#37571) (flutter/flutter#115244) * 7ac00f755 40b071c75 Roll Fuchsia Linux SDK from IE4logHFoa8ZZQAw3... to AE_mBWzdDqUvn4r1N... (flutter/engine#37572) (flutter/flutter#115247) * fa94a3c10 b63e6cf55 [Impeller] dont include sampler offset in float offset (flutter/engine#37573) (flutter/flutter#115248) * cb224d10e b7567b92c Roll Fuchsia Mac SDK from N-iOLgSVYYh_AfC7Q... to WYzUv6RnWjJpAiqYp... (flutter/engine#37575) (flutter/flutter#115252) * d587fe487 a1b5507e5 Add playground to demonstrate mask blur problems (flutter/engine#37574) (flutter/flutter#115260) * f5205b15c 6f7447efa Roll Fuchsia Linux SDK from AE_mBWzdDqUvn4r1N... to dRHIZSishiboEHMdw... (flutter/engine#37577) (flutter/flutter#115266) * 2c4051f0f b077c1c46 Roll Dart SDK from 996fe4d7ea9a to 45b7433f9015 (1 revision) (flutter/engine#37578) (flutter/flutter#115271) * 0b5f3fdd7 743cec5ba Roll Skia from 0f515e97d535 to b2109e6bbbe7 (1 revision) (flutter/engine#37580) (flutter/flutter#115279) * 80bcc3a34 035313ae2 Roll Dart SDK from 45b7433f9015 to 7cbcf48157cf (1 revision) (flutter/engine#37582) (flutter/flutter#115281) * fdd2fe410 036f8ea88 Roll Fuchsia Mac SDK from WYzUv6RnWjJpAiqYp... to XvXKIR_SSUfSyGwxe... (flutter/engine#37583) (flutter/flutter#115293) * 436fb4c6b c290de693 Roll Skia from b2109e6bbbe7 to 2ad14e25f6f7 (7 revisions) (flutter/engine#37585) (flutter/flutter#115294) * 244990775 Fixed the color curve issue (flutter/flutter#115188) * 9359c2578 1a79e8686 [macOS] Move to new update semantics embedder API (flutter/engine#37404) (flutter/flutter#115301) * 59e1edc66 Roll Flutter Engine from 1a79e8686036 to 8c73ffff5b6f (2 revisions) (flutter/flutter#115302) * f2ec1c459 42bc762b6 Roll Skia from 2ad14e25f6f7 to a434f9b69660 (11 revisions) (flutter/engine#37591) (flutter/flutter#115304) * ea4e11dd9 Fix test in preparation of the Dart VM dropping support for language versions < 2.12.0 (flutter/flutter#115176) * a0a7b3a70 14ecaeb91 [Impeller] error earlier on uint types (flutter/engine#37593) (flutter/flutter#115308) * 2e51077d1 Do not strip architecture suffixes from host local-engine (flutter/flutter#115320) * 8e3ea1478 Incorrect rendering of `SnapshotWidget` (flutter/flutter#114400) * 59ecc7574 [flutter_tools] add uint compilation test (flutter/flutter#115317) * 1aeb1721c Roll Flutter Engine from 14ecaeb915e0 to 78ae2414003a (10 revisions) (flutter/flutter#115335) * e39181299 9dedab305 Roll Skia from b474a43dcc34 to 2cebc1ce363c (2 revisions) (flutter/engine#37612) (flutter/flutter#115338) * 9d64a0f40 31ee28684 Combine results of all the test batches. (flutter/engine#37610) (flutter/flutter#115340) * e9c6212da [Impeller] Add shader include with FlutterFragCoord for use by FragmentProgram (flutter/flutter#114214) * a27bb3cd2 06bd5a816 Roll Skia from 2cebc1ce363c to d758b240cad0 (1 revision) (flutter/engine#37614) (flutter/flutter#115341) * abbffcc14 c6a513ecd Roll Fuchsia Mac SDK from XvXKIR_SSUfSyGwxe... to 32kfSm94FGtJJeUjg... (flutter/engine#37615) (flutter/flutter#115344) * 0f56ed133 f01de9f6b Roll Skia from d758b240cad0 to 24523449b1b3 (1 revision) (flutter/engine#37616) (flutter/flutter#115346) * 25d74e610 0b338ed86 Roll Dart SDK from 6f5478a58387 to 987faaf6d1d4 (2 revisions) (flutter/engine#37617) (flutter/flutter#115352) * 1f28f99a0 721fbe111 Roll Skia from 24523449b1b3 to 4d519a8ba97a (3 revisions) (flutter/engine#37618) (flutter/flutter#115354) * c37f255e8 [tools] Fix plugin_ffi template lint violation (flutter/flutter#115356) * 3c3f1363b b4fd07fa4 Roll Dart SDK from 987faaf6d1d4 to 42f87c0521f8 (1 revision) (flutter/engine#37619) (flutter/flutter#115362) * 2ed52830f 58495f077 [Impeller] Add debug names to additional VK objects (flutter/engine#37592) (flutter/flutter#115363) * afafde610 7f74f34a4 Roll Fuchsia Linux SDK from B0OuUvWOY24LI1WoF... to agStiOtzmc9Fmw6gc... (flutter/engine#37621) (flutter/flutter#115365) * af2ec91be Roll Plugins from 3ca3410 to e500884 (10 revisions) (flutter/flutter#115366) * 3a298d0b9 Roll Flutter Engine from 7f74f34a408a to eead7b0d8656 (2 revisions) (flutter/flutter#115369) * acf01eb3e 905862722 [dart] Run generate_sdk_version_file.py to be compatible with dart ch… (flutter/engine#37624) (flutter/flutter#115372) * 95ace11af Include initial offset when using PlatformViewSurface (flutter/flutter#114103) * 39a9ed572 Updated tokens to v0.141 (flutter/flutter#115298) * ba47c2964 216702f3d Roll Skia from 1991515dd191 to 826b3ea577f3 (4 revisions) (flutter/engine#37628) (flutter/flutter#115377) * 2d77ac584 49f8326df Roll Skia from 826b3ea577f3 to 02e2101a75f7 (4 revisions) (flutter/engine#37631) (flutter/flutter#115385) * 136b46ba9 Hint text semantics to be excluded in a11y read out if textfield in not empty and label text is provided (flutter/flutter#115010) * 700de09fd Change button and label text to sentence case for Material 3 (flutter/flutter#115187) * b2b839166 Roll Flutter Engine from 49f8326df6f0 to 84cb1f833ac4 (3 revisions) (flutter/flutter#115387) * 2c44f4a68 Remove dev branch reference from build ios-frameworks error (flutter/flutter#115166) * 792eefe60 Roll Flutter Engine from 84cb1f833ac4 to af6e47f1d5c4 (4 revisions) (flutter/flutter#115395) * 341a9b113 6d41b2ffb update Scene.toImageSync test to use proper bounds in the request (flutter/engine#37638) (flutter/flutter#115398) * e66183da3 Bump github/codeql-action from 2.1.25 to 2.1.32 (flutter/flutter#115394) * d0e5b2fba Add a way to customize padding in BottomAppBar (flutter/flutter#115175) * 349d6486e baad8f2c5 Roll Skia from 02e2101a75f7 to cfb6de45f39b (7 revisions) (flutter/engine#37640) (flutter/flutter#115399) * 7d2b01132 Fix logic error in `markNeedsPaint` (flutter/flutter#112735) * 93c4b09e6 Add `RestorableEnumN<T>` and `RestorableEnum<T>` to restorable primitive types (flutter/flutter#115050) * 2c1536a2d Create a main alias for master channel. (flutter/flutter#115388) * bbb349b3e Roll Flutter Engine from baad8f2c553b to e56ed93faab5 (6 revisions) (flutter/flutter#115406) * bacd77086 c062f7ea7 Roll Skia from cfb6de45f39b to cdf8348e6fba (4 revisions) (flutter/engine#37649) (flutter/flutter#115407) * 27ff6a510 Roll Flutter Engine from c062f7ea7195 to 03e9a97f8abe (3 revisions) (flutter/flutter#115410) * 58728c6a9 Roll Flutter Engine from 03e9a97f8abe to 21a572e4e4d0 (2 revisions) (flutter/flutter#115411) * e54c8a8e2 3e15c1925 Roll Dart SDK from 7163c9627d98 to c3f1b3642181 (2 revisions) (flutter/engine#37664) (flutter/flutter#115417) * 484e09ef7 Roll Flutter Engine from 3e15c192560f to 0241f18cbedf (2 revisions) (flutter/flutter#115423) * 4fdaf7ae2 Revert "Roll Flutter Engine from 3e15c192560f to 0241f18cbedf (2 revisions) (#115423)" (flutter/flutter#115456) * 4301731eb Make Flutter Driver actively wait for runnable isolate (flutter/flutter#113969) * c940f3182 Marks Mac_ios flavors_test_ios to be unflaky (flutter/flutter#115458) * 243a83012 Roll Flutter Engine from 3e15c192560f to 223e1f092dd5 (4 revisions) (flutter/flutter#115463) * d7454d552 removing default values for [reporter] and [timeout] in flutter test (flutter/flutter#115160) * a2233eabe [flutter_tools] remove all body_might_complete_normally_catch_error ignores (flutter/flutter#115184) * b5345ff55 d72164776 Revert "[Impeller] Refactor color source resolution to use explicit factory types (#37656)" (flutter/engine#37673) (flutter/flutter#115467) * dcae42478 [tools]build ipa validate template icon files (flutter/flutter#114841)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Nov 17, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Nov 18, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Nov 18, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Nov 18, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Nov 18, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Nov 18, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Nov 18, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Nov 18, 2022
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
* add position to layout creation * make position nullable * fix tests * test * clear test size * clear device pixel ratio * add more documentaiton * add comment about localToGlobal
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
* add position to layout creation * make position nullable * fix tests * test * clear test size * clear device pixel ratio * add more documentaiton * add comment about localToGlobal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
autosubmit
Merge PR when tree becomes green via auto submit App
framework
flutter/packages/flutter repository. See also f: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For TLHC (Texture Layer Hybrid Composition), the create request is expecting a
left
and atop
parameter on the engine side:https://github.com/flutter/engine/blob/main/shell/platform/android/io/flutter/embedding/engine/systemchannels/PlatformViewsChannel.java#L117
AFAICT, there is never any
top
orleft
parameters passed from the framework when creating a platform view:https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/services/platform_views.dart#L1186
Therefore, the creation requests default to position
(0, 0)
and the Android View hierarchy thinks the PlatformView is onscreen for the initial render since it is added to the FlutterView (but not drawn). Note that later a PlatformViewsChannel call is made to the offset method to set the top and left margin positions.This PR makes the create call wait for the initial position of the platform view before it is made.
Should fix googleads/googleads-mobile-flutter#580
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.