Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ThemeData 🧹] Remove dialogBackgroundColor usages #116348

Closed
wants to merge 3 commits into from

Conversation

guidezpl
Copy link
Member

@guidezpl guidezpl commented Dec 1, 2022

This prepares the deprecation of this property by removing framework usages.

  • Uses DialogTheme.backgroundColor as replacement

The deprecation and a Dart fix will be in #116369.

Part of #91772

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Dec 1, 2022
@guidezpl guidezpl changed the title [ThemeData 🧹] Refactor dialogBackgroundColor usages [ThemeData 🧹] Remove dialogBackgroundColor usages Dec 1, 2022
@guidezpl guidezpl closed this Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant