Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain how to test onSubmitted in its docs #117550

Merged
merged 2 commits into from Dec 22, 2022
Merged

Explain how to test onSubmitted in its docs #117550

merged 2 commits into from Dec 22, 2022

Conversation

justinmc
Copy link
Contributor

It's somewhat unintuitive that sending an enter key in a test can't be used to trigger onSubmitted. Someone recently posted an issue about this: #116752.

This PR adds an explanation in the docs of onSubmitted explaining how to properly invoke it in a test.

Fixes #116752

@justinmc justinmc self-assigned this Dec 22, 2022
@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Dec 22, 2022
@justinmc justinmc mentioned this pull request Dec 22, 2022
Closed
TahaTesser
TahaTesser approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

packages/flutter/lib/src/widgets/editable_text.dart Show resolved Hide resolved
@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 22, 2022
@auto-submit auto-submit bot merged commit 08209b7 into flutter:master Dec 22, 2022
@justinmc justinmc deleted the testing-on-submitted branch December 22, 2022 23:46
This was referenced Dec 23, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 23, 2022
@engine-flutter-autoroll
08209b7e0 Explain how to test onSubmitted in its docs (flutter/flutte…
17aa72b 
…r#117550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Dec 23, 2022
@engine-flutter-autoroll
08209b7 Explain how to test onSubmitted in its docs (flutter/flutter#…
1a4378d 
…117550)
auto-submit bot pushed a commit to flutter/plugins that referenced this pull request Dec 23, 2022
@engine-flutter-autoroll
Roll Flutter from 9fb1ae8 to a45a2f3 (19 revisions) (#6879)
986b16a 
* 95ff839 Roll Plugins from 54fc206 to 2dd85ec (3 revisions) (flutter/flutter#117535)

* b8d5d9c Revert "Remove single-view assumption from widgets library (#117480)" (flutter/flutter#117545)

* bd482eb fixes android_semantics_integration_test to expect long press for tooltip (flutter/flutter#117547)

* 725c141 Fix screenshot testing for flutter web integration_test (flutter/flutter#117114)

* 999356b Remove single-view assumption from ScrollPhysics (flutter/flutter#117503)

* 6eb002a Reland "Remove single-view assumption from widgets library (#117480)" (flutter/flutter#117549)

* 08209b7 Explain how to test onSubmitted in its docs (flutter/flutter#117550)

* 20bc2ba Roll Flutter Engine from a90c45db3f13 to 234ab4c1e9c4 (1 revision) (flutter/flutter#117555)

* abd5217 Bump ossf/scorecard-action from 2.1.1 to 2.1.2 (flutter/flutter#117554)

* 6781576 Reland iOS 16 context menu (flutter/flutter#117234)

* daa2ecf Roll Flutter Engine from 234ab4c1e9c4 to ca0c843bf75f (11 revisions) (flutter/flutter#117563)

* 6441a7d Roll Flutter Engine from ca0c843bf75f to 12badb54598d (2 revisions) (flutter/flutter#117566)

* a0cecbe 3b5fb86a5 delete unused lib/src/engine/canvaskit/viewport_metrics.dart (flutter/engine#38474) (flutter/flutter#117572)

* fbfda23 Roll Flutter Engine from 3b5fb86a5982 to 6295d9198da1 (3 revisions) (flutter/flutter#117576)

* 3eca29b f2a071692 Roll Skia from 3e39affa3e1d to 45466d04ca49 (1 revision) (flutter/engine#38480) (flutter/flutter#117579)

* 05914e7 948d0bffa Roll Dart SDK from 47f192463696 to 442614a6c1bb (1 revision) (flutter/engine#38481) (flutter/flutter#117581)

* a34dec2 00995b7b9 Roll Skia from 45466d04ca49 to e206aa0c44f0 (4 revisions) (flutter/engine#38482) (flutter/flutter#117585)

* 4ef24cf 238f40bb9 Roll Fuchsia Mac SDK from W0GUdjHi4gI48optN... to 9w7QDlttR9f7Gu7U6... (flutter/engine#38483) (flutter/flutter#117587)

* a45a2f3 ad042d863 Roll Skia from e206aa0c44f0 to a8b7ce3b6391 (1 revision) (flutter/engine#38484) (flutter/flutter#117589)
tarrinneal pushed a commit to flutter/packages that referenced this pull request Dec 27, 2022
@engine-flutter-autoroll
Roll Flutter from 9fb1ae839e0a to a45a2f311990 (19 revisions) (#3001)
a978884 
* 95ff83976 Roll Plugins from 54fc206 to 2dd85ec (3 revisions) (flutter/flutter#117535)

* b8d5d9c46 Revert "Remove single-view assumption from widgets library (#117480)" (flutter/flutter#117545)

* bd482ebc5 fixes android_semantics_integration_test to expect long press for tooltip (flutter/flutter#117547)

* 725c1415d Fix screenshot testing for flutter web integration_test (flutter/flutter#117114)

* 999356b77 Remove single-view assumption from ScrollPhysics (flutter/flutter#117503)

* 6eb002a16 Reland "Remove single-view assumption from widgets library (#117480)" (flutter/flutter#117549)

* 08209b7e0 Explain how to test onSubmitted in its docs (flutter/flutter#117550)

* 20bc2bac3 Roll Flutter Engine from a90c45db3f13 to 234ab4c1e9c4 (1 revision) (flutter/flutter#117555)

* abd5217f4 Bump ossf/scorecard-action from 2.1.1 to 2.1.2 (flutter/flutter#117554)

* 6781576e8 Reland iOS 16 context menu (flutter/flutter#117234)

* daa2ecf16 Roll Flutter Engine from 234ab4c1e9c4 to ca0c843bf75f (11 revisions) (flutter/flutter#117563)

* 6441a7dc6 Roll Flutter Engine from ca0c843bf75f to 12badb54598d (2 revisions) (flutter/flutter#117566)

* a0cecbe69 3b5fb86a5 delete unused lib/src/engine/canvaskit/viewport_metrics.dart (flutter/engine#38474) (flutter/flutter#117572)

* fbfda23f2 Roll Flutter Engine from 3b5fb86a5982 to 6295d9198da1 (3 revisions) (flutter/flutter#117576)

* 3eca29b3a f2a071692 Roll Skia from 3e39affa3e1d to 45466d04ca49 (1 revision) (flutter/engine#38480) (flutter/flutter#117579)

* 05914e773 948d0bffa Roll Dart SDK from 47f192463696 to 442614a6c1bb (1 revision) (flutter/engine#38481) (flutter/flutter#117581)

* a34dec2e7 00995b7b9 Roll Skia from 45466d04ca49 to e206aa0c44f0 (4 revisions) (flutter/engine#38482) (flutter/flutter#117585)

* 4ef24cf21 238f40bb9 Roll Fuchsia Mac SDK from W0GUdjHi4gI48optN... to 9w7QDlttR9f7Gu7U6... (flutter/engine#38483) (flutter/flutter#117587)

* a45a2f311 ad042d863 Roll Skia from e206aa0c44f0 to a8b7ce3b6391 (1 revision) (flutter/engine#38484) (flutter/flutter#117589)
loic-sharma pushed a commit to fluttergithubbot/flutter that referenced this pull request Jan 6, 2023
@justinmc @loic-sharma
Explain how to test onSubmitted in its docs (flutter#117550)
64f4df0 
* Explain how to test onSubmitted

* Fix analyzer saying tester is undefined
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@justinmc @gspencergoog
Explain how to test onSubmitted in its docs (flutter#117550)
f0a9f97 
* Explain how to test onSubmitted

* Fix analyzer saying tester is undefined
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@engine-flutter-autoroll @mauricioluz
Roll Flutter from 9fb1ae8 to a45a2f3 (19 revisions) (flutter#6879)
432f875 
* 95ff839 Roll Plugins from 54fc206 to 2dd85ec (3 revisions) (flutter/flutter#117535)

* b8d5d9c Revert "Remove single-view assumption from widgets library (#117480)" (flutter/flutter#117545)

* bd482eb fixes android_semantics_integration_test to expect long press for tooltip (flutter/flutter#117547)

* 725c141 Fix screenshot testing for flutter web integration_test (flutter/flutter#117114)

* 999356b Remove single-view assumption from ScrollPhysics (flutter/flutter#117503)

* 6eb002a Reland "Remove single-view assumption from widgets library (#117480)" (flutter/flutter#117549)

* 08209b7 Explain how to test onSubmitted in its docs (flutter/flutter#117550)

* 20bc2ba Roll Flutter Engine from a90c45db3f13 to 234ab4c1e9c4 (1 revision) (flutter/flutter#117555)

* abd5217 Bump ossf/scorecard-action from 2.1.1 to 2.1.2 (flutter/flutter#117554)

* 6781576 Reland iOS 16 context menu (flutter/flutter#117234)

* daa2ecf Roll Flutter Engine from 234ab4c1e9c4 to ca0c843bf75f (11 revisions) (flutter/flutter#117563)

* 6441a7d Roll Flutter Engine from ca0c843bf75f to 12badb54598d (2 revisions) (flutter/flutter#117566)

* a0cecbe 3b5fb86a5 delete unused lib/src/engine/canvaskit/viewport_metrics.dart (flutter/engine#38474) (flutter/flutter#117572)

* fbfda23 Roll Flutter Engine from 3b5fb86a5982 to 6295d9198da1 (3 revisions) (flutter/flutter#117576)

* 3eca29b f2a071692 Roll Skia from 3e39affa3e1d to 45466d04ca49 (1 revision) (flutter/engine#38480) (flutter/flutter#117579)

* 05914e7 948d0bffa Roll Dart SDK from 47f192463696 to 442614a6c1bb (1 revision) (flutter/engine#38481) (flutter/flutter#117581)

* a34dec2 00995b7b9 Roll Skia from 45466d04ca49 to e206aa0c44f0 (4 revisions) (flutter/engine#38482) (flutter/flutter#117585)

* 4ef24cf 238f40bb9 Roll Fuchsia Mac SDK from W0GUdjHi4gI48optN... to 9w7QDlttR9f7Gu7U6... (flutter/engine#38483) (flutter/flutter#117587)

* a45a2f3 ad042d863 Roll Skia from e206aa0c44f0 to a8b7ce3b6391 (1 revision) (flutter/engine#38484) (flutter/flutter#117589)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TahaTesser TahaTesser TahaTesser approved these changes

@LongCatIsLooong LongCatIsLooong Awaiting requested review from LongCatIsLooong

Assignees

@justinmc justinmc

Labels
a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WidgetTester.sendKeyEvent(LogicalKeyboardKey.enter) does not trigger TextField.onSubmitted
2 participants
@justinmc @TahaTesser