Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flutter roll] Revert "[reland] Add Material 3 support for ListTile - Part 1" #117756

Merged
merged 1 commit into from Dec 29, 2022
Merged

[flutter roll] Revert "[reland] Add Material 3 support for ListTile - Part 1" #117756

merged 1 commit into from Dec 29, 2022

Conversation

XilaiZhang
Copy link
Contributor

@XilaiZhang XilaiZhang commented Dec 28, 2022 •
edited by chunhtai

Reverts #116963.

context: https://b.corp.google.com/issues/262687159.
Reported by internal customer as breaking scubas

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. labels Dec 28, 2022
chunhtai
chunhtai approved these changes Dec 28, 2022
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM, have you tested if this was the root cause of the broken scuba?

@XilaiZhang
Copy link
Contributor Author

Ah i haven't. Good point, will run more thorough tests to verify.

@XilaiZhang
Copy link
Contributor Author

yep reproduced in cl/498305206 and verified that it is the cause of the list tile changes in scubas. updated reproduced test link in https://b.corp.google.com/issues/262687159. merging

@XilaiZhang XilaiZhang added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 29, 2022
@auto-submit auto-submit bot merged commit c089c19 into master Dec 29, 2022
@auto-submit auto-submit bot deleted the revert-116963-reland_m3_list_tile_pt1 branch December 29, 2022 05:36
@esouthren
Copy link
Contributor

FYI - this issue seems to be related to ListTiles within PopupMenus - the docs in popup_menu advise using list tiles as children, but since M3 list tiles now have a surface color, I think we're getting an undesired mismatch between the elevation tint of the menu container and no elevation tinting on the list tile.

This was referenced Dec 29, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 29, 2022
@engine-flutter-autoroll
c089c19f1 Revert "[reland] Add Material 3 support for ListTile - Pa…
c58ca55 
…rt 1 (#116963)" (flutter/flutter#117756)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Dec 29, 2022
@engine-flutter-autoroll
c089c19 Revert "[reland] Add Material 3 support for ListTile - Part…
9460cbb 
… 1 (#116963)" (flutter/flutter#117756)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Dec 29, 2022
@engine-flutter-autoroll
Roll Flutter from 17482fd425ee to d2127ad344e8 (14 revisions) (#3009)
2fb470f 
* 9bb4ffe15 Roll Flutter Engine from 9e63c1ae1480 to 190f743a8506 (2 revisions) (flutter/flutter#117744)

* babeb6191 cc8055d5f Roll Skia from 4b578d72dc2e to e4c86c2fed9a (1 revision) (flutter/engine#38535) (flutter/flutter#117745)

* 9afaf6b88 f3cc581d9 Roll Dart SDK from 6e07d9b025bd to f7b36d5e50a5 (1 revision) (flutter/engine#38536) (flutter/flutter#117749)

* 0e83ada59 Update M3 IconButton unselected focused opacity (flutter/flutter#117321)

* 2783d3168 Roll Flutter Engine from f3cc581d97e1 to 3655bf981d4c (2 revisions) (flutter/flutter#117751)

* 4a6ab96c9 Roll Flutter Engine from 3655bf981d4c to 34f75ed27c9b (3 revisions) (flutter/flutter#117760)

* 2ffa65c76 e9e79180e Roll Skia from 2923399853d9 to 0027eb334691 (6 revisions) (flutter/engine#38545) (flutter/flutter#117763)

* cee9ec522 606e77f35 Roll Skia from 0027eb334691 to 668260c85e9d (1 revision) (flutter/engine#38547) (flutter/flutter#117766)

* c089c19f1 Revert "[reland] Add Material 3 support for `ListTile` - Part 1 (#116963)" (flutter/flutter#117756)

* bdefebcf7 9b534a5f8 Roll Skia from 668260c85e9d to 25ffa2b757e9 (1 revision) (flutter/engine#38548) (flutter/flutter#117768)

* aa70994f6 8655ec022 [Impeller Scene] Add ColorSourceContents for drawing a node (flutter/engine#38485) (flutter/flutter#117769)

* cbc184d9a Roll Flutter Engine from 8655ec022fe1 to ecd47e0b256a (2 revisions) (flutter/flutter#117772)

* 0b6971946 Roll Flutter Engine from ecd47e0b256a to 45e689b15d1a (2 revisions) (flutter/flutter#117778)

* d2127ad34 e44a0de4c Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter/engine#38558) (flutter/flutter#117779)
auto-submit bot pushed a commit to flutter/plugins that referenced this pull request Dec 29, 2022
@engine-flutter-autoroll
Roll Flutter from 17482fd to d2127ad (14 revisions) (#6892)
b202b3d 
* 9bb4ffe Roll Flutter Engine from 9e63c1ae1480 to 190f743a8506 (2 revisions) (flutter/flutter#117744)

* babeb61 cc8055d5f Roll Skia from 4b578d72dc2e to e4c86c2fed9a (1 revision) (flutter/engine#38535) (flutter/flutter#117745)

* 9afaf6b f3cc581d9 Roll Dart SDK from 6e07d9b025bd to f7b36d5e50a5 (1 revision) (flutter/engine#38536) (flutter/flutter#117749)

* 0e83ada Update M3 IconButton unselected focused opacity (flutter/flutter#117321)

* 2783d31 Roll Flutter Engine from f3cc581d97e1 to 3655bf981d4c (2 revisions) (flutter/flutter#117751)

* 4a6ab96 Roll Flutter Engine from 3655bf981d4c to 34f75ed27c9b (3 revisions) (flutter/flutter#117760)

* 2ffa65c e9e79180e Roll Skia from 2923399853d9 to 0027eb334691 (6 revisions) (flutter/engine#38545) (flutter/flutter#117763)

* cee9ec5 606e77f35 Roll Skia from 0027eb334691 to 668260c85e9d (1 revision) (flutter/engine#38547) (flutter/flutter#117766)

* c089c19 Revert "[reland] Add Material 3 support for `ListTile` - Part 1 (#116963)" (flutter/flutter#117756)

* bdefebc 9b534a5f8 Roll Skia from 668260c85e9d to 25ffa2b757e9 (1 revision) (flutter/engine#38548) (flutter/flutter#117768)

* aa70994 8655ec022 [Impeller Scene] Add ColorSourceContents for drawing a node (flutter/engine#38485) (flutter/flutter#117769)

* cbc184d Roll Flutter Engine from 8655ec022fe1 to ecd47e0b256a (2 revisions) (flutter/flutter#117772)

* 0b69719 Roll Flutter Engine from ecd47e0b256a to 45e689b15d1a (2 revisions) (flutter/flutter#117778)

* d2127ad e44a0de4c Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter/engine#38558) (flutter/flutter#117779)
@TahaTesser
Copy link
Member

TahaTesser commented Jan 2, 2023 •
edited

Thanks for the details! @esouthren .

M3 ListTile shouldn't have a surface color (it was added per specs).
As it has been reported here #117700

This was referenced Jan 2, 2023
Closed
Merged
@TahaTesser
Copy link
Member

#117965 will land with the fix and other M3 updates for ListTile.

loic-sharma pushed a commit to fluttergithubbot/flutter that referenced this pull request Jan 6, 2023
@XilaiZhang @loic-sharma
Revert "[reland] Add Material 3 support for ListTile - Part 1 (flut…
edd78cd 
…ter#116963)" (flutter#117756)

This reverts commit 57fb36e.
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@XilaiZhang @gspencergoog
Revert "[reland] Add Material 3 support for ListTile - Part 1 (flut…
394d060 
…ter#116963)" (flutter#117756)

This reverts commit 57fb36e.
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@engine-flutter-autoroll @mauricioluz
Roll Flutter from 17482fd to d2127ad (14 revisions) (flutter#6892)
66b7749 
* 9bb4ffe Roll Flutter Engine from 9e63c1ae1480 to 190f743a8506 (2 revisions) (flutter/flutter#117744)

* babeb61 cc8055d5f Roll Skia from 4b578d72dc2e to e4c86c2fed9a (1 revision) (flutter/engine#38535) (flutter/flutter#117745)

* 9afaf6b f3cc581d9 Roll Dart SDK from 6e07d9b025bd to f7b36d5e50a5 (1 revision) (flutter/engine#38536) (flutter/flutter#117749)

* 0e83ada Update M3 IconButton unselected focused opacity (flutter/flutter#117321)

* 2783d31 Roll Flutter Engine from f3cc581d97e1 to 3655bf981d4c (2 revisions) (flutter/flutter#117751)

* 4a6ab96 Roll Flutter Engine from 3655bf981d4c to 34f75ed27c9b (3 revisions) (flutter/flutter#117760)

* 2ffa65c e9e79180e Roll Skia from 2923399853d9 to 0027eb334691 (6 revisions) (flutter/engine#38545) (flutter/flutter#117763)

* cee9ec5 606e77f35 Roll Skia from 0027eb334691 to 668260c85e9d (1 revision) (flutter/engine#38547) (flutter/flutter#117766)

* c089c19 Revert "[reland] Add Material 3 support for `ListTile` - Part 1 (#116963)" (flutter/flutter#117756)

* bdefebc 9b534a5f8 Roll Skia from 668260c85e9d to 25ffa2b757e9 (1 revision) (flutter/engine#38548) (flutter/flutter#117768)

* aa70994 8655ec022 [Impeller Scene] Add ColorSourceContents for drawing a node (flutter/engine#38485) (flutter/flutter#117769)

* cbc184d Roll Flutter Engine from 8655ec022fe1 to ecd47e0b256a (2 revisions) (flutter/flutter#117772)

* 0b69719 Roll Flutter Engine from ecd47e0b256a to 45e689b15d1a (2 revisions) (flutter/flutter#117778)

* d2127ad e44a0de4c Roll Fuchsia Mac SDK from JLTTlcNPJeScjSO2B... to FeFYsNPy64-PEXPer... (flutter/engine#38558) (flutter/flutter#117779)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunhtai chunhtai chunhtai approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@XilaiZhang @esouthren @TahaTesser @chunhtai