Remove references to Observatory #118577

bkonyi · 2023-01-16T16:32:05Z

Observatory is being deprecated for Dart 3.0 so it should no longer be referenced in tooling messaging / flags.

Observatory is being deprecated for Dart 3.0 so it should no longer be referenced in tooling messaging / flags. See dart-lang/sdk#50233

packages/flutter_tools/lib/src/globals.dart

packages/flutter_tools/bin/xcode_backend.dart

christopherfujino · 2023-01-19T23:54:11Z

Oops, missed that this was marked WIP :). FYI, if you use the GitHub "convert to draft" feature, this won't show up in weekly PR review.

packages/flutter_tools/bin/xcode_backend.dart

jmagman · 2023-01-31T16:02:56Z

packages/flutter_tools/lib/src/commands/screenshot.dart

@@ -29,13 +29,13 @@ class ScreenshotCommand extends FlutterCommand {
      help: 'Location to write the screenshot.',
    );
    argParser.addOption(
-      _kObservatoryUrl,
+      _kVmServiceUrl,


Instead of keeping --observatory-url as an alias, you could "deprecate" the flag. I say "deprecated" in quotes because there's no official way to do this except to update the help text with (deprecated) and either use it when passed in as --vm-service-url with some warning output that it's deprecated, or on validateCommand() throw and say it's deprecated.

flutter/packages/flutter_tools/lib/src/commands/build_bundle.dart

Line 57 in 2c34a88

help: '(deprecated) Icon font tree shaking is not supported by this command.',

flutter/packages/flutter_tools/lib/src/commands/build_bundle.dart

Lines 88 to 90 in 2c34a88

if (boolArgDeprecated('tree-shake-icons')) {

throwToolExit('The "--tree-shake-icons" flag is deprecated for "build bundle" and will be removed in a future version of Flutter.');

}

jmagman · 2023-01-31T18:06:20Z

packages/flutter_tools/lib/src/commands/attach.dart

@@ -97,18 +97,18 @@ class AttachCommand extends FlutterCommand {
      ..addOption(
        'debug-port',
        hide: !verboseHelp,
-        help: '(deprecated) Device port where the observatory is listening. Requires '
+        help: '(deprecated) Device port where the Dart VM Service is listening. Requires '


Maybe it's time to delete this flag? Or do we usually leave deprecated flags in for longer @christopherfujino?

I'm on board with removing this flag, but I'd rather not do it as part of this PR just in case it breaks something down stream.

Let me ask Hixie (who noted its deprecated) in discord...

Yeah it doesn't have to be in this PR, if at all.

jmagman · 2023-01-31T18:10:57Z

packages/flutter_tools/lib/src/commands/daemon.dart

@@ -1014,7 +1014,7 @@ class DeviceDomain extends Domain {
    );
    return <String, Object?>{
      'started': result.started,
-      'observatoryUri': result.observatoryUri?.toString(),
+      'vmServiceUri': result.vmServiceUri?.toString(),


The IDE plugins using daemon don't know about this key, I think you need to pass both for awhile:
https://github.com/flutter/flutter-intellij/blob/10fb2dd347c6553f40d18071bd669c4bf8a7aadb/flutter-idea/src/io/flutter/run/test/FlutterTestEventsConverter.java#L67

Make sure you test the IDEs on this change to ensure nothing else is broken.

Checked with Intellij and VSCode, everything seems to be working with the targets I tried.

Looks like tests didn't work from IntelliJ: #121555

jmagman · 2023-01-31T18:15:25Z

packages/flutter_tools/lib/src/runner/flutter_command.dart

  void usesPortOptions({ required bool verboseHelp }) {
-    argParser.addOption(observatoryPortOption,
+    argParser.addOption(vmServicePortOption,
+        aliases: const <String>['observatory-port'],


Same comment, you can keep this alias around, or you can "deprecate" it and throw or warn when it's used. @christopherfujino may have a preference.

I'm ok with the alias, it's just another line of code and we won't break anyone's scripts.

jmagman · 2023-01-31T18:18:36Z

18:28 +25 -1: test\integration.shard\test_test.dart: flutter test should respect --serve-observatory [E]
  TimeoutException after 0:15:00.000000: Test timed out after 15 minutes.
  dart:isolate  _RawReceivePort._handleMessage

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8790433970637832785/+/u/run_test.dart_for_tool_integration_tests_shard_and_subshard_6_6/test_stdout

bkonyi · 2023-01-31T18:21:08Z

18:28 +25 -1: test\integration.shard\test_test.dart: flutter test should respect --serve-observatory [E]
  TimeoutException after 0:15:00.000000: Test timed out after 15 minutes.
  dart:isolate  _RawReceivePort._handleMessage
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8790433970637832785/+/u/run_test.dart_for_tool_integration_tests_shard_and_subshard_6_6/test_stdout

I'm unable to reproduce this failure, even under load.

…vatory_messaging

bkonyi · 2023-02-07T15:41:08Z

Friendly bump. Still looking for a review on this.

christopherfujino

LGTM, let's give it a whirl

jmagman

Sorry lost track of this, LGTM!

* 7fb8497b5 Roll Plugins from 02571ec to f3bc6f1 (2 revisions) (flutter/flutter#120601) * 7c2d5b9c2 60c8532d6 Roll Fuchsia Mac SDK from NZAnfCkpbswhYplty... to 6hbPQq6ED0PkuQiKM... (flutter/engine#39587) (flutter/flutter#120602) * 1f268f1d6 fb8840578 Roll Dart SDK from 1caf3a9ad101 to f80c5db8736a (1 revision) (flutter/engine#39588) (flutter/flutter#120606) * 957494d9f Marks Linux_android flavors_test to be unflaky (flutter/flutter#120299) * 0792c2795 Roll Flutter Engine from fb8840578156 to df0ffe42b33e (2 revisions) (flutter/flutter#120607) * 7bacc25ee Remove accentColorBrightness usage (flutter/flutter#120577) * 98576cef5 Avoid null terminating characters in strings from Utf8FromUtf16() (flutter/flutter#109729) * 00adf9a33 roll packages (flutter/flutter#120609) * 2df140f40 Remove references to Observatory (flutter/flutter#118577) * a819d6156 Remove `prefer_equal_for_default_values` lint rule (flutter/flutter#120533) * 73afc7ba3 Roll Flutter Engine from df0ffe42b33e to 97dcf3e6201e (4 revisions) (flutter/flutter#120617) * f858302a6 Remove `brightness` from `AppBar`/`SliverAppBar`/`AppBarTheme`/`AppBarTheme.copyWith` (flutter/flutter#120575) * 95fd821ab Force `Mac build_tests` to run on x64 bots (flutter/flutter#120620) * ed35c80d2 d28cbf402 [Impeller] Return entity from filters instead of a snapshot (flutter/engine#39560) (flutter/flutter#120625) * 778b3fa32 support updating dragDecices at runtime (flutter/flutter#120336) * ddebe833b Added integration test for wide gamut support. (flutter/flutter#119657) * becb6bd00 Fix message type inconsistency between locales (flutter/flutter#120129) * f4495f5d3 Roll Flutter Engine from d28cbf402904 to 31a4648cbe99 (2 revisions) (flutter/flutter#120630) * 402caec2e Fix `ListTile`'s default `iconColor` token used & update examples (flutter/flutter#120444) * 865422da2 Force `Mac tool_integration_tests` to run on x64 bots (flutter/flutter#120634) * 07c548c69 Apply BindingBase.checkInstance to TestDefaultBinaryMessengerBinding (flutter/flutter#116937) * b08cc8be7 Roll Flutter Engine from 31a4648cbe99 to c4f51bc78644 (7 revisions) (flutter/flutter#120656) * 6a94f25a9 Roll Flutter Engine from c4f51bc78644 to 17ab09d382e3 (5 revisions) (flutter/flutter#120664) * b0edf5829 Roll Flutter Engine from 17ab09d382e3 to cbb7fc020b00 (2 revisions) (flutter/flutter#120673) * 17b4c70ff [M3] Add customizable overflow property to Snackbar's action (flutter/flutter#120394) * b35e4a54f Roll Plugins from f3bc6f1 to 9c312d4 (2 revisions) (flutter/flutter#120694) * 9fd34048f f4fcb911b Roll Skia from bb7b22f3f444 to 8de7f68a3661 (1 revision) (flutter/engine#39619) (flutter/flutter#120699) * b9b4d3e43 roll packages (flutter/flutter#120628) * ed5bd1779 Fix tree by updating dependencies (flutter/flutter#120707) * 480c54c37 Increase Linux docs_publish timeout (flutter/flutter#120718) * c102bf467 [integration_test] Fix link to integration test for web section in `README.md` (flutter/flutter#103422) * 577ad2ee8 Fix error when resetting configurations in tear down phase (flutter/flutter#114468) * 2cfca820a Force Mac plugin_test to run on x64 bots (flutter/flutter#120714) * fd2fd94e3 d86089252 Roll Fuchsia Mac SDK from OeUljRQOmJwgDhNOo... to EFcCpAxOuQllDqP0F... (flutter/engine#39621) (flutter/flutter#120702) * 9d94a51b6 Move linux-x64-flutter-gtk.zip to linux-x64-debug location. (flutter/flutter#120658) * d29668ddb Improve network resources doctor check (flutter/flutter#120417) * 378668db4 added MaterialStateColor support to TabBarTheme.labelColor (flutter/flutter#109541) * ba46cb8d5 Remove deprecated AppBar.color & AppBar.backwardsCompatibility (flutter/flutter#120618) * 5a3957f3b Revert "Fix error when resetting configurations in tear down phase" (flutter/flutter#120739) * fd01812f6 Add temporary default case to support new PointerSignalKind (flutter/flutter#120731) * 4b8ad1b00 Temporarily disable info-based analyzer unit tests. (flutter/flutter#120753) * 911b13784 Roll Flutter Engine from d860892528ff to 44e36c9c0d73 (20 revisions) (flutter/flutter#120761) * 4ae5252f8 Fix license page crash (flutter/flutter#120728) * 31c73fcfe Roll Flutter Engine from 44e36c9c0d73 to bf7d51586704 (2 revisions) (flutter/flutter#120772) * 624445a45 Roll Flutter Engine from bf7d51586704 to ec70b5aa96be (2 revisions) (flutter/flutter#120781) * df41e58f6 1328c4bc6 Roll Dart SDK from 0456c4011cb3 to c022d475e9d8 (1 revision) (flutter/engine#39646) (flutter/flutter#120784)

* 001c495 Roll Flutter Engine from 9a40a384997d to e1d0032029e4 (6 revisions) (flutter/flutter#120414) * 96823590e post submit only (flutter/flutter#120411) * 5dbd28101 Use String.codeUnitAt instead of String.codeUnits[] in ParagraphBoundary (flutter/flutter#120234) * f05a555bc Fix lerping for `NavigationRailThemeData` icon themes (flutter/flutter#120066) * b0d04ea49 add9e11ed Fix position of BackdropFilter above PlatformView (flutter/engine#39244) (flutter/flutter#120415) * 858f94cfa Roll Plugins from 73986f4 to 02571ec (3 revisions) (flutter/flutter#120443) * 298c874ea Fix classes that shouldn't be extended/instantiated/mixedin (flutter/flutter#120409) * 25c2c22d2 Delete Chrome temp cache after closing (flutter/flutter#119062) * b2e37c659 [conductor] Tag engine versions (flutter/flutter#120419) * 780c9a8de Remove deprecated SystemChrome.setEnabledSystemUIOverlays (flutter/flutter#119576) * 52ab29936 Roll Flutter Engine from add9e11edb66 to 4104eb5cbc40 (14 revisions) (flutter/flutter#120470) * 65fd924d8 [conductor] Remove CiYaml model (flutter/flutter#120458) * d5dbcb708 Revert "Revert "[web] Move JS content to its own `.js` files (#117691)" (#120275)" (flutter/flutter#120363) * 2f9abd20f Roll Flutter Engine from 4104eb5cbc40 to 6660300ea34f (6 revisions) (flutter/flutter#120487) * d63c54c9c roll packages (flutter/flutter#120493) * 941578ea9 Roll Flutter Engine from 6660300ea34f to 5e3ff1e5c9b3 (4 revisions) (flutter/flutter#120495) * b3613c4cf f737dc868 [macOS] Add XCode marks for TextInputPlugin (flutter/engine#39550) (flutter/flutter#120501) * 4ab2ffd58 Roll Flutter Engine from f737dc868a3e to 3ac3338489d2 (2 revisions) (flutter/flutter#120505) * 859d57b3c 8baee2164 Roll Skia from 5230650dc096 to 70a3a194ec98 (2 revisions) (flutter/engine#39554) (flutter/flutter#120507) * e42ab1cb0 c3dc68e0e Roll Skia from 70a3a194ec98 to 6c3097e6f833 (1 revision) (flutter/engine#39555) (flutter/flutter#120508) * 61e059f44 Roll Flutter Engine from c3dc68e0e263 to 363355af5158 (2 revisions) (flutter/flutter#120511) * d27de1de0 5efb42971 Roll Fuchsia Linux SDK from 482Njb1v72P7fNyj4... to MVMTNxWJaWdwPWstz... (flutter/engine#39559) (flutter/flutter#120512) * bbf8446d9 761891200 Roll Dart SDK from 1d26a1d57edf to b1836aacc08a (1 revision) (flutter/engine#39561) (flutter/flutter#120513) * 0346f4b18 d8e01097e Roll Fuchsia Mac SDK from 6nMZjuYXTcnD_VZQI... to FxFPRn_9rSWWAWFw0... (flutter/engine#39562) (flutter/flutter#120519) * 0db47bdd0 Revert "Fix BottomAppBar & BottomSheet M3 shadow (#119819)" (flutter/flutter#120492) * f04600bfb Roll Flutter Engine from d8e01097e66b to 2cba062f9f4c (2 revisions) (flutter/flutter#120538) * 274f6cb2d Roll Flutter Engine from 2cba062f9f4c to 05d81c0f2ebe (2 revisions) (flutter/flutter#120547) * d6ff0f2af fe56a45b4 Roll Dart SDK from c4255cea566a to 1caf3a9ad101 (1 revision) (flutter/engine#39571) (flutter/flutter#120552) * 7295d4fe9 9a19d7eea Roll Fuchsia Linux SDK from arbaBzyUE2ok1bGl5... to 8fdyKaKQqTPpjcp-L... (flutter/engine#39572) (flutter/flutter#120554) * 6d68eb7b8 0aa4fcbd2 Roll Skia from ec87ec6fd34f to 615965d545f4 (1 revision) (flutter/engine#39573) (flutter/flutter#120558) * 527977b6a b7e80ad6e Roll Fuchsia Mac SDK from y35kWL0rP5Nd06lTg... to KpTOXssqVhPv2OBZi... (flutter/engine#39574) (flutter/flutter#120559) * 238b0dbc0 Roll Flutter Engine from b7e80ad6ef51 to 1ff345ce5f63 (2 revisions) (flutter/flutter#120574) * 3e659cf71 1eef041d4 [Impeller] Source the pipeline color attachment pixel format from RenderPass textures (flutter/engine#39556) (flutter/flutter#120576) * 53fe8a3f9 4107a7b71 Roll Skia from 615965d545f4 to c6f1de2239fb (1 revision) (flutter/engine#39581) (flutter/flutter#120580) * b0c24e8d3 fix a Slider theme update bug (flutter/flutter#120432) * b33c76f01 1695b7bbc Bump github/codeql-action from 2.1.39 to 2.2.4 (flutter/engine#39584) (flutter/flutter#120588) * ce8efb439 ede2a0a3c Roll Skia from c6f1de2239fb to d85501fa487d (1 revision) (flutter/engine#39585) (flutter/flutter#120593) * 7fb8497b5 Roll Plugins from 02571ec to f3bc6f1 (2 revisions) (flutter/flutter#120601) * 7c2d5b9c2 60c8532d6 Roll Fuchsia Mac SDK from NZAnfCkpbswhYplty... to 6hbPQq6ED0PkuQiKM... (flutter/engine#39587) (flutter/flutter#120602) * 1f268f1d6 fb8840578 Roll Dart SDK from 1caf3a9ad101 to f80c5db8736a (1 revision) (flutter/engine#39588) (flutter/flutter#120606) * 957494d9f Marks Linux_android flavors_test to be unflaky (flutter/flutter#120299) * 0792c2795 Roll Flutter Engine from fb8840578156 to df0ffe42b33e (2 revisions) (flutter/flutter#120607) * 7bacc25ee Remove accentColorBrightness usage (flutter/flutter#120577) * 98576cef5 Avoid null terminating characters in strings from Utf8FromUtf16() (flutter/flutter#109729) * 00adf9a33 roll packages (flutter/flutter#120609) * 2df140f40 Remove references to Observatory (flutter/flutter#118577) * a819d6156 Remove `prefer_equal_for_default_values` lint rule (flutter/flutter#120533) * 73afc7ba3 Roll Flutter Engine from df0ffe42b33e to 97dcf3e6201e (4 revisions) (flutter/flutter#120617) * f858302a6 Remove `brightness` from `AppBar`/`SliverAppBar`/`AppBarTheme`/`AppBarTheme.copyWith` (flutter/flutter#120575) * 95fd821ab Force `Mac build_tests` to run on x64 bots (flutter/flutter#120620) * ed35c80d2 d28cbf402 [Impeller] Return entity from filters instead of a snapshot (flutter/engine#39560) (flutter/flutter#120625) * 778b3fa32 support updating dragDecices at runtime (flutter/flutter#120336) * ddebe833b Added integration test for wide gamut support. (flutter/flutter#119657) * becb6bd00 Fix message type inconsistency between locales (flutter/flutter#120129) * f4495f5d3 Roll Flutter Engine from d28cbf402904 to 31a4648cbe99 (2 revisions) (flutter/flutter#120630) * 402caec2e Fix `ListTile`'s default `iconColor` token used & update examples (flutter/flutter#120444) * 865422da2 Force `Mac tool_integration_tests` to run on x64 bots (flutter/flutter#120634) * 07c548c69 Apply BindingBase.checkInstance to TestDefaultBinaryMessengerBinding (flutter/flutter#116937) * b08cc8be7 Roll Flutter Engine from 31a4648cbe99 to c4f51bc78644 (7 revisions) (flutter/flutter#120656) * 6a94f25a9 Roll Flutter Engine from c4f51bc78644 to 17ab09d382e3 (5 revisions) (flutter/flutter#120664) * b0edf5829 Roll Flutter Engine from 17ab09d382e3 to cbb7fc020b00 (2 revisions) (flutter/flutter#120673) * 17b4c70ff [M3] Add customizable overflow property to Snackbar's action (flutter/flutter#120394) * b35e4a54f Roll Plugins from f3bc6f1 to 9c312d4 (2 revisions) (flutter/flutter#120694) * 9fd34048f f4fcb911b Roll Skia from bb7b22f3f444 to 8de7f68a3661 (1 revision) (flutter/engine#39619) (flutter/flutter#120699) * b9b4d3e43 roll packages (flutter/flutter#120628) * ed5bd1779 Fix tree by updating dependencies (flutter/flutter#120707) * 480c54c37 Increase Linux docs_publish timeout (flutter/flutter#120718) * c102bf467 [integration_test] Fix link to integration test for web section in `README.md` (flutter/flutter#103422) * 577ad2ee8 Fix error when resetting configurations in tear down phase (flutter/flutter#114468) * 2cfca820a Force Mac plugin_test to run on x64 bots (flutter/flutter#120714) * fd2fd94e3 d86089252 Roll Fuchsia Mac SDK from OeUljRQOmJwgDhNOo... to EFcCpAxOuQllDqP0F... (flutter/engine#39621) (flutter/flutter#120702) * 9d94a51b6 Move linux-x64-flutter-gtk.zip to linux-x64-debug location. (flutter/flutter#120658) * d29668ddb Improve network resources doctor check (flutter/flutter#120417) * 378668db4 added MaterialStateColor support to TabBarTheme.labelColor (flutter/flutter#109541) * ba46cb8d5 Remove deprecated AppBar.color & AppBar.backwardsCompatibility (flutter/flutter#120618) * 5a3957f3b Revert "Fix error when resetting configurations in tear down phase" (flutter/flutter#120739) * fd01812f6 Add temporary default case to support new PointerSignalKind (flutter/flutter#120731) * 4b8ad1b00 Temporarily disable info-based analyzer unit tests. (flutter/flutter#120753) * 911b13784 Roll Flutter Engine from d860892528ff to 44e36c9c0d73 (20 revisions) (flutter/flutter#120761) * 4ae5252f8 Fix license page crash (flutter/flutter#120728) * 31c73fcfe Roll Flutter Engine from 44e36c9c0d73 to bf7d51586704 (2 revisions) (flutter/flutter#120772) * 624445a45 Roll Flutter Engine from bf7d51586704 to ec70b5aa96be (2 revisions) (flutter/flutter#120781) * df41e58f6 1328c4bc6 Roll Dart SDK from 0456c4011cb3 to c022d475e9d8 (1 revision) (flutter/engine#39646) (flutter/flutter#120784)

This reverts commit 2df140f.

This reverts commit 298d8c7.

This reverts commit fbae472.

#121555) Revert "Reland "Remove references to Observatory (#118577)""

This reverts commit 275ab9c.

Remove references to Observatory

96f68e1

Observatory is being deprecated for Dart 3.0 so it should no longer be referenced in tooling messaging / flags. See dart-lang/sdk#50233

bkonyi mentioned this pull request Jan 17, 2023

Remove references to Observatory flutter/engine#38919

Merged

christopherfujino self-requested a review January 19, 2023 21:38

christopherfujino reviewed Jan 19, 2023

View reviewed changes

packages/flutter_tools/lib/src/globals.dart Outdated Show resolved Hide resolved

christopherfujino reviewed Jan 19, 2023

View reviewed changes

packages/flutter_tools/bin/xcode_backend.dart Outdated Show resolved Hide resolved

bkonyi added 2 commits January 31, 2023 10:49

Merge remote-tracking branch 'origin' into remove_observatory_messaging

6b59ac7

Remove Observatory from regexp

55318d3

bkonyi changed the title ~~[WIP] Remove references to Observatory~~ Remove references to Observatory Jan 31, 2023

bkonyi added 5 commits January 31, 2023 10:54

Fix mDNS target

332a341

Fix merge errors

5a82825

Remove additional references to Observatory

2ba74fa

Fix tests

11f93d7

Fix tests

42008bc

jmagman reviewed Jan 31, 2023

View reviewed changes

bkonyi added 5 commits January 31, 2023 13:30

Fix daemon

279fb9b

Merge remote-tracking branch 'origin' into remove_observatory_messaging

2518d59

Removed another Observatory reference

143414a

Merge branch 'master' of github.com:flutter/flutter into remove_obser…

45ee7e1

…vatory_messaging

Merge branch 'master' of github.com:flutter/flutter into remove_obser…

ffbdd9b

…vatory_messaging

christopherfujino approved these changes Feb 7, 2023

View reviewed changes

jmagman approved these changes Feb 7, 2023

View reviewed changes

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2023

2df140f40 Remove references to Observatory (flutter/flutter#118577)

e3a4d52

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 14, 2023

2df140f40 Remove references to Observatory (flutter/flutter#118577)

e3bac5c

This was referenced Feb 14, 2023

Roll Flutter from e3471f08d1d3 to b9b4d3e43e24 (65 revisions) flutter/plugins#7180

Closed

Roll Flutter from ce8efb439e74 to b9b4d3e43e24 (28 revisions) flutter/packages#3204

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 14, 2023

2df140f40 Remove references to Observatory (flutter/flutter#118577)

e2b4828

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2023

2df140f40 Remove references to Observatory (flutter/flutter#118577)

d25d80e

This was referenced Feb 14, 2023

Roll Flutter from ce8efb439e74 to ed5bd177944c (29 revisions) flutter/packages#3205

Closed

Roll Flutter from e3471f08d1d3 to ed5bd177944c (66 revisions) flutter/plugins#7182

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2023

2df140f40 Remove references to Observatory (flutter/flutter#118577)

8df151e

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 14, 2023

2df140f40 Remove references to Observatory (flutter/flutter#118577)

466c29b

This was referenced Feb 15, 2023

Roll Flutter from e3471f08d1d3 to df41e58f6f4e (83 revisions) flutter/plugins#7184

Merged

Roll Flutter from ce8efb439e74 to df41e58f6f4e (46 revisions) flutter/packages#3207

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 15, 2023

2df140f40 Remove references to Observatory (flutter/flutter#118577)

aea3d98

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2023

2df140f40 Remove references to Observatory (flutter/flutter#118577)

35067ab

CaseyHillers mentioned this pull request Feb 17, 2023

Revert "Remove references to Observatory" #120929

Merged

CaseyHillers added a commit that referenced this pull request Feb 17, 2023

Revert "Remove references to Observatory (#118577)"

7b1c866

This reverts commit 2df140f.

itsjustkevin added a commit that referenced this pull request Feb 17, 2023

Revert "Remove references to Observatory (#118577)" (#120933)

09f4a69

This reverts commit 2df140f.

CaseyHillers pushed a commit that referenced this pull request Feb 17, 2023

Revert "Remove references to Observatory (#118577)" (#120929)

298d8c7

This reverts commit 2df140f.

bkonyi added a commit that referenced this pull request Feb 22, 2023

Reland "Remove references to Observatory (#118577)"

4dad8f5

This reverts commit 298d8c7.

bkonyi added a commit that referenced this pull request Feb 27, 2023

Reland "Remove references to Observatory (#118577)" (#121215)

fbae472

This reverts commit 298d8c7.

goderbauer added a commit that referenced this pull request Feb 27, 2023

Revert "Reland "Remove references to Observatory (#118577)" (#121215)"

26f9f22

This reverts commit fbae472.

auto-submit bot pushed a commit that referenced this pull request Feb 27, 2023

Revert "Reland "Remove references to Observatory (#118577)" (#121215)" (

275ab9c

#121555) Revert "Reland "Remove references to Observatory (#118577)""

bkonyi added a commit that referenced this pull request Feb 28, 2023

Reland "Remove references to Observatory (#118577)"

5522355

This reverts commit 275ab9c.

bkonyi added a commit that referenced this pull request Feb 28, 2023

Reland "Remove references to Observatory (#118577)" (#121606)

ecd7518

This reverts commit 275ab9c.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023

2df140f40 Remove references to Observatory (flutter/flutter#118577)

4ef518d

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023

2df140f40 Remove references to Observatory (flutter/flutter#118577)

c59b0c1

parlough mentioned this pull request May 29, 2024

Consider no longer printing Observatory Url in flutter run #89189

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove references to Observatory #118577

Remove references to Observatory #118577

bkonyi commented Jan 16, 2023

christopherfujino commented Jan 19, 2023 •

edited

Loading

jmagman Jan 31, 2023

jmagman Jan 31, 2023

bkonyi Jan 31, 2023

christopherfujino Jan 31, 2023

jmagman Jan 31, 2023

jmagman Jan 31, 2023

bkonyi Feb 2, 2023

jmagman Feb 27, 2023

jmagman Jan 31, 2023

christopherfujino Jan 31, 2023

jmagman commented Jan 31, 2023

bkonyi commented Jan 31, 2023

bkonyi commented Feb 7, 2023

christopherfujino left a comment

jmagman left a comment

	if (boolArgDeprecated('tree-shake-icons')) {
	throwToolExit('The "--tree-shake-icons" flag is deprecated for "build bundle" and will be removed in a future version of Flutter.');
	}

Remove references to Observatory #118577

Remove references to Observatory #118577

Conversation

bkonyi commented Jan 16, 2023

christopherfujino commented Jan 19, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jmagman commented Jan 31, 2023

bkonyi commented Jan 31, 2023

bkonyi commented Feb 7, 2023

christopherfujino left a comment

Choose a reason for hiding this comment

jmagman left a comment

Choose a reason for hiding this comment

christopherfujino commented Jan 19, 2023 •

edited

Loading