Add Windows unit tests to plugin template #118638

stuartmorgan · 2023-01-17T20:38:52Z

Adds an example native unit test to the plugin template for Windows, matching the format we use for our 1P plugin example app unit tests. Once these have been added for all platforms+languages, they will be documented on a new plugin development page to explain their use.

Since we don't appear to be running our current plugin e2e tests for Windows, this adds a new configuration to run them. I haven't led-tested this, so it may not work, but this will give a starting point for getting them running.

Part of #82458

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

Adds an example native unit test to the plugin template for Windows, matching the format we use for our 1P plugin example app unit tests. Once these have been added for all platforms+languages, they will be documented on a new plugin development page to explain their use. Since we don't appear to be running our current plugin e2e tests for Windows, this adds a new configuration to run them. I haven't `led`-tested this, so it may not work, but this will give a starting point for getting them running. Part of flutter#82458

stuartmorgan · 2023-01-17T20:41:14Z

packages/flutter_tools/templates/plugin/windows.tmpl/pluginClassSnakeCase.h.tmpl

@@ -20,7 +20,6 @@ class {{pluginClass}} : public flutter::Plugin {
  {{pluginClass}}(const {{pluginClass}}&) = delete;
  {{pluginClass}}& operator=(const {{pluginClass}}&) = delete;

- private:


This makes HandleMethodCall public, for the purposes of testing. We could use a friend, but that requires a test fixture, thus making the tests more complicated, and I don't see any real downside to this being public since the class itself isn't actually exposed to anything in normal use. (And on macOS/iOS, this corresponding method is a public method on the FlutterPlugin interface, so it's public for all plugins on those platforms.)

cbracken

cbracken

cbracken · 2023-01-24T18:20:30Z

packages/flutter_tools/test/commands.shard/permeable/create_test.dart

@@ -2486,7 +2486,7 @@ void main() {
      'create',
      '--no-pub',
      '--template=plugin',
-      '--platforms=widows',
+      '--platforms=windows',


Maybe this was is in reference to to untimely demise of UWP?

…118638)

…8638)

* 373523184 Cleanup old Dart SDK layout compatibility (flutter/flutter#118819) * 4d250302a Add leak_tracker as dev_dependency. (flutter/flutter#118952) * e3c51a2f2 Add Windows unit tests to plugin template (flutter/flutter#118638) * d20dd9e4b Roll Flutter Engine from 7d3233d26d09 to 71ee5f19bc16 (15 revisions) (flutter/flutter#119081) * 5dabe102a Fix path name to discover debug apk on add2app builds (flutter/flutter#117999) * 50ed8a34b Enable `unnecessary_null_comparison` check (flutter/flutter#118849) * 455e6aca5 Test integration test apps' runner files against current template app (flutter/flutter#118646) * a788e1b31 Roll Flutter Engine from 71ee5f19bc16 to 59ea78bfabda (2 revisions) (flutter/flutter#119087) * c35370cf0 Roll Flutter Engine from 59ea78bfabda to 2499a5d9fca7 (2 revisions) (flutter/flutter#119089) * 2f0dd5673 Refactor highlight handling in FocusManager (flutter/flutter#119075) * 2759f3f0b Roll Flutter Engine from 2499a5d9fca7 to d98926c32ee7 (2 revisions) (flutter/flutter#119090) * 760fb2115 Roll Flutter Engine from d98926c32ee7 to bec40654a5d7 (2 revisions) (flutter/flutter#119093) * bbca694ef Roll Flutter Engine from bec40654a5d7 to 5405f2c26e85 (2 revisions) (flutter/flutter#119095) * 6414c3604 f1464b49c Manually roll ANGLE, vulkan-deps, SwiftShader (flutter/engine#38650) (flutter/flutter#119097) * 426cdd90c 55bb8deaf [Impeller] Linear sample atlas glyphs when the CTM isn't translation/scale only (flutter/engine#39112) (flutter/flutter#119098) * 83c3a61e3 Only emit image painting events in debug & profile modes. (flutter/flutter#118872) * b113df2dc bffb98352 Roll Skia from b72fececbdcc to 8ffd5c20d634 (3 revisions) (flutter/engine#39114) (flutter/flutter#119099) * 351466aea Add Decoding Flutter videos to API docs (flutter/flutter#116454) * 318f8758b Pass through magnifierConfiguration (flutter/flutter#118270) * eced23eab d39ab638b Roll Fuchsia Mac SDK from MUvFS0baOnigVUIND... to _H53AyDxR9Pm2TbwN... (flutter/engine#39122) (flutter/flutter#119126) * 29ab437e2 Add Material 3 `CheckboxListTile` example and update existing examples (flutter/flutter#118792) * a815ee634 8efc7183b Roll Skia from 8ffd5c20d634 to da5034f9d117 (4 revisions) (flutter/engine#39123) (flutter/flutter#119129)

* 3735231 Cleanup old Dart SDK layout compatibility (flutter/flutter#118819) * 4d25030 Add leak_tracker as dev_dependency. (flutter/flutter#118952) * e3c51a2 Add Windows unit tests to plugin template (flutter/flutter#118638) * d20dd9e Roll Flutter Engine from 7d3233d26d09 to 71ee5f19bc16 (15 revisions) (flutter/flutter#119081) * 5dabe10 Fix path name to discover debug apk on add2app builds (flutter/flutter#117999) * 50ed8a3 Enable `unnecessary_null_comparison` check (flutter/flutter#118849) * 455e6ac Test integration test apps' runner files against current template app (flutter/flutter#118646) * a788e1b Roll Flutter Engine from 71ee5f19bc16 to 59ea78bfabda (2 revisions) (flutter/flutter#119087) * c35370c Roll Flutter Engine from 59ea78bfabda to 2499a5d9fca7 (2 revisions) (flutter/flutter#119089) * 2f0dd56 Refactor highlight handling in FocusManager (flutter/flutter#119075) * 2759f3f Roll Flutter Engine from 2499a5d9fca7 to d98926c32ee7 (2 revisions) (flutter/flutter#119090) * 760fb21 Roll Flutter Engine from d98926c32ee7 to bec40654a5d7 (2 revisions) (flutter/flutter#119093) * bbca694 Roll Flutter Engine from bec40654a5d7 to 5405f2c26e85 (2 revisions) (flutter/flutter#119095) * 6414c36 f1464b49c Manually roll ANGLE, vulkan-deps, SwiftShader (flutter/engine#38650) (flutter/flutter#119097) * 426cdd9 55bb8deaf [Impeller] Linear sample atlas glyphs when the CTM isn't translation/scale only (flutter/engine#39112) (flutter/flutter#119098) * 83c3a61 Only emit image painting events in debug & profile modes. (flutter/flutter#118872) * b113df2 bffb98352 Roll Skia from b72fececbdcc to 8ffd5c20d634 (3 revisions) (flutter/engine#39114) (flutter/flutter#119099) * 351466a Add Decoding Flutter videos to API docs (flutter/flutter#116454) * 318f875 Pass through magnifierConfiguration (flutter/flutter#118270) * eced23e d39ab638b Roll Fuchsia Mac SDK from MUvFS0baOnigVUIND... to _H53AyDxR9Pm2TbwN... (flutter/engine#39122) (flutter/flutter#119126) * 29ab437 Add Material 3 `CheckboxListTile` example and update existing examples (flutter/flutter#118792) * a815ee6 8efc7183b Roll Skia from 8ffd5c20d634 to da5034f9d117 (4 revisions) (flutter/engine#39123) (flutter/flutter#119129)

…r#3089) * 373523184 Cleanup old Dart SDK layout compatibility (flutter/flutter#118819) * 4d250302a Add leak_tracker as dev_dependency. (flutter/flutter#118952) * e3c51a2f2 Add Windows unit tests to plugin template (flutter/flutter#118638) * d20dd9e4b Roll Flutter Engine from 7d3233d26d09 to 71ee5f19bc16 (15 revisions) (flutter/flutter#119081) * 5dabe102a Fix path name to discover debug apk on add2app builds (flutter/flutter#117999) * 50ed8a34b Enable `unnecessary_null_comparison` check (flutter/flutter#118849) * 455e6aca5 Test integration test apps' runner files against current template app (flutter/flutter#118646) * a788e1b31 Roll Flutter Engine from 71ee5f19bc16 to 59ea78bfabda (2 revisions) (flutter/flutter#119087) * c35370cf0 Roll Flutter Engine from 59ea78bfabda to 2499a5d9fca7 (2 revisions) (flutter/flutter#119089) * 2f0dd5673 Refactor highlight handling in FocusManager (flutter/flutter#119075) * 2759f3f0b Roll Flutter Engine from 2499a5d9fca7 to d98926c32ee7 (2 revisions) (flutter/flutter#119090) * 760fb2115 Roll Flutter Engine from d98926c32ee7 to bec40654a5d7 (2 revisions) (flutter/flutter#119093) * bbca694ef Roll Flutter Engine from bec40654a5d7 to 5405f2c26e85 (2 revisions) (flutter/flutter#119095) * 6414c3604 f1464b49c Manually roll ANGLE, vulkan-deps, SwiftShader (flutter/engine#38650) (flutter/flutter#119097) * 426cdd90c 55bb8deaf [Impeller] Linear sample atlas glyphs when the CTM isn't translation/scale only (flutter/engine#39112) (flutter/flutter#119098) * 83c3a61e3 Only emit image painting events in debug & profile modes. (flutter/flutter#118872) * b113df2dc bffb98352 Roll Skia from b72fececbdcc to 8ffd5c20d634 (3 revisions) (flutter/engine#39114) (flutter/flutter#119099) * 351466aea Add Decoding Flutter videos to API docs (flutter/flutter#116454) * 318f8758b Pass through magnifierConfiguration (flutter/flutter#118270) * eced23eab d39ab638b Roll Fuchsia Mac SDK from MUvFS0baOnigVUIND... to _H53AyDxR9Pm2TbwN... (flutter/engine#39122) (flutter/flutter#119126) * 29ab437e2 Add Material 3 `CheckboxListTile` example and update existing examples (flutter/flutter#118792) * a815ee634 8efc7183b Roll Skia from 8ffd5c20d634 to da5034f9d117 (4 revisions) (flutter/engine#39123) (flutter/flutter#119129)

stuartmorgan requested a review from cbracken January 17, 2023 20:38

stuartmorgan requested a review from keyonghan as a code owner January 17, 2023 20:38

flutter-dashboard bot added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Jan 17, 2023

stuartmorgan commented Jan 17, 2023

View reviewed changes

Minor fix

75242f0

cbracken approved these changes Jan 19, 2023

View reviewed changes

stuartmorgan added 4 commits January 22, 2023 18:32

Add test owner

5261866

Fix typo

cd5000b

Merge branch 'main' into plugin-template-tests-windows

b52cf8e

Fix test feature flag

e6afc6c

cbracken approved these changes Jan 24, 2023

View reviewed changes

stuartmorgan added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 24, 2023

auto-submit bot merged commit e3c51a2 into flutter:master Jan 24, 2023

stuartmorgan deleted the plugin-template-tests-windows branch January 24, 2023 18:24

This was referenced Jan 25, 2023

Roll Flutter from c35efdaa6854 to a815ee634202 (22 revisions) flutter/packages#3089

Merged

Roll Flutter from c35efdaa6854 to a815ee634202 (22 revisions) flutter/plugins#7025

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 25, 2023

e3c51a2f2 Add Windows unit tests to plugin template (flutter/flutter#…

adf4ebc

…118638)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 25, 2023

e3c51a2 Add Windows unit tests to plugin template (flutter/flutter#11…

40a3f78

…8638)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Windows unit tests to plugin template #118638

Add Windows unit tests to plugin template #118638

stuartmorgan commented Jan 17, 2023

stuartmorgan Jan 17, 2023

cbracken left a comment

cbracken left a comment

cbracken Jan 24, 2023

Add Windows unit tests to plugin template #118638

Add Windows unit tests to plugin template #118638

Conversation

stuartmorgan commented Jan 17, 2023

Pre-launch Checklist

stuartmorgan Jan 17, 2023

Choose a reason for hiding this comment

cbracken left a comment

Choose a reason for hiding this comment

cbracken left a comment

Choose a reason for hiding this comment

cbracken Jan 24, 2023

Choose a reason for hiding this comment