Remove unnecessary null checks in flutter/{foundation,services,physics}
#118910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: text input
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
goderbauer
changed the title
flutter/{foundation,services}flutter/{foundation,services,physics}
cbracken
reviewed
Jan 23, 2023
goderbauer
added
the
autosubmit
This was referenced Jan 24, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 24, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Jan 24, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jan 24, 2023
* 3bf79607d [web] Fix paths fetched by flutter.js (flutter/flutter#118684) * e71e8daa2 76998e529 Roll Fuchsia Linux SDK from f613tOkDB282hW2tA... to GLRbnjiO5SbZKX-Us... (flutter/engine#39067) (flutter/flutter#119009) * 71a42563d Revert "[Re-land] Button padding m3 (#118640)" (flutter/flutter#118962) * 90ffb1c65 94fc0728f Roll Dart SDK from c52810968747 to 107a1280a61f (1 revision) (flutter/engine#39069) (flutter/flutter#119010) * 224e6aa18 Remove unnecessary null checks in flutter/gestures (flutter/flutter#118926) * 6cd494554 Remove unnecessary null checks in flutter_web_plugins (flutter/flutter#118862) * a63e19ba0 Remove unnecessary null checks in flutter_localizations (flutter/flutter#118863) * 19dfde698 Remove unnecessary null checks in `flutter/{foundation,services,physics}` (flutter/flutter#118910) * 392dffeb0 Update the Linux Android defines test to use dimensions when selecting a build bot (flutter/flutter#118930) * 5e50ed972 Test Utf8FromUtf16 (flutter/flutter#118647) * edb571e49 Update README.md (flutter/flutter#118803) * 38630b6bd Remove unnecessary null checks in `flutter_tool` (flutter/flutter#118857) * 332aed9c8 Revert "Update the Linux Android defines test to use dimensions when selecting a build bot (#118930)" (flutter/flutter#119023) * 84071aa2a Add todo for linux defines test. (flutter/flutter#119035) * e8b7f4b20 [examples] Fix typo in `refresh_indicator` example (flutter/flutter#119000) * df4420835 Remove ThemeData.buttonColor references (flutter/flutter#118658) * 65486163a Remove animated_complex_opacity_perf_macos__e2e_summary bringup (flutter/flutter#118916) * 59767e5fc Remove unnecessary null checks in `flutter/material` (flutter/flutter#119022) * 1906ce5d4 7d3233d26 [web] Build multiple CanvasKit variants (using toolchain_args) (flutter/engine#38448) (flutter/flutter#119021) * 720bea026 Remove unnecessary null checks in `flutter/widgets` (flutter/flutter#119028) * 0de8bef74 Remove unnecessary null checks in flutter/cupertino (flutter/flutter#119020) * 2e8dd9dd6 Run integration_ui_test_test_macos in prod (flutter/flutter#118919) * 64b4c69bc roll pub deps and remove archive, crypto, typed_data from allow-list (flutter/flutter#119018) * c35efdaa6 Remove superfluous words. (flutter/flutter#119008)
auto-submit bot
pushed a commit
to flutter/plugins
that referenced
this pull request
Jan 24, 2023
* 3bf7960 [web] Fix paths fetched by flutter.js (flutter/flutter#118684) * e71e8da 76998e529 Roll Fuchsia Linux SDK from f613tOkDB282hW2tA... to GLRbnjiO5SbZKX-Us... (flutter/engine#39067) (flutter/flutter#119009) * 71a4256 Revert "[Re-land] Button padding m3 (#118640)" (flutter/flutter#118962) * 90ffb1c 94fc0728f Roll Dart SDK from c52810968747 to 107a1280a61f (1 revision) (flutter/engine#39069) (flutter/flutter#119010) * 224e6aa Remove unnecessary null checks in flutter/gestures (flutter/flutter#118926) * 6cd4945 Remove unnecessary null checks in flutter_web_plugins (flutter/flutter#118862) * a63e19b Remove unnecessary null checks in flutter_localizations (flutter/flutter#118863) * 19dfde6 Remove unnecessary null checks in `flutter/{foundation,services,physics}` (flutter/flutter#118910) * 392dffe Update the Linux Android defines test to use dimensions when selecting a build bot (flutter/flutter#118930) * 5e50ed9 Test Utf8FromUtf16 (flutter/flutter#118647) * edb571e Update README.md (flutter/flutter#118803) * 38630b6 Remove unnecessary null checks in `flutter_tool` (flutter/flutter#118857) * 332aed9 Revert "Update the Linux Android defines test to use dimensions when selecting a build bot (#118930)" (flutter/flutter#119023) * 84071aa Add todo for linux defines test. (flutter/flutter#119035) * e8b7f4b [examples] Fix typo in `refresh_indicator` example (flutter/flutter#119000) * df44208 Remove ThemeData.buttonColor references (flutter/flutter#118658) * 6548616 Remove animated_complex_opacity_perf_macos__e2e_summary bringup (flutter/flutter#118916) * 59767e5 Remove unnecessary null checks in `flutter/material` (flutter/flutter#119022) * 1906ce5 7d3233d26 [web] Build multiple CanvasKit variants (using toolchain_args) (flutter/engine#38448) (flutter/flutter#119021) * 720bea0 Remove unnecessary null checks in `flutter/widgets` (flutter/flutter#119028) * 0de8bef Remove unnecessary null checks in flutter/cupertino (flutter/flutter#119020) * 2e8dd9d Run integration_ui_test_test_macos in prod (flutter/flutter#118919) * 64b4c69 roll pub deps and remove archive, crypto, typed_data from allow-list (flutter/flutter#119018) * c35efda Remove superfluous words. (flutter/flutter#119008)
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
* 3bf7960 [web] Fix paths fetched by flutter.js (flutter/flutter#118684) * e71e8da 76998e529 Roll Fuchsia Linux SDK from f613tOkDB282hW2tA... to GLRbnjiO5SbZKX-Us... (flutter/engine#39067) (flutter/flutter#119009) * 71a4256 Revert "[Re-land] Button padding m3 (#118640)" (flutter/flutter#118962) * 90ffb1c 94fc0728f Roll Dart SDK from c52810968747 to 107a1280a61f (1 revision) (flutter/engine#39069) (flutter/flutter#119010) * 224e6aa Remove unnecessary null checks in flutter/gestures (flutter/flutter#118926) * 6cd4945 Remove unnecessary null checks in flutter_web_plugins (flutter/flutter#118862) * a63e19b Remove unnecessary null checks in flutter_localizations (flutter/flutter#118863) * 19dfde6 Remove unnecessary null checks in `flutter/{foundation,services,physics}` (flutter/flutter#118910) * 392dffe Update the Linux Android defines test to use dimensions when selecting a build bot (flutter/flutter#118930) * 5e50ed9 Test Utf8FromUtf16 (flutter/flutter#118647) * edb571e Update README.md (flutter/flutter#118803) * 38630b6 Remove unnecessary null checks in `flutter_tool` (flutter/flutter#118857) * 332aed9 Revert "Update the Linux Android defines test to use dimensions when selecting a build bot (#118930)" (flutter/flutter#119023) * 84071aa Add todo for linux defines test. (flutter/flutter#119035) * e8b7f4b [examples] Fix typo in `refresh_indicator` example (flutter/flutter#119000) * df44208 Remove ThemeData.buttonColor references (flutter/flutter#118658) * 6548616 Remove animated_complex_opacity_perf_macos__e2e_summary bringup (flutter/flutter#118916) * 59767e5 Remove unnecessary null checks in `flutter/material` (flutter/flutter#119022) * 1906ce5 7d3233d26 [web] Build multiple CanvasKit variants (using toolchain_args) (flutter/engine#38448) (flutter/flutter#119021) * 720bea0 Remove unnecessary null checks in `flutter/widgets` (flutter/flutter#119028) * 0de8bef Remove unnecessary null checks in flutter/cupertino (flutter/flutter#119020) * 2e8dd9d Run integration_ui_test_test_macos in prod (flutter/flutter#118919) * 64b4c69 roll pub deps and remove archive, crypto, typed_data from allow-list (flutter/flutter#119018) * c35efda Remove superfluous words. (flutter/flutter#119008)
Maatteogekko
pushed a commit
to Maatteogekko/packages
that referenced
this pull request
Feb 4, 2023
…r#3085) * 3bf79607d [web] Fix paths fetched by flutter.js (flutter/flutter#118684) * e71e8daa2 76998e529 Roll Fuchsia Linux SDK from f613tOkDB282hW2tA... to GLRbnjiO5SbZKX-Us... (flutter/engine#39067) (flutter/flutter#119009) * 71a42563d Revert "[Re-land] Button padding m3 (#118640)" (flutter/flutter#118962) * 90ffb1c65 94fc0728f Roll Dart SDK from c52810968747 to 107a1280a61f (1 revision) (flutter/engine#39069) (flutter/flutter#119010) * 224e6aa18 Remove unnecessary null checks in flutter/gestures (flutter/flutter#118926) * 6cd494554 Remove unnecessary null checks in flutter_web_plugins (flutter/flutter#118862) * a63e19ba0 Remove unnecessary null checks in flutter_localizations (flutter/flutter#118863) * 19dfde698 Remove unnecessary null checks in `flutter/{foundation,services,physics}` (flutter/flutter#118910) * 392dffeb0 Update the Linux Android defines test to use dimensions when selecting a build bot (flutter/flutter#118930) * 5e50ed972 Test Utf8FromUtf16 (flutter/flutter#118647) * edb571e49 Update README.md (flutter/flutter#118803) * 38630b6bd Remove unnecessary null checks in `flutter_tool` (flutter/flutter#118857) * 332aed9c8 Revert "Update the Linux Android defines test to use dimensions when selecting a build bot (#118930)" (flutter/flutter#119023) * 84071aa2a Add todo for linux defines test. (flutter/flutter#119035) * e8b7f4b20 [examples] Fix typo in `refresh_indicator` example (flutter/flutter#119000) * df4420835 Remove ThemeData.buttonColor references (flutter/flutter#118658) * 65486163a Remove animated_complex_opacity_perf_macos__e2e_summary bringup (flutter/flutter#118916) * 59767e5fc Remove unnecessary null checks in `flutter/material` (flutter/flutter#119022) * 1906ce5d4 7d3233d26 [web] Build multiple CanvasKit variants (using toolchain_args) (flutter/engine#38448) (flutter/flutter#119021) * 720bea026 Remove unnecessary null checks in `flutter/widgets` (flutter/flutter#119028) * 0de8bef74 Remove unnecessary null checks in flutter/cupertino (flutter/flutter#119020) * 2e8dd9dd6 Run integration_ui_test_test_macos in prod (flutter/flutter#118919) * 64b4c69bc roll pub deps and remove archive, crypto, typed_data from allow-list (flutter/flutter#119018) * c35efdaa6 Remove superfluous words. (flutter/flutter#119008)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #118837.
Dart 3 drops support for non-null safe code, so we can finally turn on the unnecessary_null_comparison lint and remove the unnecessary checks it flags.