Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary parens #119736

Merged
merged 1 commit into from Feb 1, 2023
Merged

remove unnecessary parens #119736

merged 1 commit into from Feb 1, 2023

Conversation

pq
Copy link
Contributor

@pq pq commented Feb 1, 2023 •
edited

Fix unnecessary parens before they get flagged by an incoming linter.

See try-failure: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8790348913643501601/+/u/analyze_flutter_flutter/stdout

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Feb 1, 2023
@Hixie
Copy link
Contributor

Hixie commented Feb 1, 2023

test-exempt: code refactor with no semantic change

@pq pq requested a review from goderbauer February 1, 2023 19:11
goderbauer
goderbauer approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

As always: Thank you so much for the clean-up.

@pq pq added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 1, 2023
@auto-submit auto-submit bot merged commit 5613ab0 into flutter:master Feb 1, 2023
This was referenced Feb 2, 2023
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2023
@engine-flutter-autoroll
5613ab010 remove unnecessary parens (flutter/flutter#119736)
570b00f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 2, 2023
@engine-flutter-autoroll
5613ab0 remove unnecessary parens (flutter/flutter#119736)
13ceb80
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2023
@engine-flutter-autoroll
5613ab010 remove unnecessary parens (flutter/flutter#119736)
8a5ad65
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2023
@engine-flutter-autoroll
5613ab010 remove unnecessary parens (flutter/flutter#119736)
4b07d40
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2023
@engine-flutter-autoroll
5613ab010 remove unnecessary parens (flutter/flutter#119736)
969bc7b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 2, 2023
@engine-flutter-autoroll
5613ab0 remove unnecessary parens (flutter/flutter#119736)
7616789
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2023
@engine-flutter-autoroll
5613ab010 remove unnecessary parens (flutter/flutter#119736)
f58fb62
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 2, 2023
@engine-flutter-autoroll
5613ab0 remove unnecessary parens (flutter/flutter#119736)
dbe7726
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2023
@engine-flutter-autoroll
5613ab010 remove unnecessary parens (flutter/flutter#119736)
44222d0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2023
@engine-flutter-autoroll
5613ab010 remove unnecessary parens (flutter/flutter#119736)
bfbfe80
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2023
@engine-flutter-autoroll
5613ab010 remove unnecessary parens (flutter/flutter#119736)
21e504d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 2, 2023
@engine-flutter-autoroll
5613ab0 remove unnecessary parens (flutter/flutter#119736)
c5b994a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 2, 2023
@engine-flutter-autoroll
5613ab0 remove unnecessary parens (flutter/flutter#119736)
4769b02
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 3, 2023
@engine-flutter-autoroll
5613ab0 remove unnecessary parens (flutter/flutter#119736)
4014718
auto-submit bot pushed a commit to flutter/plugins that referenced this pull request Feb 3, 2023
@engine-flutter-autoroll
Roll Flutter from d278808 to c5e8757 (54 revisions) (#7092)
a59517a 
* 254a796 Revert "Reland "Add --serve-observatory flag to run, attach, and test (#118402)" (#119529)" (flutter/flutter#119729)

* 1573c12 Marks Mac_android microbenchmarks to be unflaky (flutter/flutter#119727)

* 5613ab0 remove unnecessary parens (flutter/flutter#119736)

* 1305a50 Roll Flutter Engine from c08a286d60e9 to ba3adb74d952 (5 revisions) (flutter/flutter#119741)

* 484d881 [conductor] update console link (flutter/flutter#118338)

* 73124dc Fix `ListTileThemeData.copyWith` doesn't override correct properties (flutter/flutter#119738)

* bc8927c 2b8dd4e5c Use Windows high contrast black/white theme with `MaterialApp` themes (flutter/engine#39206) (flutter/flutter#119747)

* 578edfc Catch errors thrown while handling pointer events (flutter/flutter#119577)

* 8fd5d4e Remove deprecated SystemNavigator.routeUpdated method (flutter/flutter#119187)

* 7a926dc Deprecate MediaQuery[Data].fromWindow (flutter/flutter#119647)

* cd118da Update a test expectation that depended on an SkParagraph fix (flutter/flutter#119756)

* 4ae2d3b 🔥 Do not format the messages file for `gen-l10n` (flutter/flutter#119596)

* 8f5949e Roll Flutter Engine from 2b8dd4e5c699 to a12d102773dd (2 revisions) (flutter/flutter#119758)

* 4c99da6 Avoid printing blank lines between "Another exception was thrown:" messages. (flutter/flutter#119587)

* 2ecf4ae Update the counter app to enable Material 3 (flutter/flutter#118835)

* 0b8486d 29d09845f Roll Dart SDK from b47964e5d575 to 1c219a91e637 (1 revision) (flutter/engine#39324) (flutter/flutter#119763)

* ca7b7e3 Roll Flutter Engine from 29d09845f21e to 97d27ff59459 (2 revisions) (flutter/flutter#119765)

* 475fc4a Run Mac hostonly tests on any available arch (flutter/flutter#119762)

* 322d10e 18118e10a Add iOS spring animation objc files (flutter/engine#38801) (flutter/flutter#119768)

* f767f86 check if directory exists before listing content (flutter/flutter#119748)

* 34730c7 Revert "Run Mac hostonly tests on any available arch (#119762)" (flutter/flutter#119784)

* f9daa9a Roll Flutter Engine from 18118e10a0a5 to 679c4b42e222 (4 revisions) (flutter/flutter#119783)

* fd76ef0 Reland "Add API for discovering assets" (flutter/flutter#119277)

* ca0596e Fix `pub get --unknown-flag` (flutter/flutter#119622)

* 9abb6d7 Roll Plugins from 9da327c to 9302d87 (11 revisions) (flutter/flutter#119825)

* 9eafbcc Roll Flutter Engine from 679c4b42e222 to 388890a98e5b (6 revisions) (flutter/flutter#119830)

* 1ee8799 Revert "[Re-land] Exposed tooltip longPress (#118796)" (flutter/flutter#119832)

* 07b51a0 Add missing variants and *new* indicators to `useMaterial3` docs (flutter/flutter#119799)

* 201380a e9e601c7c [web] Hide autofill overlay (flutter/engine#39294) (flutter/flutter#119833)

* 1c0065c 27f55219d Roll Fuchsia Linux SDK from QxkjqmRgowkk_n2NZ... to pWloCaRzjLEAUvQEz... (flutter/engine#39339) (flutter/flutter#119838)

* e7d934a Marks Linux_android android_choreographer_do_frame_test to be flaky (flutter/flutter#119721)

* 3f986e4 Roll Flutter Engine from 27f55219df79 to ae38c9585a61 (2 revisions) (flutter/flutter#119840)

* b0f1714 Make Flex,Row,Column const for real (flutter/flutter#119673)

* d4b6898 [web] Put all index.html operations in one place (flutter/flutter#118188)

* d63987f Parser machine logs (flutter/flutter#118707)

* 22bbdf0 Android defines target update (flutter/flutter#119766)

* 8387c23 [flutter_tools] Use base DAP detach and ensure correct output (flutter/flutter#119076)

* d820aec Manual pub roll with dwds fix (flutter/flutter#119575)

* 72f9cf5 Roll Flutter Engine from ae38c9585a61 to 616ecd8be3de (3 revisions) (flutter/flutter#119859)

* cfdc358 roll packages (flutter/flutter#119865)

* d875899 Bump test Chrome version for Mac arm support (flutter/flutter#119773)

* 9b86a48 Fix gets removedItem instead of its index (flutter/flutter#119638)

* 66b2ca6 Roll Flutter Engine from 616ecd8be3de to 2871970337df (3 revisions) (flutter/flutter#119870)

* c626460 Make `_focusDebug` not interpolate in debug mode (flutter/flutter#119680)

* a27802e flutter_tool: remove explicit length header in HTTP response (flutter/flutter#119869)

* 3570cce Remove deprecated kind in GestureRecognizer et al (flutter/flutter#119572)

* bc45b18 2696fff87 Roll Skia from c2d81db3ef41 to 4f0166baf5a4 (13 revisions) (flutter/engine#39348) (flutter/flutter#119879)

* f3effce Roll Flutter Engine from 2696fff8716d to e3fe6dade964 (3 revisions) (flutter/flutter#119892)

* 69421c1 [framework] use shader tiling instead of repeated calls to drawImage (flutter/flutter#119495)

* 6b83eff Roll Flutter Engine from e3fe6dade964 to 655530e3fd15 (5 revisions) (flutter/flutter#119905)

* a5d8a4a 67d35267c [Impeller] Use minimal coverage for stencil restores after overdraw prevention (flutter/engine#39358) (flutter/flutter#119910)

* fc8ea56 0fb48ce5b Roll Dart SDK from 69452c5012d9 to be795cc64bd7 (1 revision) (flutter/engine#39360) (flutter/flutter#119926)

* e0b2138 Dispose OverlayEntry in TooltipState. (flutter/flutter#117291)

* c5e8757 Add M3 support for iconbuttons in error state in TextFields (flutter/flutter#119925)
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Feb 7, 2023
@pq
linter 1.33.0 rc
ad2da86 
Some notes.

* There are a number of tests that should get decoupled from the linter being pulled into `DEPS`.  Instead of depending on the state of lints there, we should update the tests instead to use a more hermetic environment.  (See for example `options_rule_validator_test.dart` for how that might look.)


Downstream (blocking) fixes:

* flutter/flutter#119736
* flutter/gallery#878


Change-Id: I5671b0abde3eeda75513abaaf9fef3bcd5115f9b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280054
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pq @Hixie @goderbauer