Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP] 🔥 Do not format the messages file for gen-l10n (#119596) #119770

Closed

Conversation

AlexV525
Copy link
Member

@AlexV525 AlexV525 commented Feb 2, 2023

(cherry picked from commit 4ae2d3b)

The stable branch does not have #115502 so the change is slightly different from the original.

The request might be held until #119679 has landed.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 2, 2023
@AlexV525 AlexV525 changed the title 🔥 Do not format the messages file for gen-l10n (#119596) [CP] 🔥 Do not format the messages file for gen-l10n (#119596) Feb 2, 2023
@AlexV525 AlexV525 marked this pull request as ready for review February 4, 2023 05:24
@godofredoc
Copy link
Contributor

@AlexV525 can you please help us with a rebase?

@thkim1011
Copy link
Contributor

Closing as the consensus was that there's currently a workaround to this issue by disabling the format flag, so we should rather wait for this to land in the next release. cc @christopherfujino

@thkim1011 thkim1011 closed this Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants