Provide default constraints for M3 bottom sheets #120065

guidezpl · 2023-02-06T08:26:03Z

This PR constrains M3 bottom sheets to 640dp max width by default. constraints can be used to provide different minWidth and maxWidth.

This is not a breaking change per the breaking change policy.

Part of #118619
Part of #111448

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…sheets

esouthren · 2023-02-06T17:30:49Z

dev/tools/gen_defaults/lib/bottom_sheet_template.dart

@@ -24,6 +24,9 @@ class _${blockName}DefaultsM3 extends BottomSheetThemeData {

  @override
  Color? get surfaceTintColor => ${componentColor("md.comp.sheet.bottom.docked.container.surface-tint-layer")};
+
+  @override
+  BoxConstraints? get constraints => const BoxConstraints(maxWidth: 640.0);


Should we talk to the Tokens team about tokenizing this, since the value appears in the spec (https://m3.material.io/components/bottom-sheets/specs#3b256f38-c4fd-44e5-ba46-c5858b626ec7)?

We talked last year about it (b/254925602) but all they're considering for now is spacing.

Ideally, everything would be a token!

esouthren

LGTM

hangyujin

LGTM

…sheets

…lutter#120065)

Constrain m3 bottom sheets to 640dp width by default

d0ddecf

flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. labels Feb 6, 2023

Merge remote-tracking branch 'upstream/master' into constrain-bottom-…

86278b7

…sheets

guidezpl marked this pull request as ready for review February 6, 2023 15:23

guidezpl requested review from hangyujin and esouthren February 6, 2023 15:24

Merge remote-tracking branch 'upstream/master' into constrain-bottom-…

7749b4a

…sheets

guidezpl linked an issue Feb 6, 2023 that may be closed by this pull request

Add missing m3 max width/height constraints #118619

Open

2 tasks

esouthren reviewed Feb 6, 2023

View reviewed changes

esouthren approved these changes Feb 6, 2023

View reviewed changes

hangyujin approved these changes Feb 7, 2023

View reviewed changes

guidezpl added 7 commits February 8, 2023 13:23

Merge remote-tracking branch 'upstream/master' into constrain-bottom-…

f19bad0

…sheets

Merge remote-tracking branch 'upstream/master' into constrain-bottom-…

55062ea

…sheets

Merge remote-tracking branch 'upstream/master' into constrain-bottom-…

b3fb00f

…sheets

Merge remote-tracking branch 'upstream/master' into constrain-bottom-…

886723c

…sheets

Merge remote-tracking branch 'upstream/master' into constrain-bottom-…

5a97bb1

…sheets

x

e9bce0a

x

de80727

guidezpl merged commit 1f602cb into flutter:master Apr 27, 2023
136 checks passed

guidezpl deleted the constrain-bottom-sheets branch April 27, 2023 07:28

engine-flutter-autoroll mentioned this pull request Apr 28, 2023

Roll Flutter from 66fa4c5d301c to 5a1ef73dd088 (33 revisions) flutter/packages#3840

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023

1f602cb6c Provide default constraints for M3 bottom sheets (flutter/f…

1d5abd0

…lutter#120065)

engine-flutter-autoroll mentioned this pull request Apr 28, 2023

Roll Flutter from 66fa4c5d301c to 00bbf5434c0d (34 revisions) flutter/packages#3841

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023

1f602cb6c Provide default constraints for M3 bottom sheets (flutter/f…

8923f3b

…lutter#120065)

engine-flutter-autoroll mentioned this pull request Apr 28, 2023

Roll Flutter from 66fa4c5d301c to a698da607860 (35 revisions) flutter/packages#3842

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023

1f602cb6c Provide default constraints for M3 bottom sheets (flutter/f…

dddc9c8

…lutter#120065)

engine-flutter-autoroll mentioned this pull request Apr 28, 2023

Roll Flutter from 66fa4c5d301c to 69af93436767 (36 revisions) flutter/packages#3843

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023

1f602cb6c Provide default constraints for M3 bottom sheets (flutter/f…

6874a1c

…lutter#120065)

engine-flutter-autoroll mentioned this pull request Apr 28, 2023

Roll Flutter from 66fa4c5d301c to 888b208d62eb (37 revisions) flutter/packages#3844

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023

1f602cb6c Provide default constraints for M3 bottom sheets (flutter/f…

6e23b16

…lutter#120065)

engine-flutter-autoroll mentioned this pull request Apr 28, 2023

Roll Flutter from 66fa4c5d301c to 50f83fc2777d (38 revisions) flutter/packages#3845

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 28, 2023

1f602cb6c Provide default constraints for M3 bottom sheets (flutter/f…

08ef9b6

…lutter#120065)

HansMuller mentioned this pull request Apr 28, 2023

Flutter Framework Team: Notable Commits #121415

Open

engine-flutter-autoroll mentioned this pull request Apr 29, 2023

Roll Flutter from 66fa4c5d301c to 14981ffc0222 (55 revisions) flutter/packages#3852

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023

1f602cb6c Provide default constraints for M3 bottom sheets (flutter/f…

ef24e12

…lutter#120065)

engine-flutter-autoroll mentioned this pull request Apr 29, 2023

Roll Flutter from 66fa4c5d301c to 14981ffc0222 (55 revisions) flutter/packages#3853

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023

1f602cb6c Provide default constraints for M3 bottom sheets (flutter/f…

b2b963f

…lutter#120065)

engine-flutter-autoroll mentioned this pull request Apr 29, 2023

Roll Flutter from 66fa4c5d301c to 807c55c6b322 (56 revisions) flutter/packages#3854

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023

1f602cb6c Provide default constraints for M3 bottom sheets (flutter/f…

af8e8fb

…lutter#120065)

engine-flutter-autoroll mentioned this pull request Apr 29, 2023

Roll Flutter from 66fa4c5d301c to 29b3e66ecbea (57 revisions) flutter/packages#3855

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 29, 2023

1f602cb6c Provide default constraints for M3 bottom sheets (flutter/f…

05a85dc

…lutter#120065)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2023

1f602cb6c Provide default constraints for M3 bottom sheets (flutter/f…

7b1bb80

…lutter#120065)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 30, 2023

1f602cb6c Provide default constraints for M3 bottom sheets (flutter/f…

b7e8b8b

…lutter#120065)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023

1f602cb6c Provide default constraints for M3 bottom sheets (flutter/f…

5077347

…lutter#120065)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023

1f602cb6c Provide default constraints for M3 bottom sheets (flutter/f…

07414c6

…lutter#120065)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023

1f602cb6c Provide default constraints for M3 bottom sheets (flutter/f…

612c3a9

…lutter#120065)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023

1f602cb6c Provide default constraints for M3 bottom sheets (flutter/f…

ac80988

…lutter#120065)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023

1f602cb6c Provide default constraints for M3 bottom sheets (flutter/f…

6abc930

…lutter#120065)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023

1f602cb6c Provide default constraints for M3 bottom sheets (flutter/f…

677d0a5

…lutter#120065)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023

1f602cb6c Provide default constraints for M3 bottom sheets (flutter/f…

5193322

…lutter#120065)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023

1f602cb6c Provide default constraints for M3 bottom sheets (flutter/f…

bc634a4

…lutter#120065)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023

1f602cb6c Provide default constraints for M3 bottom sheets (flutter/f…

9948ba2

…lutter#120065)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 1, 2023

1f602cb6c Provide default constraints for M3 bottom sheets (flutter/f…

cbf7892

…lutter#120065)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Provide default constraints for M3 bottom sheets #120065

Provide default constraints for M3 bottom sheets #120065

guidezpl commented Feb 6, 2023 •

edited

esouthren Feb 6, 2023

guidezpl Feb 6, 2023

guidezpl Feb 6, 2023

esouthren left a comment

hangyujin left a comment

Provide default constraints for M3 bottom sheets #120065

Provide default constraints for M3 bottom sheets #120065

Conversation

guidezpl commented Feb 6, 2023 • edited

Pre-launch Checklist

esouthren Feb 6, 2023

Choose a reason for hiding this comment

guidezpl Feb 6, 2023

Choose a reason for hiding this comment

guidezpl Feb 6, 2023

Choose a reason for hiding this comment

esouthren left a comment

Choose a reason for hiding this comment

hangyujin left a comment

Choose a reason for hiding this comment

guidezpl commented Feb 6, 2023 •

edited