Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix license page rtl #120497

Merged
merged 8 commits into from Feb 21, 2023
Merged

Fix license page rtl #120497

merged 8 commits into from Feb 21, 2023

Conversation

jehhxuxu
Copy link
Contributor

@jehhxuxu jehhxuxu commented Feb 10, 2023 •
edited by TahaTesser

fixes #113916

Description

  • Fix the position of the package list on RTL direction.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on [Discord].

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Feb 10, 2023
@jehhxuxu
Copy link
Contributor Author

@TahaTesser can you please review?

werainkhatri
werainkhatri reviewed Feb 11, 2023
View reviewed changes
Copy link
Member

@werainkhatri werainkhatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your contribution!

just a few suggestions, will approve it post that.

packages/flutter/test/material/about_test.dart Show resolved Hide resolved
packages/flutter/test/material/about_test.dart Outdated Show resolved Hide resolved
packages/flutter/test/material/about_test.dart Outdated Show resolved Hide resolved
@jehhxuxu jehhxuxu requested review from tgucio and werainkhatri and removed request for werainkhatri and tgucio February 14, 2023 14:40
tgucio
tgucio approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@tgucio tgucio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgucio
Copy link
Contributor

tgucio commented Feb 15, 2023

Looks like @werainkhatri's comments have been addressed but I'll wait for approval before merging.

werainkhatri
werainkhatri approved these changes Feb 18, 2023
View reviewed changes
Copy link
Member

@werainkhatri werainkhatri left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution!

sorry for the delay. will wait in case @gspencergoog has come comments.

blue flutter

gspencergoog
gspencergoog approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the thorough tests!

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 21, 2023
@auto-submit auto-submit bot merged commit aa29358 into flutter:master Feb 21, 2023
@TahaTesser TahaTesser mentioned this pull request Feb 22, 2023
Closed
This was referenced Feb 22, 2023
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
aa29358c5 Fix license page rtl (flutter/flutter#120497)
4058586
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
aa29358c5 Fix license page rtl (flutter/flutter#120497)
9685926
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
aa29358c5 Fix license page rtl (flutter/flutter#120497)
8ec4fb0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
aa29358c5 Fix license page rtl (flutter/flutter#120497)
d5adc8f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
aa29358c5 Fix license page rtl (flutter/flutter#120497)
b048239
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
aa29358c5 Fix license page rtl (flutter/flutter#120497)
ec0ac15
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
aa29358c5 Fix license page rtl (flutter/flutter#120497)
af4e6da
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
aa29358c5 Fix license page rtl (flutter/flutter#120497)
2fa1804
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
aa29358c5 Fix license page rtl (flutter/flutter#120497)
f22b25e
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
aa29358c5 Fix license page rtl (flutter/flutter#120497)
59fe148
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
aa29358c5 Fix license page rtl (flutter/flutter#120497)
6ae71a8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
aa29358c5 Fix license page rtl (flutter/flutter#120497)
0c59696
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
aa29358c5 Fix license page rtl (flutter/flutter#120497)
8e59bc3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
aa29358c5 Fix license page rtl (flutter/flutter#120497)
76fe7d2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
aa29358c5 Fix license page rtl (flutter/flutter#120497)
8940995
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
aa29358c5 Fix license page rtl (flutter/flutter#120497)
07e5188
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
aa29358c5 Fix license page rtl (flutter/flutter#120497)
dee2ed4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
aa29358c5 Fix license page rtl (flutter/flutter#120497)
a7493b8
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
aa29358c5 Fix license page rtl (flutter/flutter#120497)
1a0458f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
aa29358c5 Fix license page rtl (flutter/flutter#120497)
ea8ef71
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
aa29358c5 Fix license page rtl (flutter/flutter#120497)
3e5fda1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
aa29358c5 Fix license page rtl (flutter/flutter#120497)
c00e3c5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
aa29358c5 Fix license page rtl (flutter/flutter#120497)
959a871
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
aa29358c5 Fix license page rtl (flutter/flutter#120497)
d4d6ba0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
aa29358c5 Fix license page rtl (flutter/flutter#120497)
5c5a838
@HansMuller HansMuller mentioned this pull request Mar 2, 2023
Open
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
aa29358c5 Fix license page rtl (flutter/flutter#120497)
ae1e63a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
aa29358c5 Fix license page rtl (flutter/flutter#120497)
1f541ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

@werainkhatri werainkhatri werainkhatri approved these changes

@tgucio tgucio tgucio approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

License list position has bug in RTL lateral LicensePage
4 participants
@jehhxuxu @tgucio @gspencergoog @werainkhatri