allow passing --file-reporter option to test running refs #69425 #120716

mateusfccp · 2023-02-14T20:20:05Z

Allow passing --file-reporter option to test runner so that both machine and human readable output can be observed in a CI setting.

Supersedes #111969.

Fixes #69425.

Note: I did not made the initial commit. It was made entirely by @daniel-v, so all credits goes to him. I rebased his patch and I'm going to continue the PR process by fixing tests/checks and reacting to reviewers.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

mateusfccp · 2023-02-15T10:34:54Z

For some reason, the Linux web_canvaskit_tests_5 check is locked in progress, but the dashboard says it completed: https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20web_canvaskit_tests_5/22458/overview

christopherfujino · 2023-02-16T21:35:35Z

@Jasguerrero can you review this one?

packages/flutter_tools/test/commands.shard/hermetic/test_test.dart

Jasguerrero

LGTM

auto-submit · 2023-02-20T23:02:20Z

auto label is removed for flutter/flutter, pr: 120716, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

auto-submit · 2023-02-20T23:02:21Z

auto label is removed for flutter/flutter, pr: 120716, due to Validations Fail.

andrewkolos

LGTM

…69425 (flutter/flutter#120716)

flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 14, 2023

mateusfccp force-pushed the expose-test-file-reporter branch from f1a0b0d to 9bfbd1c Compare February 14, 2023 23:46

mateusfccp marked this pull request as ready for review February 15, 2023 00:57

mateusfccp mentioned this pull request Feb 15, 2023

allow passing --file-reporter option to test runner #111969

Closed

8 tasks

Jasguerrero reviewed Feb 16, 2023

View reviewed changes

packages/flutter_tools/test/commands.shard/hermetic/test_test.dart Show resolved Hide resolved

daniel-v and others added 2 commits February 19, 2023 15:54

allow passing --file-reporter option to test running refs flutter#69425

0a702a1

Add trailing comma to help to meet style requirements

0e1bae7

mateusfccp force-pushed the expose-test-file-reporter branch from 9bfbd1c to 0e1bae7 Compare February 19, 2023 18:54

Add space between tests for clarity

c1884a7

Jasguerrero approved these changes Feb 20, 2023

View reviewed changes

Jasguerrero added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 20, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 20, 2023

andrewkolos self-requested a review February 21, 2023 16:50

andrewkolos approved these changes Feb 21, 2023

View reviewed changes

andrewkolos added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 21, 2023

auto-submit bot merged commit ebbc94b into flutter:master Feb 21, 2023

mateusfccp deleted the expose-test-file-reporter branch February 21, 2023 17:29

engine-flutter-autoroll mentioned this pull request Feb 21, 2023

Roll Flutter from 33e4d21f7c13 to 6259b690f6e0 (15 revisions) flutter/plugins#7207

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 21, 2023

ebbc94bc2 allow passing --file-reporter option to test running refs #…

3c1b9bf

…69425 (flutter/flutter#120716)

engine-flutter-autoroll mentioned this pull request Feb 21, 2023

Roll Flutter from 33e4d21f7c13 to 09518ac72584 (17 revisions) flutter/plugins#7208

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 21, 2023

ebbc94bc2 allow passing --file-reporter option to test running refs #…

3c442bb

…69425 (flutter/flutter#120716)

engine-flutter-autoroll mentioned this pull request Feb 21, 2023

Roll Flutter from 33e4d21f7c13 to bd5e8db3a331 (18 revisions) flutter/plugins#7209

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 21, 2023

ebbc94bc2 allow passing --file-reporter option to test running refs #…

52a40d8

…69425 (flutter/flutter#120716)

This was referenced Feb 22, 2023

Roll Flutter from 7175de4fe686 to 4c25587b71aa (17 revisions) flutter/packages#3255

Closed

Roll Flutter from 33e4d21f7c13 to 4c25587b71aa (27 revisions) flutter/plugins#7212

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 22, 2023

ebbc94bc2 allow passing --file-reporter option to test running refs #…

ed07392

…69425 (flutter/flutter#120716)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2023

ebbc94bc2 allow passing --file-reporter option to test running refs #…

6b4c15f

…69425 (flutter/flutter#120716)

engine-flutter-autoroll mentioned this pull request Feb 22, 2023

Roll Flutter from 7175de4fe686 to 7d85a585da75 (19 revisions) flutter/packages#3264

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 22, 2023

ebbc94bc2 allow passing --file-reporter option to test running refs #…

cd34f06

…69425 (flutter/flutter#120716)

engine-flutter-autoroll mentioned this pull request Feb 23, 2023

Roll Flutter from 7175de4fe686 to 19b2aa14c08f (42 revisions) flutter/packages#3276

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023

ebbc94bc2 allow passing --file-reporter option to test running refs #…

7255727

…69425 (flutter/flutter#120716)

engine-flutter-autoroll mentioned this pull request Feb 23, 2023

Roll Flutter from 7175de4fe686 to af347d667735 (43 revisions) flutter/packages#3280

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023

ebbc94bc2 allow passing --file-reporter option to test running refs #…

619ef66

…69425 (flutter/flutter#120716)

engine-flutter-autoroll mentioned this pull request Feb 23, 2023

Roll Flutter from 7175de4fe686 to c722ce419a73 (46 revisions) flutter/packages#3283

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023

ebbc94bc2 allow passing --file-reporter option to test running refs #…

b4bda9a

…69425 (flutter/flutter#120716)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023

ebbc94bc2 allow passing --file-reporter option to test running refs #…

2795b92

…69425 (flutter/flutter#120716)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023

ebbc94bc2 allow passing --file-reporter option to test running refs #…

afc613e

…69425 (flutter/flutter#120716)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023

ebbc94bc2 allow passing --file-reporter option to test running refs #…

9e77264

…69425 (flutter/flutter#120716)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023

ebbc94bc2 allow passing --file-reporter option to test running refs #…

6e6183d

…69425 (flutter/flutter#120716)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023

ebbc94bc2 allow passing --file-reporter option to test running refs #…

c7f8d21

…69425 (flutter/flutter#120716)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023

ebbc94bc2 allow passing --file-reporter option to test running refs #…

f7dc77a

…69425 (flutter/flutter#120716)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023

ebbc94bc2 allow passing --file-reporter option to test running refs #…

917fca8

…69425 (flutter/flutter#120716)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023

ebbc94bc2 allow passing --file-reporter option to test running refs #…

7d56f6b

…69425 (flutter/flutter#120716)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023

ebbc94bc2 allow passing --file-reporter option to test running refs #…

ecb74f5

…69425 (flutter/flutter#120716)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023

ebbc94bc2 allow passing --file-reporter option to test running refs #…

780e61d

…69425 (flutter/flutter#120716)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023

ebbc94bc2 allow passing --file-reporter option to test running refs #…

13b16a4

…69425 (flutter/flutter#120716)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023

ebbc94bc2 allow passing --file-reporter option to test running refs #…

c115f2b

…69425 (flutter/flutter#120716)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023

ebbc94bc2 allow passing --file-reporter option to test running refs #…

2e4d9d6

…69425 (flutter/flutter#120716)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023

ebbc94bc2 allow passing --file-reporter option to test running refs #…

38d424b

…69425 (flutter/flutter#120716)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023

ebbc94bc2 allow passing --file-reporter option to test running refs #…

cb92f69

…69425 (flutter/flutter#120716)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023

ebbc94bc2 allow passing --file-reporter option to test running refs #…

b90e9d6

…69425 (flutter/flutter#120716)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023

ebbc94bc2 allow passing --file-reporter option to test running refs #…

8275c49

…69425 (flutter/flutter#120716)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023

ebbc94bc2 allow passing --file-reporter option to test running refs #…

800d141

…69425 (flutter/flutter#120716)

christopherfujino mentioned this pull request Mar 7, 2023

[flutter_tools] generate local test reports for flutter_tools #54874

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023

ebbc94bc2 allow passing --file-reporter option to test running refs #…

921a5a3

…69425 (flutter/flutter#120716)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023

ebbc94bc2 allow passing --file-reporter option to test running refs #…

0033310

…69425 (flutter/flutter#120716)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

allow passing --file-reporter option to test running refs #69425 #120716

allow passing --file-reporter option to test running refs #69425 #120716

mateusfccp commented Feb 14, 2023 •

edited

mateusfccp commented Feb 15, 2023

christopherfujino commented Feb 16, 2023

Jasguerrero left a comment

auto-submit bot commented Feb 20, 2023

auto-submit bot commented Feb 20, 2023

andrewkolos left a comment

allow passing --file-reporter option to test running refs #69425 #120716

allow passing --file-reporter option to test running refs #69425 #120716

Conversation

mateusfccp commented Feb 14, 2023 • edited

Pre-launch Checklist

mateusfccp commented Feb 15, 2023

christopherfujino commented Feb 16, 2023

Jasguerrero left a comment

Choose a reason for hiding this comment

auto-submit bot commented Feb 20, 2023

auto-submit bot commented Feb 20, 2023

andrewkolos left a comment

Choose a reason for hiding this comment

mateusfccp commented Feb 14, 2023 •

edited