Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CupertinoSliverNavigationBar's alwaysShowMiddle not working properly during page transition #120895

Merged
merged 2 commits into from Mar 1, 2023
Merged

Fix CupertinoSliverNavigationBar's alwaysShowMiddle not working properly during page transition #120895

merged 2 commits into from Mar 1, 2023

Conversation

DavideDessi319
Copy link
Contributor

This change fixes the CupertinoSliverNavigationBar's middle Widget showing for an instant during a page transition when the nav bar is not collapsed and alwaysShowMiddle is set to false. The PR adds a check on the transition's hasUserMiddle property based on the alwaysShowMiddle and the collapsed/expanded state of the nav bar.

Fixes #119522

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels Feb 16, 2023
@DavideDessi319 DavideDessi319 changed the title Fixes CupertinoSliverNavigationBar's alwaysShowMiddle not working properly during page transition Fix CupertinoSliverNavigationBar's alwaysShowMiddle not working properly during page transition Feb 16, 2023
@MitchellGoodwin
Copy link
Contributor

@DavideDessi319 there's been some infrastructure issues with the tests. Could you please rebase onto the latest master branch?

@DavideDessi319
Fixes the 'middle' widget showing during the CupertinoSliverNavigatio…
e78242d 
…nBar page transition if alwaysShowMiddle is set to false
@DavideDessi319
Copy link
Contributor Author

@DavideDessi319 there's been some infrastructure issues with the tests. Could you please rebase onto the latest master branch?

@MitchellGoodwin apologies for the delay on the rebase, it should be done now!
Thank you for the check 🙂

MitchellGoodwin
MitchellGoodwin approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@MitchellGoodwin MitchellGoodwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for taking the time to fix this.

Piinks
Piinks approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few style guide nits!

packages/flutter/test/cupertino/nav_bar_transition_test.dart Outdated Show resolved Hide resolved
packages/flutter/test/cupertino/nav_bar_transition_test.dart Outdated Show resolved Hide resolved
@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 1, 2023
@auto-submit auto-submit bot merged commit 844fc5f into flutter:master Mar 1, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
844fc5fe2 Fix CupertinoSliverNavigationBar's alwaysShowMiddle not wor…
c6db312 
…king properly during page transition (flutter/flutter#120895)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
844fc5fe2 Fix CupertinoSliverNavigationBar's alwaysShowMiddle not wor…
b5f9cb7 
…king properly during page transition (flutter/flutter#120895)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
844fc5fe2 Fix CupertinoSliverNavigationBar's alwaysShowMiddle not wor…
515c0a4 
…king properly during page transition (flutter/flutter#120895)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
844fc5fe2 Fix CupertinoSliverNavigationBar's alwaysShowMiddle not wor…
2c5abe5 
…king properly during page transition (flutter/flutter#120895)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
844fc5fe2 Fix CupertinoSliverNavigationBar's alwaysShowMiddle not wor…
fb0e5b1 
…king properly during page transition (flutter/flutter#120895)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
844fc5fe2 Fix CupertinoSliverNavigationBar's alwaysShowMiddle not wor…
08b0503 
…king properly during page transition (flutter/flutter#120895)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
844fc5fe2 Fix CupertinoSliverNavigationBar's alwaysShowMiddle not wor…
ec786e5 
…king properly during page transition (flutter/flutter#120895)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2023
@engine-flutter-autoroll
844fc5fe2 Fix CupertinoSliverNavigationBar's alwaysShowMiddle not wor…
02972b3 
…king properly during page transition (flutter/flutter#120895)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2023
@engine-flutter-autoroll
844fc5fe2 Fix CupertinoSliverNavigationBar's alwaysShowMiddle not wor…
c67b2f7 
…king properly during page transition (flutter/flutter#120895)
@HansMuller HansMuller mentioned this pull request Mar 3, 2023
Open
@DavideDessi319 DavideDessi319 deleted the fix/119522 branch March 4, 2023 19:43
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
844fc5fe2 Fix CupertinoSliverNavigationBar's alwaysShowMiddle not wor…
bbf3d04 
…king properly during page transition (flutter/flutter#120895)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
844fc5fe2 Fix CupertinoSliverNavigationBar's alwaysShowMiddle not wor…
9a0a60a 
…king properly during page transition (flutter/flutter#120895)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks Piinks approved these changes

@MitchellGoodwin MitchellGoodwin MitchellGoodwin approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CupertinoSliverNavigationBar's alwaysShowMiddle now working during page transition
3 participants
@DavideDessi319 @MitchellGoodwin @Piinks