Fix ListWheelScrollView gestures and paint coordinates in tests #121342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nt4f04uNd
added
framework
nt4f04uNd
force-pushed
the
38803/fix-list-wheel-scroll-view-gestures
branch
from
f000764
to
e060330
Compare
nt4f04uNd
commented
Feb 24, 2023
| tester.getTopLeft(find.widgetWithText(SizedBox, '0')), | ||
| const Offset(0.0, 250.0), | ||
| tester.getTopLeft(find.widgetWithText(SizedBox, '0')), | ||
| offsetMoreOrLessEquals(const Offset(200.0, 250.0)), |
There was a problem hiding this comment.
These changes are to be expected. Previously the position didn't account for transform applied to children.
200.0 = (800.0 (screen width) - 400.0 (item width in this test) ) / 2 (since the scroll view centers its children on screen)
This comment was marked as resolved.
This comment was marked as resolved.
nt4f04uNd
force-pushed
the
38803/fix-list-wheel-scroll-view-gestures
branch
from
c2935fb
to
b9e3155
Compare
Piinks
reviewed
Feb 28, 2023
| /// | ||
| /// Can be used to find the local bounds of this child in the viewport, | ||
| /// and then use it, for example, in hit testing. | ||
| Matrix4? transform; |
There was a problem hiding this comment.
For the docs, when would this be null?
There was a problem hiding this comment.
From what it seems, never. Added docs and assertions to ensure that.
Piinks
reviewed
Feb 28, 2023
Piinks
reviewed
Feb 28, 2023
|
(triage) @nt4f04uNd Do you still have plans to follow up on the feedback given above? |
nt4f04uNd
force-pushed
the
38803/fix-list-wheel-scroll-view-gestures
branch
2 times, most recently
from
5a1009d
to
177e4d4
Compare
|
Updated. I'm sorry this took a while. |
nt4f04uNd
commented
Mar 26, 2023
| @@ -592,14 +592,26 @@ void main() { | |||
| ); | |||
| }); | |||
|
|
|||
| testWidgets('width of wheel in background does not increase at large widths', (WidgetTester tester) async { | |||
| testWidgets('wheel does not bend outwards', (WidgetTester tester) async { | |||
There was a problem hiding this comment.
This test also didn't work properly because of the bug #121343
I rewrote it to actually verify the shape of the list wheel
Values were:
1
decemberX = 250
octoberX = 250
2
decemberX = 218.5
octoberX = 218.5
So the distance in both cases was zero
In actuality, after the fix, these values were
262.6779112246874
250.75842555233146
distance 11.919485672355961
232.8608197943362
219.35910151060554
distance = 13.501718283730668
nt4f04uNd
changed the title
flutter-dashboard
bot
added
the
f: cupertino
Piinks
reviewed
Mar 29, 2023
| '$RenderListWheelViewport normally paints all of the children it has laid out. \n' | ||
| 'Did you forget to update the $ListWheelParentData.transform during the paint() call?. \n' | ||
| 'Did you forget to update the $ListWheelParentData.transform during the paint() call? \n' |
There was a problem hiding this comment.
At first I thought, what an interesting error message, but TIL we have a couple of error messages like this. Nice!
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/flutter, pr: 121342, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 30, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 30, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 30, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 31, 2023
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 1, 2023
8 tasks
exaby73
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Apr 17, 2023
…ter#121342) Fix ListWheelScrollView gestures and paint coordinates in tests
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38803
Fixes #121343
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.