Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update date picker examples, remove unused variables and add missing tests #121528

Merged
merged 3 commits into from Feb 28, 2023
Merged

Update date picker examples, remove unused variables and add missing tests #121528

merged 3 commits into from Feb 28, 2023

Conversation

TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Feb 27, 2023 •
edited

part of #101048 (final example)
fix #121028
fix #120765

Description

  1. Update date picker examples and add missing tests for Update DatePicker to support Material 3  #101481
  2. Remove an unused variable in the switch example and add the missing test.
  3. Remove an unused variable in the filter chip example

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: material design flutter/packages/flutter/material repository. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. labels Feb 27, 2023
HansMuller
HansMuller reviewed Feb 27, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some nit picking, mostly about the existing code.

examples/api/lib/material/filter_chip/filter_chip.0.dart Outdated Show resolved Hide resolved
examples/api/lib/material/filter_chip/filter_chip.0.dart Outdated Show resolved Hide resolved
examples/api/lib/material/switch/switch.2.dart Outdated Show resolved Hide resolved
examples/api/test/material/switch/switch.2_test.dart Outdated Show resolved Hide resolved
HansMuller
HansMuller approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

examples/api/lib/material/filter_chip/filter_chip.0.dart Outdated Show resolved Hide resolved
@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 27, 2023
@TahaTesser TahaTesser force-pushed the update_examples_and_add_missing_test branch from bcef88d to 6365dce Compare February 28, 2023 07:11
@auto-submit auto-submit bot merged commit 87679ff into flutter:master Feb 28, 2023
@TahaTesser TahaTesser deleted the update_examples_and_add_missing_test branch February 28, 2023 08:44
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 28, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2023
@engine-flutter-autoroll
87679ff1c Update date picker examples, remove unused variables and ad…
075528c 
…d missing tests (flutter/flutter#121528)
@HansMuller HansMuller mentioned this pull request Mar 3, 2023
Open
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
87679ff1c Update date picker examples, remove unused variables and ad…
8f26822 
…d missing tests (flutter/flutter#121528)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
87679ff1c Update date picker examples, remove unused variables and ad…
ca06c08 
…d missing tests (flutter/flutter#121528)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansMuller HansMuller HansMuller approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unused variable in the example of FilterChip. Unused variable in Switch class example
2 participants
@TahaTesser @HansMuller