Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix text.rich to merge widget span (#113461)" #121562

Merged
merged 1 commit into from Feb 27, 2023
Merged

Revert "Fix text.rich to merge widget span (#113461)" #121562

merged 1 commit into from Feb 27, 2023

Conversation

chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Feb 27, 2023 •
edited

This reverts commit 660992a.

The original pr causes tag to be applied to the entire subtree instead of just the immediate child. This causes singlechildscrollable under a multichildscrollable to think itself is multi child because of the two panel.

revert for now, need to think of a better way to handling tagging.

#121545

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Feb 27, 2023
This was referenced Feb 27, 2023
Closed
Closed
goderbauer
goderbauer approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai merged commit c8d8016 into flutter:master Feb 27, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 27, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
c8d80163b Revert "Fix text.rich to merge widget span (#113461)" (flut…
8697e59 
…ter/flutter#121562)
chunhtai added a commit to chunhtai/flutter that referenced this pull request Mar 1, 2023
@chunhtai
Revert "Revert "Fix text.rich to merge widget span (flutter#113461)" (f…
8c5651b 
…lutter#121562)"

This reverts commit c8d8016.
chunhtai added a commit that referenced this pull request Mar 1, 2023
@chunhtai
Issues/111931 reland (#121576)
978d9b5 
* Revert "Revert "Fix text.rich to merge widget span (#113461)" (#121562)"

This reverts commit c8d8016.

* Fixes tag to not pollute cached semantics configuration in rendering object
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
c8d80163b Revert "Fix text.rich to merge widget span (#113461)" (flut…
03c0ccb 
…ter/flutter#121562)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
c8d80163b Revert "Fix text.rich to merge widget span (#113461)" (flut…
b03103d 
…ter/flutter#121562)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

@bparrishMines bparrishMines Awaiting requested review from bparrishMines

Assignees
No one assigned
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chunhtai @goderbauer