Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed "typically non-null" API doc qualifiers from ScrollMetrics min,max extent getters #121572

Merged
merged 2 commits into from Feb 28, 2023

Conversation

HansMuller
Copy link
Contributor

@HansMuller HansMuller commented Feb 28, 2023

The ScrollMetrics minScrollExtent and maxScrollExtent properties are no long nullable.

@flutter-dashboard flutter-dashboard bot added f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Feb 28, 2023
@HansMuller HansMuller changed the title Removed "typically non-null" API doc qualifiers from ViewportOffset min,maxExtent getters Removed "typically non-null" API doc qualifiers from ScrollMetrics min,max extent getters Feb 28, 2023
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansMuller HansMuller added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 28, 2023
@auto-submit auto-submit bot merged commit cd0030c into flutter:master Feb 28, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 28, 2023
@HansMuller HansMuller deleted the viewport_offset_doc branch February 28, 2023 16:16
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants