Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roll pub packages #121847

Closed
wants to merge 1 commit into from
Closed

Roll pub packages #121847

wants to merge 1 commit into from

Conversation

fluttergithubbot
Copy link
Contributor

This PR was generated by flutter update-packages --force-upgrade.

@fluttergithubbot fluttergithubbot added tool Affects the "flutter" command-line tool. See also t: labels. autosubmit Merge PR when tree becomes green via auto submit App labels Mar 3, 2023
@flutter-dashboard flutter-dashboard bot added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team: flakes c: tech-debt Technical debt, code quality, testing, etc. labels Mar 3, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 3, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 3, 2023

auto label is removed for flutter/flutter, pr: 121847, due to - Please get at least one approved review if you are already a member or two member reviews if you are not a member before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 3, 2023

auto label is removed for flutter/flutter, pr: 121847, due to Validations Fail.

christopherfujino
christopherfujino approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 3, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 3, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 3, 2023

auto label is removed for flutter/flutter, pr: 121847, due to - The status or check suite Mac tool_integration_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.

christopherfujino
christopherfujino reviewed Mar 3, 2023
View reviewed changes
dev/integration_tests/gradle_deprecated_settings/pubspec.yaml
@@ -16,7 +16,7 @@ dependencies:
characters: 1.3.0 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
collection: 1.17.1 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
cross_file: 0.3.3+4 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
flutter_plugin_android_lifecycle: 2.0.8 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
flutter_plugin_android_lifecycle: 2.0.9 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reidbaker could you take a look at this? This change appears to be causing the following failure (although I can't explain why it seems to have passed on Linux...)

[        ] Cause 1: org.gradle.internal.resolve.ModuleVersionResolveException: Could not resolve androidx.annotation:annotation:1.5.0.
[        ] Required by:
[        ]     project :flutter_plugin_android_lifecycle

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8787684536026999009/+/u/run_test.dart_for_tool_integration_tests_shard_and_subshard_4_4/test_stdout

Here is the changelog for this plugin: https://github.com/flutter/packages/commits/main/packages/flutter_plugin_android_lifecycle

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, I think it's this: https://github.com/flutter/packages/pull/3271/files#diff-a7a667ae2f4a6b9d0a2fc91cc1eb18310cf7bc98cecbcd9b27fe444028d87887R37

@christopherfujino christopherfujino mentioned this pull request Mar 3, 2023
Merged
@reidbaker reidbaker mentioned this pull request Mar 6, 2023
Closed
This was referenced Mar 6, 2023
Closed
Closed
@christopherfujino
Copy link
Member

The package that broke CI was manually pinned, so closing this

@gmackall gmackall mentioned this pull request Jun 14, 2023
Merged
8 tasks
auto-submit bot pushed a commit that referenced this pull request Jun 14, 2023
@gmackall
Unpin flutter_plugin_android_lifecycle (#128898)
944d6c8 
Unpins flutter_plugin_android_lifecycle where it is pinned. I then 
1. ran `flutter update-packages --force-upgrade` (but only committed the changes within `dev/integration_tests/gradle_deprecated_settings/`, which is where it had been pinned) 
2. followed by `./gradlew :generateLockfiles` from `dev/integration_tests/gradle_deprecated_settings/android/` (the lockfile was what was causing the CI dependency resolution failure, so this second step is the fix for that).

See the reason it was pinned: #121847 (comment) followed by the PR that pinned it: #122043

Fixes #122039
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
c: tech-debt Technical debt, code quality, testing, etc. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fluttergithubbot @christopherfujino