Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No friction factor on macOS overscroll ease #122143

Merged
merged 3 commits into from Mar 8, 2023
Merged

No friction factor on macOS overscroll ease #122143

merged 3 commits into from Mar 8, 2023

Conversation

moffatman
Copy link
Contributor

In macOS, AppKit/UIKit apps will not modify scroll deltas when they are used to ease an overscroll. This updates Flutter to match that for BouncingScrollPhysics(decelerationRate: ScrollDecelerationRate.fast).

Fixes #115791

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Mar 7, 2023
@moffatman moffatman requested a review from Piinks March 7, 2023 23:33
TRohit20
TRohit20 reviewed Mar 8, 2023
View reviewed changes
Copy link

@TRohit20 TRohit20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test coverage looks good!

Piinks
Piinks approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

Flutter_LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 8, 2023
@auto-submit auto-submit bot merged commit 2e7b458 into flutter:master Mar 8, 2023
33 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 9, 2023
@engine-flutter-autoroll
2e7b45879 No friction factor on macOS overscroll ease (flutter/flutte…
564c591 
…r#122143)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2023
@engine-flutter-autoroll
2e7b45879 No friction factor on macOS overscroll ease (flutter/flutte…
9b2ec2b 
…r#122143)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2023
@engine-flutter-autoroll
2e7b45879 No friction factor on macOS overscroll ease (flutter/flutte…
bfa6c19 
…r#122143)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2023
@engine-flutter-autoroll
2e7b45879 No friction factor on macOS overscroll ease (flutter/flutte…
ce1334d 
…r#122143)
hangyujin pushed a commit to hangyujin/flutter that referenced this pull request Mar 11, 2023
@moffatman @hangyujin
No friction factor on macOS overscroll ease (flutter#122143)
046d9aa 
No friction factor on macOS overscroll ease
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 11, 2023
@engine-flutter-autoroll
2e7b45879 No friction factor on macOS overscroll ease (flutter/flutte…
5b7966a 
…r#122143)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 12, 2023
@engine-flutter-autoroll
2e7b45879 No friction factor on macOS overscroll ease (flutter/flutte…
69f1983 
…r#122143)
@HansMuller HansMuller mentioned this pull request Mar 16, 2023
Open
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
2e7b45879 No friction factor on macOS overscroll ease (flutter/flutte…
324617a 
…r#122143)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
2e7b45879 No friction factor on macOS overscroll ease (flutter/flutte…
9f78507 
…r#122143)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TRohit20 TRohit20 TRohit20 left review comments

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[macOS] Scroll overdrag should return back faster
3 participants
@moffatman @Piinks @TRohit20