Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove key simulation obsolete comments #122389

Conversation

bleroux
Copy link
Contributor

@bleroux bleroux commented Mar 10, 2023

Description

This PR removes the following osbolete comment which is repeated several times in flutter_test/lib/src/controller.dart and flutter_test/lib/src/event_simulation.dart:

 /// Some platforms (e.g. Windows, iOS) are not yet supported.

Related Issue

Fixes #122297

Tests

Documentation only.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Mar 10, 2023
@bleroux bleroux force-pushed the remove_key_simulation_obsolete_comments branch from cef7009 to a12e2ae Compare March 10, 2023 13:24
@bleroux bleroux force-pushed the remove_key_simulation_obsolete_comments branch from a12e2ae to bb916bd Compare March 10, 2023 13:31
Copy link
Contributor

@pdblasi-google pdblasi-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bleroux bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 13, 2023
@auto-submit auto-submit bot merged commit 376d8ba into flutter:master Mar 13, 2023
33 checks passed
@bleroux bleroux deleted the remove_key_simulation_obsolete_comments branch March 13, 2023 20:22
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key simulation obsolete comment
2 participants