New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notify about existing caches when preloading #122592
Conversation
See internal doc: go/dart-flutter-pub-alignment for design/details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I wonder if this will break flutter run --machine
. This is what I get when I run flutter run -d linux --machine 2>/dev/null
$ flutter run -d linux --machine 2>/dev/null
Found an existing Pub cache at /home/fujino/.pub-cache.
It can be repaired by running `dart pub cache repair`.
It can be reset by running `dart pub cache clear`.
Found an existing Dart Analysis Server cache at /home/fujino/.dartServer.
It can be reset by deleting /home/fujino/.dartServer.
Resolving dependencies...
async 2.10.0 (2.11.0 available)
material_color_utilities 0.2.0 (0.3.0 available)
Got dependencies!
[{"event":"daemon.connected","params":{"version":"0.6.1","pid":834968}}]
[{"event":"app.start","params":{"appId":"2eb0dd8d-adc6-472c-8677-445e19fe35a6","deviceId":"linux","directory":"/home/fujino/git/tmp/delete_me_flutter_box","supportsRestart":true,"launchMode":"run"}}]
Launching lib/main.dart on Linux in debug mode...
[{"event":"app.progress","params":{"appId":"2eb0dd8d-adc6-472c-8677-445e19fe35a6","id":"0","progressId":null,"message":"Building Linux application...","finished":false}}]
[{"event":"app.progress","params":{"appId":"2eb0dd8d-adc6-472c-8677-445e19fe35a6","id":"0","progressId":null,"finished":true}}]
[{"event":"app.stop","params":{"appId":"2eb0dd8d-adc6-472c-8677-445e19fe35a6"}}]
@DanTup is this going to break you?
Assuming what we're talking about here is just extra (non-JSON) It's not great that it works this way - if a user |
Ahh, good to know how this works. I'll file a tracking issue for this, but you're right, we'll probably never be 100% JSON, because I'm not interested in parsing all CLI flags from bash :P |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Check if there are existing user caches when Flutter is first time accessing the pub cache after extracting the downloaded archive.
If they exist we give instructions how to reset/repair these caches.