Reland: Updates flutter/test/material to no longer use TestWindow
#122643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds `FakeViewPadding.zero` and updates `view_test.dart` and `window_test.dart` to use them * Removes `no-shuffle` tag from `app_test.dart` as the underlying issue seems to be resolved * Removes `no-shuffle` tag from `text_field_test.dart` as the underlying issue seems to be resolved
flutter-dashboard
bot
added
a: tests
goderbauer
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
flutter/test/materialto no longer useTestWindowFakeViewPadding.zeroand updatesview_test.dartandwindow_test.dartto use themno-shuffletag fromapp_test.dartas the underlying issue seems to be resolvedno-shuffletag fromtext_field_test.dartas the underlying issue seems to be resolvedThe issue with the previous PR was the removal of
import 'dart:ui' as ui;frompage_test.dart. This was needed to avoid analysis issues on the branch, but when merged with changes in master (that included additional references todart:ui) it cause a build failure.Resolves #122240 and #122637.
Pre-launch Checklist
///).