Clean up scrolling delegate code for 2D #122651
Conversation
Piinks
added
team
|
I'd like to make a change here, please hold off on review. |
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
test-exempt: code refactor with no semantic change |
|
Is this pr ready for review? |
Yes, thanks! This is ready now. :) |
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/flutter, pr: 122651, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Piinks
force-pushed
the
delegateCleanCode
branch
from
e4d6bc2
to
d94a2f2
Compare
Fixes #122650
This is just a straight move (+ a bunch of templates to de-dupe a bunch of docs). I plan to add the two dimensional scrolling delegate base classes here as well. The
sliver.dartfile was very (very) large, and this neatly puts all the delegate code (including future 2D delegate in one place.)This is motivated by part of the 2D scrolling proposal: flutter.dev/go/2D-Foundation
I will likely be re-using some common logic in the TwoDimensionalChildDelegates.
Similar to
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.