Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecates TestWindow #122824

Merged
merged 1 commit into from Mar 21, 2023
Merged

Deprecates TestWindow #122824

merged 1 commit into from Mar 21, 2023

Conversation

pdblasi-google
Copy link
Contributor

@pdblasi-google pdblasi-google commented Mar 16, 2023 •
edited

Deprecates TestWindow

  • Adds Deprecated annotations to TestWindow and its constructors.
  • Adds Deprecated annotations to all properties and methods on TestWindow except noSuchMethod.
  • Adds Deprecated annotation to TestWidgetsFlutterBinding.window.
  • Adds flutter_test specific deprecation documentation to TestWidgetsFlutterBinding.window.

Resolves #121915.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Mar 16, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@goderbauer goderbauer mentioned this pull request Mar 16, 2023
Merged
loic-sharma
loic-sharma approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but please also get an approval from someone who has more experience with our deprecation process :)

goderbauer
goderbauer reviewed Mar 17, 2023
View reviewed changes
packages/flutter_test/lib/src/binding.dart Outdated Show resolved Hide resolved
packages/flutter_test/lib/src/binding.dart Outdated Show resolved Hide resolved
packages/flutter_test/lib/src/window.dart Outdated Show resolved Hide resolved
@pdblasi-google pdblasi-google force-pushed the issues/121915 branch 3 times, most recently from 3f714b0 to eeb05ed Compare March 17, 2023 18:22
@pdblasi-google pdblasi-google mentioned this pull request Mar 17, 2023
Merged
11 tasks
@goderbauer goderbauer mentioned this pull request Mar 17, 2023
Closed
33 tasks
goderbauer
goderbauer approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@goderbauer
Copy link
Member

Looks like the upstream fixes to the packages repo rolled in with #123117. Rebasing this PR should hopefully turn the "Linux flutter_plugins" check green. I believe we are ready to submit this one then?

@pdblasi-google
Deprecates TestWindow
b6da817 
* Adds `Deprecated` annotations to `TestWindow` and its constructors.
* Adds `Deprecated` annotations to all properties and methods on `TestWindow` except `noSuchMethod`.
* Adds `Deprecated` annotation to `TestWidgetsFlutterBinding.window`.
* Adds `flutter_test` specific deprecation documentation to `TestWidgetsFlutterBinding.window`.
@pdblasi-google pdblasi-google added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2023
@auto-submit auto-submit bot merged commit 4695fcc into flutter:master Mar 21, 2023
65 checks passed
@pdblasi-google pdblasi-google deleted the issues/121915 branch March 21, 2023 20:18
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
4695fcc78 Deprecates TestWindow (flutter/flutter#122824)
44594f3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
4695fcc78 Deprecates TestWindow (flutter/flutter#122824)
2c5b3a3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
4695fcc78 Deprecates TestWindow (flutter/flutter#122824)
0d42bea
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
4695fcc78 Deprecates TestWindow (flutter/flutter#122824)
888badd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
4695fcc78 Deprecates TestWindow (flutter/flutter#122824)
8640eb8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
4695fcc78 Deprecates TestWindow (flutter/flutter#122824)
21c5847
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
4695fcc78 Deprecates TestWindow (flutter/flutter#122824)
8f40bfa
This was referenced Mar 23, 2023
Merged
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
4695fcc78 Deprecates TestWindow (flutter/flutter#122824)
09c1051
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
4695fcc78 Deprecates TestWindow (flutter/flutter#122824)
4f7b00f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
4695fcc78 Deprecates TestWindow (flutter/flutter#122824)
8b09698
@HansMuller HansMuller mentioned this pull request Mar 24, 2023
Open
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
4695fcc78 Deprecates TestWindow (flutter/flutter#122824)
3ac3318
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
4695fcc78 Deprecates TestWindow (flutter/flutter#122824)
c66a449
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loic-sharma loic-sharma loic-sharma approved these changes

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mark TestWindow as Deprecated
3 participants
@pdblasi-google @goderbauer @loic-sharma