New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tool] [Windows] Output app path on build completion #122928
Conversation
d39f10f
to
32e1e11
Compare
@@ -94,10 +94,11 @@ Future<void> buildWindows(WindowsProject windowsProject, BuildInfo buildInfo, { | |||
status.stop(); | |||
} | |||
|
|||
final String? binaryName = getCmakeExecutableName(windowsProject); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the reland's fix. The original change used the app's name according to the pubspec.yaml
file and assumed that matched CMake's app name. However, these files can get out of sync.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
32e1e11
to
c098e6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
c098e6f
(#122928): it uses CMake's app name instead ofpubspec.yaml
's app name as these can get out of sync.Improves the build output:
This matches the behavior of other Flutter platforms like Android.
Part of #120127
Flutter run
Flutter build
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.