Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove indicator from scrolling tab bars #123057

Merged
merged 1 commit into from Mar 21, 2023
Merged

Remove indicator from scrolling tab bars #123057

merged 1 commit into from Mar 21, 2023

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Mar 20, 2023

Fixes #85230

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. a: fidelity Matching the OEM platforms better f: scrolling Viewports, list views, slivers, etc. labels Mar 20, 2023
TahaTesser
TahaTesser approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 21, 2023

auto label is removed for flutter/flutter, pr: 123057, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 21, 2023

auto label is removed for flutter/flutter, pr: 123057, due to - The status or check suite Mac tool_tests_commands has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2023
@auto-submit auto-submit bot merged commit 4be45e9 into flutter:master Mar 21, 2023
66 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
4be45e950 Remove indicator from scrolling tab bars (flutter/flutter#1…
0c5542b 
…23057)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
4be45e950 Remove indicator from scrolling tab bars (flutter/flutter#1…
38ddd31 
…23057)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
4be45e950 Remove indicator from scrolling tab bars (flutter/flutter#1…
8838287 
…23057)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
4be45e950 Remove indicator from scrolling tab bars (flutter/flutter#1…
ce9fd09 
…23057)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
4be45e950 Remove indicator from scrolling tab bars (flutter/flutter#1…
4ff35a1 
…23057)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2023
@engine-flutter-autoroll
4be45e950 Remove indicator from scrolling tab bars (flutter/flutter#1…
0ad20ab 
…23057)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
4be45e950 Remove indicator from scrolling tab bars (flutter/flutter#1…
abfce1a 
…23057)
This was referenced Mar 23, 2023
Merged
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
4be45e950 Remove indicator from scrolling tab bars (flutter/flutter#1…
c0c5c43 
…23057)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
4be45e950 Remove indicator from scrolling tab bars (flutter/flutter#1…
eb68cf7 
…23057)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 23, 2023
@engine-flutter-autoroll
4be45e950 Remove indicator from scrolling tab bars (flutter/flutter#1…
bced030 
…23057)
@HansMuller HansMuller mentioned this pull request Mar 24, 2023
Open
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
4be45e950 Remove indicator from scrolling tab bars (flutter/flutter#1…
2e5849d 
…23057)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
4be45e950 Remove indicator from scrolling tab bars (flutter/flutter#1…
24bbc72 
…23057)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TahaTesser TahaTesser TahaTesser approved these changes

@guidezpl guidezpl Awaiting requested review from guidezpl

Assignees
No one assigned
Labels
a: fidelity Matching the OEM platforms better autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scrollable TabBars have a glow effect on Android
2 participants
@Piinks @TahaTesser