-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-generate lockfiles for gradle_deprecated_settings integration test #123126
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Hmm, looks like it is failing to download dependencies because it can't find version 2.0.9 of flutter_plugin_android_lifecycle. |
Seems like a similar PR here failed: #119290. Need to look into if there is similarity in why. |
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Note for you gradles documentation says to write locks use |
Closing in favor of #128898 |
This fixes #122039.
To generate these changes I ran
echo ./android/ | dart ~/development/flutter/flutter/dev/tools/bin/generate_gradle_lockfiles.dart
from
flutter/dev/integration_tests/gradle_deprecated_settings
I also had to change a version in gradle-wrapper.properties and added an android-exported flag, to allow the script to run.
I confirmed that the test passes by running
dart run test test/integration.shard/deprecated_gradle_settings_test.dart
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.