Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-generate lockfiles for gradle_deprecated_settings integration test #123126

Closed
wants to merge 8 commits into from

Conversation

gmackall
Copy link
Member

@gmackall gmackall commented Mar 21, 2023

This fixes #122039.

To generate these changes I ran
echo ./android/ | dart ~/development/flutter/flutter/dev/tools/bin/generate_gradle_lockfiles.dart
from
flutter/dev/integration_tests/gradle_deprecated_settings
I also had to change a version in gradle-wrapper.properties and added an android-exported flag, to allow the script to run.

I confirmed that the test passes by running
dart run test test/integration.shard/deprecated_gradle_settings_test.dart

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Mar 21, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@gmackall gmackall changed the title Regenerate lockfiles for gradle_deprecated_settings integration test Re-generate lockfiles for gradle_deprecated_settings integration test Mar 21, 2023
@gmackall
Copy link
Member Author

Hmm, looks like it is failing to download dependencies because it can't find version 2.0.9 of flutter_plugin_android_lifecycle.

@gmackall
Copy link
Member Author

Seems like a similar PR here failed: #119290.

Need to look into if there is similarity in why.

@flutter-dashboard
Copy link

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@gmackall gmackall marked this pull request as draft April 12, 2023 16:19
@flutter-dashboard
Copy link

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@reidbaker
Copy link
Contributor

Note for you gradles documentation says to write locks use ./gradlew --write-locks. It appears that flutter wrote their own task to update locks which is available to run with ./gradlew :generateLockfiles

@gmackall
Copy link
Member Author

gmackall commented Jun 14, 2023

Closing in favor of #128898

@gmackall gmackall closed this Jun 14, 2023
@gmackall gmackall deleted the integration_lockfile_issue branch January 17, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating to androidx.annotation:annotation:1.5.0 is causing CI failures.
2 participants