Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Documentation] Add ActionChip in disabled state #123143

Merged
merged 5 commits into from Mar 25, 2023
Merged

[Documentation] Add ActionChip in disabled state #123143

merged 5 commits into from Mar 25, 2023

Conversation

mateusfccp
Copy link
Contributor

@mateusfccp mateusfccp commented Mar 21, 2023 •
edited

According to my tests, disabledState on ChipTheme also affects ActionChip.

This PR includes ActionChip in the documentation for this case.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Mar 21, 2023
gspencergoog
gspencergoog approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Thanks for the PR!

chunhtai
chunhtai approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter/lib/src/material/chip_theme.dart Outdated Show resolved Hide resolved
mateusfccp and others added 2 commits March 24, 2023 19:33
@mateusfccp @chunhtai
Add conjunction for better reading
72acdd0 
Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>
@mateusfccp
Merge branch 'master' into patch-2
8ad8116
@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 24, 2023
@auto-submit auto-submit bot merged commit 8636e33 into flutter:master Mar 25, 2023
72 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2023
@engine-flutter-autoroll
8636e3339 [Documentation] Add ActionChip in disabled state (flutter/f…
b3ed198 
…lutter#123143)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2023
@engine-flutter-autoroll
8636e3339 [Documentation] Add ActionChip in disabled state (flutter/f…
7c51be9 
…lutter#123143)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2023
@engine-flutter-autoroll
8636e3339 [Documentation] Add ActionChip in disabled state (flutter/f…
bf5dda6 
…lutter#123143)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 27, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2023
@engine-flutter-autoroll
8636e3339 [Documentation] Add ActionChip in disabled state (flutter/f…
35d8f20 
…lutter#123143)
This was referenced Mar 28, 2023
Merged
Merged
@reidbaker reidbaker mentioned this pull request Apr 5, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
8636e3339 [Documentation] Add ActionChip in disabled state (flutter/f…
750facf 
…lutter#123143)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
8636e3339 [Documentation] Add ActionChip in disabled state (flutter/f…
76f66eb 
…lutter#123143)
@mateusfccp mateusfccp deleted the patch-2 branch August 18, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

@chunhtai chunhtai chunhtai approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mateusfccp @gspencergoog @chunhtai