Fix (insert|move|remove)RenderObjectChild methods in base class #123276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
f: cupertino
goderbauer
commented
Mar 22, 2023
| @@ -856,7 +856,7 @@ class _CupertinoDialogRenderElement extends RenderObjectElement { | |||
| @override | |||
| void moveRenderObjectChild(RenderObject child, _AlertDialogSections oldSlot, _AlertDialogSections newSlot) { | |||
| if (!allowMoveRenderObjectChild) { | |||
| super.moveRenderObjectChild(child, oldSlot, newSlot); | |||
| assert(false); | |||
There was a problem hiding this comment.
From context and from the PR [1] that introduced the allowMoveRenderObjectChild flag it seemed like the assumption is that moveRenderObjectChild is never called when allowMoveRenderObjectChild is false, hence this change here.
[1] 2425814#diff-4ea2907696de4fecf42f2ca56278a7b1d90c28921b1259d18ae28b1a2553d8e8L413
Piinks
added
team
Piinks
approved these changes
Mar 22, 2023
Piinks
reviewed
Mar 22, 2023
goderbauer
added
the
autosubmit
goderbauer
force-pushed
the
deprecationFollowUp
branch
from
94d5409
to
477366e
Compare
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/flutter, pr: 123276, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
goderbauer
force-pushed
the
deprecationFollowUp
branch
from
477366e
to
20a7a0a
Compare
goderbauer
added
the
autosubmit
goderbauer
force-pushed
the
deprecationFollowUp
branch
from
20a7a0a
to
b292e21
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 23, 2023
tarrinneal
pushed a commit
to flutter/packages
that referenced
this pull request
Mar 24, 2023
…3535) * cbdee5251 Roll Flutter Engine from 59acb5362098 to 12c822327825 (3 revisions) (flutter/flutter#123330) * 897e3db40 Inject the gstatic CanvasKit CDN URL by default in `flutter build web` (flutter/flutter#122772) * 5a36bddd2 Stop serving Observatory by default (flutter/flutter#122419) * b212e7b32 implement Iterator and Comparable instead of extending them (flutter/flutter#123282) * af6029c8f c0fbe5a53 Roll Dart SDK from 9256fffbd5af to e8e045620234 (1 revision) (flutter/engine#40561) (flutter/flutter#123336) * 9dec4fbd1 FIX: NavigationDrawer hover/focus/pressed does not use indicatorShape (flutter/flutter#123325) * 4907464a6 20ab040cd Roll Skia from ce5ff5cc03ce to c42320d53714 (2 revisions) (flutter/engine#40565) (flutter/flutter#123340) * 28d40a4d2 Roll Packages from 75491e9 to 0826798 (5 revisions) (flutter/flutter#123342) * 674ff1573 [macOS] Add platform_channel sample/test (flutter/flutter#123141) * 7b7af9f34 roll packages (flutter/flutter#123339) * 31798757e replace some ._() constructors with class modifiers (flutter/flutter#122765) * 7f41ab25c Fix (insert|move|remove)RenderObjectChild methods in base class (flutter/flutter#123276) * fccca4937 Refactor buildOverscrollIndicator (flutter/flutter#123246) * 11bbce1b2 6b0933e74 [web] Add `dart:js_interop` to `_embedder.yaml`. (flutter/engine#40545) (flutter/flutter#123347) * 716d25246 Remove prefer_const_constructors ignores (flutter/flutter#123284) * 100cf21e2 Prefer enum over class. (flutter/flutter#123312) * 5ef9b847a Expose toggle to textfield's opacity animation. (flutter/flutter#122474) * d79f3aab0 Roll Flutter Engine from 6b0933e74965 to bdce896fb64f (2 revisions) (flutter/flutter#123351)
This was referenced Mar 28, 2023
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
nploi
pushed a commit
to nploi/packages
that referenced
this pull request
Jul 16, 2023
…lutter#3535) * cbdee5251 Roll Flutter Engine from 59acb5362098 to 12c822327825 (3 revisions) (flutter/flutter#123330) * 897e3db40 Inject the gstatic CanvasKit CDN URL by default in `flutter build web` (flutter/flutter#122772) * 5a36bddd2 Stop serving Observatory by default (flutter/flutter#122419) * b212e7b32 implement Iterator and Comparable instead of extending them (flutter/flutter#123282) * af6029c8f c0fbe5a53 Roll Dart SDK from 9256fffbd5af to e8e045620234 (1 revision) (flutter/engine#40561) (flutter/flutter#123336) * 9dec4fbd1 FIX: NavigationDrawer hover/focus/pressed does not use indicatorShape (flutter/flutter#123325) * 4907464a6 20ab040cd Roll Skia from ce5ff5cc03ce to c42320d53714 (2 revisions) (flutter/engine#40565) (flutter/flutter#123340) * 28d40a4d2 Roll Packages from 75491e9 to 0826798 (5 revisions) (flutter/flutter#123342) * 674ff1573 [macOS] Add platform_channel sample/test (flutter/flutter#123141) * 7b7af9f34 roll packages (flutter/flutter#123339) * 31798757e replace some ._() constructors with class modifiers (flutter/flutter#122765) * 7f41ab25c Fix (insert|move|remove)RenderObjectChild methods in base class (flutter/flutter#123276) * fccca4937 Refactor buildOverscrollIndicator (flutter/flutter#123246) * 11bbce1b2 6b0933e74 [web] Add `dart:js_interop` to `_embedder.yaml`. (flutter/engine#40545) (flutter/flutter#123347) * 716d25246 Remove prefer_const_constructors ignores (flutter/flutter#123284) * 100cf21e2 Prefer enum over class. (flutter/flutter#123312) * 5ef9b847a Expose toggle to textfield's opacity animation. (flutter/flutter#122474) * d79f3aab0 Roll Flutter Engine from 6b0933e74965 to bdce896fb64f (2 revisions) (flutter/flutter#123351)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #123087.
The reason why these now-removed asserts existed was to guide people in the migration from the old deprecated to the new methods. The old deprecated methods were removed in #98616, but we forgot to remove these asserts.
This change makes (insert|move|remove)RenderObjectChild abstract again, like the old ones were before they were deprecated, see https://github.com/flutter/flutter/pull/64254/files.