-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[macOS] Battery check in platform_channel sample #123354
Conversation
Adds a check for the case where a device has no battery present. The devicelab test expects the text "No battery." in the case where a device has no battery. This is triggered by returning an error with a NO_BATTERY error code. Issue: flutter#79204
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had two comments in #123141 post-merge.
test-exempt: is a test |
Adds a check for the case where a device has no battery present. The devicelab test expects the text "No battery." in the case where a device has no battery. This is triggered by returning an error with a NO_BATTERY error code.
Also fixes a missing return statement after returning an error.
No new test code since this fixes an existing (failing) devicelab test in bringup status, which was added in #123141
Issue: #79204
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.