Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Web resources CDN in service_worker_test by default #123360

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Use Web resources CDN in service_worker_test by default #123360

merged 2 commits into from
Mar 24, 2023

Conversation

harryterkelsen
Copy link
Contributor

Use CDN CanvasKit resources for service worker test.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Mar 23, 2023
@harryterkelsen harryterkelsen merged commit 4e58370 into flutter:master Mar 24, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 24, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 24, 2023
@engine-flutter-autoroll
4e58370cb Use Web resources CDN in service_worker_test by default (fl…
f96c9ee 
…utter/flutter#123360)
This was referenced Mar 28, 2023
Merged
Merged
@reidbaker reidbaker mentioned this pull request Apr 5, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
4e58370cb Use Web resources CDN in service_worker_test by default (fl…
24612bd 
…utter/flutter#123360)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
4e58370cb Use Web resources CDN in service_worker_test by default (fl…
afa3517 
…utter/flutter#123360)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdebbar mdebbar mdebbar approved these changes

Assignees
No one assigned
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@harryterkelsen @mdebbar