-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the copy icon in snippets and samples to use the standard one #123651
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…lutter#123651) ## Description This updates the copy icon for copying sample code to use `content_copy` instead of `assignment`. Before: <img width="369" alt="223876418-2470c4c5-abfc-4511-9762-1fd0b6e05903" src="https://user-images.githubusercontent.com/8867023/228396142-450125ee-d8cf-4ede-8545-5920eb0da99d.png"> After: <img width="408" alt="image" src="https://user-images.githubusercontent.com/8867023/228395959-8531704a-77aa-43af-9dcf-7456bb2ed090.png"> ## Related Issues - Fixes flutter#122246 ## Tests - No tests needed.
@gspencergoog in that screenshot of the after change, the icon is upside-down from the one in the material spec: https://fonts.google.com/icons?selected=Material+Symbols+Outlined:content_copy:FILL@0;wght@400;GRAD@0;opsz@48 Maybe they changed that icon at some point? Or maybe we have a subtle bug in Flutter. |
That's the "Material Symbols" version. We're using the "Material Icons" version. https://fonts.google.com/icons?selected=Material+Icons+Outlined:content_copy:&icon.set=Material+Icons Why they are inverted is a mystery you'll have to ask the material team. |
flutter/flutter@15cb1f8...42fb0b2 2023-04-18 katelovett@google.com Fix text theme dart fix cases (flutter/flutter#125052) 2023-04-18 gspencergoog@users.noreply.github.com Update the copy icon in snippets and samples to use the standard one (flutter/flutter#123651) 2023-04-18 jmccandless@google.com Remove unused context parameter (flutter/flutter#124254) 2023-04-18 jmccandless@google.com iOS spell check cursor placement (flutter/flutter#124875) 2023-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from d2973619074e to 55bb065c607b (1 revision) (flutter/flutter#125047) 2023-04-18 zanderso@users.noreply.github.com Stop running "_impeller_" benchmark variants (flutter/flutter#125044) 2023-04-18 engine-flutter-autoroll@skia.org Roll Packages from 0277f2a to faf53fb (7 revisions) (flutter/flutter#125040) 2023-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from c4396f9f602f to d2973619074e (6 revisions) (flutter/flutter#125039) 2023-04-18 fluttergithubbot@gmail.com Roll pub packages (flutter/flutter#125005) 2023-04-18 pateltirth454@gmail.com [InputDatePickerFormField] adds acceptEmptyDate to InputDatePickerFormField Widget (flutter/flutter#124143) 2023-04-18 44755140+werainkhatri@users.noreply.github.com relayout active ListWheelScrollView children every performLayout (flutter/flutter#124476) 2023-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4a603aaff32e to c4396f9f602f (2 revisions) (flutter/flutter#125007) 2023-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 20034a8d62c4 to 4a603aaff32e (2 revisions) (flutter/flutter#125004) 2023-04-18 katelovett@google.com Add optional axis specifier to static scrollable methods (flutter/flutter#124894) 2023-04-17 barpac02@gmail.com Update usage of standalone`pub` executable in flutter_tools testing docs (flutter/flutter#124898) 2023-04-17 warriorharish95668@gmail.com Add Harish Anbalagan to AUTHORS (flutter/flutter#124684) 2023-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from b2d07388ceb6 to 20034a8d62c4 (7 revisions) (flutter/flutter#125001) 2023-04-17 36861262+QuncCccccc@users.noreply.github.com Add an example for SearchBar (flutter/flutter#124992) 2023-04-17 47866232+chunhtai@users.noreply.github.com SelectionContainer's listeners can remove itself during listener call� (flutter/flutter#124624) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#3756) flutter/flutter@15cb1f8...42fb0b2 2023-04-18 katelovett@google.com Fix text theme dart fix cases (flutter/flutter#125052) 2023-04-18 gspencergoog@users.noreply.github.com Update the copy icon in snippets and samples to use the standard one (flutter/flutter#123651) 2023-04-18 jmccandless@google.com Remove unused context parameter (flutter/flutter#124254) 2023-04-18 jmccandless@google.com iOS spell check cursor placement (flutter/flutter#124875) 2023-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from d2973619074e to 55bb065c607b (1 revision) (flutter/flutter#125047) 2023-04-18 zanderso@users.noreply.github.com Stop running "_impeller_" benchmark variants (flutter/flutter#125044) 2023-04-18 engine-flutter-autoroll@skia.org Roll Packages from 0277f2a to faf53fb (7 revisions) (flutter/flutter#125040) 2023-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from c4396f9f602f to d2973619074e (6 revisions) (flutter/flutter#125039) 2023-04-18 fluttergithubbot@gmail.com Roll pub packages (flutter/flutter#125005) 2023-04-18 pateltirth454@gmail.com [InputDatePickerFormField] adds acceptEmptyDate to InputDatePickerFormField Widget (flutter/flutter#124143) 2023-04-18 44755140+werainkhatri@users.noreply.github.com relayout active ListWheelScrollView children every performLayout (flutter/flutter#124476) 2023-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4a603aaff32e to c4396f9f602f (2 revisions) (flutter/flutter#125007) 2023-04-18 engine-flutter-autoroll@skia.org Roll Flutter Engine from 20034a8d62c4 to 4a603aaff32e (2 revisions) (flutter/flutter#125004) 2023-04-18 katelovett@google.com Add optional axis specifier to static scrollable methods (flutter/flutter#124894) 2023-04-17 barpac02@gmail.com Update usage of standalone`pub` executable in flutter_tools testing docs (flutter/flutter#124898) 2023-04-17 warriorharish95668@gmail.com Add Harish Anbalagan to AUTHORS (flutter/flutter#124684) 2023-04-17 engine-flutter-autoroll@skia.org Roll Flutter Engine from b2d07388ceb6 to 20034a8d62c4 (7 revisions) (flutter/flutter#125001) 2023-04-17 36861262+QuncCccccc@users.noreply.github.com Add an example for SearchBar (flutter/flutter#124992) 2023-04-17 47866232+chunhtai@users.noreply.github.com SelectionContainer's listeners can remove itself during listener callâ�¦ (flutter/flutter#124624) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,ychris@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Description
This updates the copy icon for copying sample code to use
content_copy
instead ofassignment
.Before:
After:
Related Issues
Tests