New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Linux implementation of the platform view example #123731
Add Linux implementation of the platform view example #123731
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
6d9d42e
to
8c5585a
Compare
(The screenshot shows the wrong window title - fixed in the branch). |
f053dda
to
234c181
Compare
@robert-ancell Is this still on your radar? |
234c181
to
8f11f9b
Compare
Yes, @cbracken please review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
8f11f9b
to
e965620
Compare
Causes the build in flutter/flutter#123731 to fail
Build is failing due to:
For some reason the compiler must be optimizing this away, so I've made flutter/engine#43394 to ensure this symbol is exported. Other get_type() functions already have this change. |
The build fix has landed in the engine, will rebuild this PR once that engine is being used by Flutter. |
e965620
to
863ee44
Compare
@gspencergoog is the Google testing failure an issue? |
It is broken, but I think it's an error from a previous PR in the queue: it doesn't look related to this PR at all. I'd try rebasing to HEAD and see if you can move to a state that builds. [I'm not sure why you're the one that has bad luck here: this doesn't happen that often, I promise!] |
863ee44
to
105ca3c
Compare
Roll Flutter from 3ec96a8a4a5d to 544d30dbaddf (66 revisions) flutter/flutter@3ec96a8...544d30d 2023-07-12 engine-flutter-autoroll@skia.org Roll Packages from 188a846 to 2508714 (14 revisions) (flutter/flutter#130418) 2023-07-12 tessertaha@gmail.com Update `RadioListTile` tests format for M2/M3 (flutter/flutter#130391) 2023-07-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from d68ea304eeda to 5c887028810d (2 revisions) (flutter/flutter#130413) 2023-07-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from c7317a58466e to d68ea304eeda (1 revision) (flutter/flutter#130410) 2023-07-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3dbe7dbeb5d4 to c7317a58466e (1 revision) (flutter/flutter#130402) 2023-07-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 73093fdd77c3 to 3dbe7dbeb5d4 (1 revision) (flutter/flutter#130399) 2023-07-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 29c5c41eeb19 to 73093fdd77c3 (2 revisions) (flutter/flutter#130398) 2023-07-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3482e05776a7 to 29c5c41eeb19 (1 revision) (flutter/flutter#130393) 2023-07-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7de68c62742d to 3482e05776a7 (2 revisions) (flutter/flutter#130390) 2023-07-12 104349824+huycozy@users.noreply.github.com Make new issue template for 1P package (flutter/flutter#130065) 2023-07-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1b44d7ee1a60 to 7de68c62742d (4 revisions) (flutter/flutter#130384) 2023-07-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from e109a3c0c347 to 1b44d7ee1a60 (3 revisions) (flutter/flutter#130380) 2023-07-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from d00590fde18c to e109a3c0c347 (1 revision) (flutter/flutter#130371) 2023-07-12 engine-flutter-autoroll@skia.org Roll Flutter Engine from 875d87e02276 to d00590fde18c (5 revisions) (flutter/flutter#130369) 2023-07-12 polinach@google.com Enable not GCed leak tracking. (flutter/flutter#130159) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from e2df01610fb3 to 875d87e02276 (3 revisions) (flutter/flutter#130359) 2023-07-11 cbobbe@zulip.com autocomplete: Remove mistaken paragraph in `onSelected` doc (flutter/flutter#130190) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 59f234645dd2 to e2df01610fb3 (3 revisions) (flutter/flutter#130357) 2023-07-11 thkim1011@users.noreply.github.com Refactor refresh_indicator.1.dart to not use shrinkwrap (flutter/flutter#129377) 2023-07-11 info@ttanimichi.com Links in `material` library docs are outdated (flutter/flutter#129891) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from afee1db31e5e to 59f234645dd2 (2 revisions) (flutter/flutter#130352) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 75ada1bdf9fd to afee1db31e5e (1 revision) (flutter/flutter#130349) 2023-07-11 polinach@google.com Upgrade leak_tracker to 7.0.6. (flutter/flutter#130346) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0011db79d41f to 75ada1bdf9fd (2 revisions) (flutter/flutter#130345) 2023-07-11 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#130289) 2023-07-11 36861262+QuncCccccc@users.noreply.github.com `DropdownMenu` can be expanded to its parent size (flutter/flutter#129753) 2023-07-11 engine-flutter-autoroll@skia.org Roll Packages from 4469c5e to 188a846 (6 revisions) (flutter/flutter#130340) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from d75c70870f86 to 0011db79d41f (2 revisions) (flutter/flutter#130337) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5e9f0d61a42a to d75c70870f86 (1 revision) (flutter/flutter#130332) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 417c50199e14 to 5e9f0d61a42a (1 revision) (flutter/flutter#130330) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from bfda8f173fea to 417c50199e14 (2 revisions) (flutter/flutter#130324) 2023-07-11 tessertaha@gmail.com Add `Badge` widget to `NavigationBar` and `NavigationRail` examples (flutter/flutter#129834) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2139c8a90822 to bfda8f173fea (2 revisions) (flutter/flutter#130321) 2023-07-11 ian@hixie.ch Update labeler for recent changes (flutter/flutter#130168) 2023-07-11 hey@darshanrander.com fix: `ExpansionTileTheme.shape` assignment in `ExpansionTile` (flutter/flutter#127749) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 12aa98177cf2 to 2139c8a90822 (2 revisions) (flutter/flutter#130316) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 767f2fb8ab03 to 12aa98177cf2 (1 revision) (flutter/flutter#130315) 2023-07-11 ian@hixie.ch Implement preferPaintInterior correctly for _CompoundBorder (flutter/flutter#129851) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 153d9e1d598a to 767f2fb8ab03 (1 revision) (flutter/flutter#130313) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2c82dd7ec54b to 153d9e1d598a (2 revisions) (flutter/flutter#130311) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 312e4813a880 to 2c82dd7ec54b (1 revision) (flutter/flutter#130309) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 95316fbc25a7 to 312e4813a880 (2 revisions) (flutter/flutter#130307) 2023-07-11 robert.ancell@canonical.com Add Linux implementation of the platform view example (flutter/flutter#123731) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from daecd616f5a7 to 95316fbc25a7 (4 revisions) (flutter/flutter#130305) 2023-07-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2a0dd9d2f28e to daecd616f5a7 (3 revisions) (flutter/flutter#130298) 2023-07-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7d054abf842c to 2a0dd9d2f28e (4 revisions) (flutter/flutter#130296) ...
No description provided.