Roll engine to 6388e928801dece14033b9ca99421f473e1d2fd0. #12400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aam
approved these changes
Oct 4, 2017
Hixie
reviewed
Oct 4, 2017
| @@ -132,6 +132,8 @@ class _MethodCall implements Invocation { | |||
| Map<Symbol, dynamic> get namedArguments => <Symbol, dynamic>{}; | |||
| @override | |||
| List<dynamic> get positionalArguments => _arguments; | |||
| @override | |||
| List<Type> get typeArguments => throw new UnimplementedError(); | |||
There was a problem hiding this comment.
this should return a const <Type>[]
|
this seemed to cause a test failure in device lab, not sure if it's related. |
|
This may have regressed complex_layout_scroll_perf__memory end_total_kb. |
|
This also regressed microbenchmarks velocity_tracker_iteration. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.