Remove animation from ScrollBar #124120
Remove animation from ScrollBar #124120
Conversation
flutter-dashboard
bot
added
f: material design
| @@ -334,7 +333,7 @@ class _MaterialScrollbarState extends RawScrollbarState<_MaterialScrollbar> { | |||
| return Color.lerp( | |||
| _scrollbarTheme.thumbColor?.resolve(states) ?? idleColor, | |||
| _scrollbarTheme.thumbColor?.resolve(states) ?? hoverColor, | |||
| _hoverAnimationController.value, | |||
| 0 | |||
There was a problem hiding this comment.
This would not allow users to disable it, it would just disable the animation entirely for everyone. This is likely not the way to fix #116212
There was a problem hiding this comment.
The hover animation is part of the material design specification. We cannot simply remove it, likely the correct solution allows the user to disable it if it is not desired.
I am going to close this pull request because we cannot accept this change. If you would like to propose a new solution to the linked issue, please feel welcome to re-open it with changes or open a new one.
Thank you!
| TargetPlatform.windows, | ||
| }), | ||
| ); | ||
| // testWidgets('Scrollbar thumb color completes a hover animation', (WidgetTester tester) async { |
There was a problem hiding this comment.
Commenting out this test is also not a change we would want to make.
|
Perfect I got your point and have more clear picture. I'll make a new request. |
Removes the animation from the ScrollBar and fixes the delay to settle to right color, when hovering over it. It was happening because there was animation delay of 200, which making giving a perception of delay while hovering over ScrollBar, by removing animation, it fixes the delay and color is changed immediately.
Other possible solution was to make animation delay 0, but that would lead to useless lines of code about delay, which wouldn't be happening, instead i removed the lines about animation.
fixes #116212
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.