Fix a memory leak in AutomaticKeepAlive

[GregoryConrad]

Previously, if a KeepAliveHandle outlived an AutomaticKeepAlive (e.g., switching locations in the tree), it'd cause a memory leak by holding onto the AutomaticKeepAlive. This PR fixes that leak by calling removeListener once the listener is fired. See more: #123864 (comment)

This PR was spun off of #123864.

CC @dnfield @Piinks

[flutter-dashboard]

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

[dnfield]

Can you please add a test for this to make sure it doesn't get regressed?

[GregoryConrad]

@dnfield Should be all set!

[dnfield]

LGTM

[dnfield]

Great! This will need a second review from a contributor to land.

[Piinks]

Thank you!

I checked the Google testing failure, it is not related to the PR. A rebase should set it straight.

[goderbauer]

Did something go wrong with rebasing or updating this branch? Or is it really supposed to touch 158 files?

(removing the auto submit label for now)

[GregoryConrad]

@goderbauer Looks like GitHub's online UI messed up the rebase. Same thing happened to me yesterday. I'll fix it

[goderbauer]

Thanks. Re-added the label.

[auto-submit]

auto label is removed for flutter/flutter, pr: 124163, due to - The status or check suite Mac framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.

[GregoryConrad]

Going to rebase to trigger a re-test. Shouldn't be related to this PR since everything passed before.

[Piinks]

Next time, just send a ping. We and re-run most tests individually. The Google testing one is a special one. :)

[GregoryConrad]

Ok! Would you please remove the autosubmit for a second? Looks like a rebase somewhere got messed up and changed the engine.version. I'll sort it out

[GregoryConrad]

Branch should be fixed & up to date, ready for auto-submit. Sorry about the hassle! Lesson learned: will not be using GitHub's online branch update feature in the future 🙃

[tirth-multipl]

Branch should be fixed & up to date, ready for auto-submit. Sorry about the hassle! Lesson learned: will not be using GitHub's online branch update feature in the future 🙃

you could use this hack to fix 'update rebase (from github) mess' - https://sirolad.medium.com/other-peoples-commit-in-my-pull-request-github-afc1fa7528ea

[GregoryConrad]

@Piinks Hi! Is the google testing error still unrelated to this PR? Would a rebase help? Or should it be manually rerun?

Also, this PR should be all set for autosubmit!

[Piinks]

Hey @GregoryConrad sorry our CI has been having some troubles the last few days. I've rebased this to see if we can get this landed. There is another change that caused a lot of failures that has been getting caught up in other tests. Thanks for your patience.

[tirth-multipl]

Hey @GregoryConrad sorry our CI has been having some troubles the last few days. I've rebased this to see if we can get this landed. There is another change that caused a lot of failures that has been getting caught up in other tests. Thanks for your patience.

why did number of checks reduced to just 9?!