New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tools test for buildWeb compilation #124179
Conversation
|
||
final ProjectMigration migration = ProjectMigration(migrators); | ||
migration.run(); | ||
Future<void> buildWeb( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flutterVersion: flutterVersion, | ||
fileSystem: fileSystem, | ||
); | ||
await webBuilder.buildWeb( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This covers only one permutation of these parameters, but hopefully this gives an example that can be expanded on by the web team in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! Thanks!
CC @yjbanov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Thank you!
Add tools test for buildWeb compilation
Add some baseline web compilation tool tests to make changes like #124165 easier to test.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.