Use term wireless instead of network #124232

vashworth · 2023-04-05T16:56:52Z

Rename variables, update comments, etc from network to wireless to keep it more uniform.

Also, move non-overriden messages related to device selection into the file they're used.

Part 7 in breakdown of #121262.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

vashworth · 2023-04-05T17:25:52Z

packages/flutter_tools/lib/src/base/user_messages.dart

-  String flutterFoundSpecifiedDevices(int count, String deviceId) =>
-      'Found $count devices with name or id matching $deviceId:';
-  String flutterChooseDevice(int option, String name, String deviceId) => '[$option]: $name ($deviceId)';
-  String get flutterChooseOne => 'Please choose one (or "q" to quit)';


Moved messages as per this comment from original PR: https://github.com/flutter/flutter/pull/121262/files#r1115130107

jmagman · 2023-04-05T20:22:26Z

packages/flutter_tools/lib/src/mdns_discovery.dart

@@ -57,7 +57,7 @@ class MDnsVmServiceDiscovery {
  /// The [deviceVmservicePort] parameter may be used to specify which port
  /// to find.
  ///
-  /// The [isNetworkDevice] parameter flags whether to get the device IP
+  /// The [useDeviceIPAsHost] parameter flags whether to get the device IP


I read this as use Device IPAs Host (like an .ipa) which is confusing but I don't have a better suggestion.

christopherfujino · 2023-04-13T20:44:33Z

@vashworth are you ready to merge this one?

jmagman · 2023-04-13T20:50:59Z

@vashworth are you ready to merge this one?

She'll follow up next week.

renaming from network to wireless

e03a1bb

flutter-dashboard bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Apr 5, 2023

move non-overriden message to file used in

2e29181

vashworth commented Apr 5, 2023

View reviewed changes

vashworth marked this pull request as ready for review April 5, 2023 18:33

vashworth requested a review from jmagman April 5, 2023 18:33

jmagman approved these changes Apr 5, 2023

View reviewed changes

christopherfujino and others added 2 commits April 6, 2023 13:30

Merge branch 'master' into wireless_device_discovery_part_7

a7953bb

add back user message used in g3

e0cbfae

Merge branch 'master' into wireless_device_discovery_part_7

bc9015b

vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 19, 2023

auto-submit bot merged commit 48bb3c0 into flutter:master Apr 19, 2023
123 checks passed

engine-flutter-autoroll mentioned this pull request Apr 20, 2023

Roll Flutter from 3476b966524f to 9f2e7088310d (19 revisions) flutter/packages#3771

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023

48bb3c0bc Use term wireless instead of network (flutter/flutter#124232)

255500a

engine-flutter-autoroll mentioned this pull request Apr 20, 2023

Roll Flutter from 3476b966524f to 64591356b968 (20 revisions) flutter/packages#3773

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023

48bb3c0bc Use term wireless instead of network (flutter/flutter#124232)

82b0c8c

engine-flutter-autoroll mentioned this pull request Apr 20, 2023

Roll Flutter from 3476b966524f to 70ca469792ce (21 revisions) flutter/packages#3775

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023

48bb3c0bc Use term wireless instead of network (flutter/flutter#124232)

fad8166

engine-flutter-autoroll mentioned this pull request Apr 20, 2023

Roll Flutter from 3476b966524f to 0d023144d993 (25 revisions) flutter/packages#3777

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023

48bb3c0bc Use term wireless instead of network (flutter/flutter#124232)

9277b62

engine-flutter-autoroll mentioned this pull request Apr 20, 2023

Roll Flutter from 3476b966524f to 13f4fe409158 (26 revisions) flutter/packages#3778

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023

48bb3c0bc Use term wireless instead of network (flutter/flutter#124232)

ce3aecf

engine-flutter-autoroll mentioned this pull request Apr 20, 2023

Roll Flutter from 3476b966524f to 5764404f5c97 (27 revisions) flutter/packages#3779

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023

48bb3c0bc Use term wireless instead of network (flutter/flutter#124232)

e1de279

engine-flutter-autoroll mentioned this pull request Apr 20, 2023

Roll Flutter from 3476b966524f to d85e2fb810b6 (28 revisions) flutter/packages#3781

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023

48bb3c0bc Use term wireless instead of network (flutter/flutter#124232)

2feb38b

reidbaker mentioned this pull request Apr 20, 2023

i123636 android embedding v2 agp gradle kotlin update #125256

Closed

8 tasks

reidbaker mentioned this pull request Apr 21, 2023

[integration_test] add support for agp8.0 #125310

Closed

8 tasks

engine-flutter-autoroll mentioned this pull request Apr 21, 2023

Roll Flutter from 3476b966524f to 8784eb1d8e30 (46 revisions) flutter/packages#3788

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023

48bb3c0bc Use term wireless instead of network (flutter/flutter#124232)

bcdd77e

engine-flutter-autoroll mentioned this pull request Apr 21, 2023

Roll Flutter from 3476b966524f to c9004ff822cf (47 revisions) flutter/packages#3790

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023

48bb3c0bc Use term wireless instead of network (flutter/flutter#124232)

2786e70

reidbaker mentioned this pull request Apr 21, 2023

Test AGP 8.0 using java 17 #125323

Merged

8 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023

48bb3c0bc Use term wireless instead of network (flutter/flutter#124232)

0bff8b3

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023

48bb3c0bc Use term wireless instead of network (flutter/flutter#124232)

9b27446

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023

48bb3c0bc Use term wireless instead of network (flutter/flutter#124232)

4ea34f5

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023

48bb3c0bc Use term wireless instead of network (flutter/flutter#124232)

de305bf

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023

48bb3c0bc Use term wireless instead of network (flutter/flutter#124232)

f271501

engine-flutter-autoroll mentioned this pull request Apr 24, 2023

Manual roll Flutter from 3476b966524f to d85e2fb810b6 (28 revisions) flutter/packages#3807

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023

48bb3c0bc Use term wireless instead of network (flutter/flutter#124232)

7c585d4

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023

48bb3c0bc Use term wireless instead of network (flutter/flutter#124232)

2dd7c98

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023

48bb3c0bc Use term wireless instead of network (flutter/flutter#124232)

6764f80

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023

48bb3c0bc Use term wireless instead of network (flutter/flutter#124232)

32226c9

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023

48bb3c0bc Use term wireless instead of network (flutter/flutter#124232)

effe94e

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023

48bb3c0bc Use term wireless instead of network (flutter/flutter#124232)

aad974b

vashworth deleted the wireless_device_discovery_part_7 branch September 27, 2023 15:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use term wireless instead of network #124232

Use term wireless instead of network #124232

vashworth commented Apr 5, 2023 •

edited

vashworth Apr 5, 2023

jmagman Apr 5, 2023

christopherfujino commented Apr 13, 2023

jmagman commented Apr 13, 2023

Use term wireless instead of network #124232

Use term wireless instead of network #124232

Conversation

vashworth commented Apr 5, 2023 • edited

Pre-launch Checklist

vashworth Apr 5, 2023

Choose a reason for hiding this comment

jmagman Apr 5, 2023

Choose a reason for hiding this comment

christopherfujino commented Apr 13, 2023

jmagman commented Apr 13, 2023

vashworth commented Apr 5, 2023 •

edited