Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update re-thrown error for incompatible Java/Gradle versions to include migration guide #124327

Merged
merged 3 commits into from Apr 12, 2023

Conversation

camsim99
Copy link
Contributor

@camsim99 camsim99 commented Apr 6, 2023

Updates error message concerning incompatible Java/Gradle versions to reference migration guide that will be created in flutter/website#8501.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 6, 2023
@camsim99 camsim99 requested a review from reidbaker April 6, 2023 17:05
@gmackall
Copy link
Member

gmackall commented Apr 6, 2023

This LGTM if we are of the opinion that the info should only be on the migration guide.

I do somewhat think that there is value to leaving the existing steps, and then providing the link as a "for more info, see:" type of link. It can be a nicer experience to just see the answer, instead of having to copy a link and open it in a browser. But also understand if we want all the info in one place, instead of multiple.

@camsim99
Copy link
Contributor Author

camsim99 commented Apr 6, 2023

This LGTM if we are of the opinion that the info should only be on the migration guide.

I do somewhat think that there is value to leaving the existing steps, and then providing the link as a "for more info, see:" type of link. It can be a nicer experience to just see the answer, instead of having to copy a link and open it in a browser. But also understand if we want all the info in one place, instead of multiple.

I thought the same thing, but didn't want to be redundant. The current steps are definitely more vague than the guide, and the guide should include the information I had before. Deferring to @mariamhas and @reidbaker

@mariamhas
Copy link

mariamhas commented Apr 6, 2023

Gray you make a valid point on making it easier for developers, but if the steps are not robust enough or complete they might confuse the developer and end up making things more difficult. I think its better to keep the instructions in one place as source of truth for when we eventually have to update them again, itll be easier to do it in one place than several.

@gmackall
Copy link
Member

gmackall commented Apr 6, 2023

Gray you make a valid point on making it easier for developers, but if the steps are not robust enough or complete they might confuse the developer and end up making things more difficult. I think its better to keep the instructions in one place as source of truth for when we eventually have to update them again, itll be easier to do it in one place than several.

Sure, that makes sense! This LGTM then

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 12, 2023
@auto-submit auto-submit bot merged commit f582b56 into flutter:master Apr 12, 2023
123 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 13, 2023
exaby73 pushed a commit to exaby73/flutter_nevercode that referenced this pull request Apr 17, 2023
…de migration guide (flutter#124327)

Update re-thrown error for incompatible Java/Gradle versions to include migration guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants