New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update re-thrown error for incompatible Java/Gradle versions to include migration guide #124327
Conversation
This LGTM if we are of the opinion that the info should only be on the migration guide. I do somewhat think that there is value to leaving the existing steps, and then providing the link as a "for more info, see:" type of link. It can be a nicer experience to just see the answer, instead of having to copy a link and open it in a browser. But also understand if we want all the info in one place, instead of multiple. |
I thought the same thing, but didn't want to be redundant. The current steps are definitely more vague than the guide, and the guide should include the information I had before. Deferring to @mariamhas and @reidbaker |
Gray you make a valid point on making it easier for developers, but if the steps are not robust enough or complete they might confuse the developer and end up making things more difficult. I think its better to keep the instructions in one place as source of truth for when we eventually have to update them again, itll be easier to do it in one place than several. |
Sure, that makes sense! This LGTM then |
…s to include migration guide (flutter/flutter#124327)
…de migration guide (flutter#124327) Update re-thrown error for incompatible Java/Gradle versions to include migration guide
Updates error message concerning incompatible Java/Gradle versions to reference migration guide that will be created in flutter/website#8501.
Pre-launch Checklist
///
).