Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flutter tool: log dart2wasm vs dart2js as appropriate during build #124331

Merged
merged 2 commits into from Apr 6, 2023

Conversation

kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Apr 6, 2023

Relands #124165 - 929a5bd
Unreverts #124305 - 822632b

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 6, 2023
@kevmoo kevmoo requested review from yjbanov and zanderso April 6, 2023 16:55
@kevmoo kevmoo added the platform-web Web applications specifically label Apr 6, 2023
@zanderso
Copy link
Member

zanderso commented Apr 6, 2023

Looks like this PR is affected by #124332. It will probably have to be rebased to re-trigger presub checks after that infra issue is resolved.

Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 6, 2023
@auto-submit auto-submit bot merged commit 97d5cd5 into master Apr 6, 2023
122 checks passed
@auto-submit auto-submit bot deleted the wasm_analytics branch April 6, 2023 20:49
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2023
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
…lutter#124331)

flutter tool: log dart2wasm vs dart2js as appropriate during build
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Web applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants